From mboxrd@z Thu Jan  1 00:00:00 1970
From: Nicolas Goaziou <mail@nicolasgoaziou.fr>
Subject: Re: replace letf with cl-letf in org-mime
Date: Tue, 31 Mar 2015 12:42:11 +0200
Message-ID: <87zj6txxbw.fsf@nicolasgoaziou.fr>
References: <87wq29m8zm.fsf@ericabrahamsen.net>
	<87iodt2k3i.fsf@nicolasgoaziou.fr> <87619iopdj.fsf@ericabrahamsen.net>
Mime-Version: 1.0
Content-Type: text/plain
Return-path: <emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([2001:4830:134:3::10]:54158)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <mail@nicolasgoaziou.fr>) id 1YctbQ-0007XB-8B
	for emacs-orgmode@gnu.org; Tue, 31 Mar 2015 06:41:01 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <mail@nicolasgoaziou.fr>) id 1YctbL-0001iL-Vg
	for emacs-orgmode@gnu.org; Tue, 31 Mar 2015 06:41:00 -0400
Received: from relay4-d.mail.gandi.net ([2001:4b98:c:538::196]:43484)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <mail@nicolasgoaziou.fr>) id 1YctbL-0001hb-Op
	for emacs-orgmode@gnu.org; Tue, 31 Mar 2015 06:40:55 -0400
In-Reply-To: <87619iopdj.fsf@ericabrahamsen.net> (Eric Abrahamsen's message of
	"Mon, 30 Mar 2015 16:34:16 +0800")
List-Id: "General discussions about Org-mode." <emacs-orgmode.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/emacs-orgmode>,
	<mailto:emacs-orgmode-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/emacs-orgmode>
List-Post: <mailto:emacs-orgmode@gnu.org>
List-Help: <mailto:emacs-orgmode-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/emacs-orgmode>,
	<mailto:emacs-orgmode-request@gnu.org?subject=subscribe>
Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org
Sender: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org
To: Eric Abrahamsen <eric@ericabrahamsen.net>
Cc: emacs-orgmode@gnu.org

Hello,

Eric Abrahamsen <eric@ericabrahamsen.net> writes:

> Subject: [PATCH] org-mime.el: Avoid use of letf/cl-letf

Thank you. Some comments follow.

> +    (let* ((mp (lambda (p)) (org-entry-get nil p org-mime-use-property-inheritance))

It should be

  (mp (lambda (p) (org-entry-get ....)))

> +  (let ((bhook
> +	 (lambda (body fmt)
> +	   (let ((hook (intern (concat "org-mime-pre-"
> +				       (symbol-name fmt)
> +				       "-hook"))))
> +	     (if (> (eval `(length ,hook)) 0)
> +		 (with-temp-buffer
> +		   (insert body)
> +		   (goto-char (point-min))
> +		   (eval `(run-hooks ',hook))
> +		   (buffer-string))
> +	       body))))

Not really related to the patch but the `eval' in the definition above
looks wrong. Shouldn't it be

  (> (length hook) 0)

and

  (run-hooks hook)

?


Regards,