emacs-orgmode@gnu.org archives
 help / color / mirror / code / Atom feed
From: Eric Abrahamsen <eric@ericabrahamsen.net>
To: emacs-orgmode@gnu.org
Subject: replace letf with cl-letf in org-mime
Date: Sun, 22 Mar 2015 21:56:13 +0800	[thread overview]
Message-ID: <87wq29m8zm.fsf@ericabrahamsen.net> (raw)

[-- Attachment #1: Type: text/plain, Size: 64 bytes --]

It's amazing what an effect barky compiler errors can have.

E


[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: 0001-Use-cl-flet-rather-than-plain-flet.patch --]
[-- Type: text/x-diff, Size: 1975 bytes --]

From 0bba16a7419d32ecc25ccdf422c9d0e129d0b547 Mon Sep 17 00:00:00 2001
From: Eric Abrahamsen <eric@ericabrahamsen.net>
Date: Sun, 22 Mar 2015 21:39:57 +0800
Subject: [PATCH] Use `cl-flet' rather than plain `flet'

* contrib/lisp/org-mime.el (org-mime-send-subtree, org-mime-compose):
  The compiler complains otherwise.
---
 contrib/lisp/org-mime.el | 24 ++++++++++++------------
 1 file changed, 12 insertions(+), 12 deletions(-)

diff --git a/contrib/lisp/org-mime.el b/contrib/lisp/org-mime.el
index f341474..9f18dc6 100644
--- a/contrib/lisp/org-mime.el
+++ b/contrib/lisp/org-mime.el
@@ -252,7 +252,7 @@ export that region, otherwise export the entire body."
   (save-restriction
     (org-narrow-to-subtree)
     (run-hooks 'org-mime-send-subtree-hook)
-    (flet ((mp (p) (org-entry-get nil p org-mime-use-property-inheritance)))
+    (cl-flet ((mp (p) (org-entry-get nil p org-mime-use-property-inheritance)))
       (let* ((file (buffer-file-name (current-buffer)))
 	     (subject (or (mp "MAIL_SUBJECT") (nth 4 (org-heading-components))))
 	     (to (mp "MAIL_TO"))
@@ -287,17 +287,17 @@ export that region, otherwise export the entire body."
   (require 'message)
   (message-mail to subject headers nil)
   (message-goto-body)
-  (flet ((bhook (body fmt)
-		(let ((hook (intern (concat "org-mime-pre-"
-					    (symbol-name fmt)
-					    "-hook"))))
-		  (if (> (eval `(length ,hook)) 0)
-		      (with-temp-buffer
-			(insert body)
-			(goto-char (point-min))
-			(eval `(run-hooks ',hook))
-			(buffer-string))
-		    body))))
+  (cl-flet ((bhook (body fmt)
+		   (let ((hook (intern (concat "org-mime-pre-"
+					       (symbol-name fmt)
+					       "-hook"))))
+		     (if (> (eval `(length ,hook)) 0)
+			 (with-temp-buffer
+			   (insert body)
+			   (goto-char (point-min))
+			   (eval `(run-hooks ',hook))
+			   (buffer-string))
+		       body))))
     (let ((fmt (if (symbolp fmt) fmt (intern fmt))))
       (cond
        ((eq fmt 'org)
-- 
2.3.3


             reply	other threads:[~2015-03-22 14:00 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-03-22 13:56 Eric Abrahamsen [this message]
2015-03-22 14:16 ` replace letf with cl-letf in org-mime Nicolas Goaziou
2015-03-22 14:30   ` Eric Abrahamsen
2015-03-30  8:34   ` Eric Abrahamsen
2015-03-31 10:42     ` Nicolas Goaziou
2015-04-01  2:17       ` Eric Abrahamsen
2015-04-01 19:46         ` Nicolas Goaziou
2015-04-02  1:33           ` Eric Abrahamsen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.orgmode.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87wq29m8zm.fsf@ericabrahamsen.net \
    --to=eric@ericabrahamsen.net \
    --cc=emacs-orgmode@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).