From: Eric Abrahamsen <eric@ericabrahamsen.net>
To: emacs-orgmode@gnu.org
Subject: Re: replace letf with cl-letf in org-mime
Date: Thu, 02 Apr 2015 09:33:40 +0800 [thread overview]
Message-ID: <87bnj71fgr.fsf@ericabrahamsen.net> (raw)
In-Reply-To: 877ftvy6me.fsf@nicolasgoaziou.fr
[-- Attachment #1: Type: text/plain, Size: 829 bytes --]
Nicolas Goaziou <mail@nicolasgoaziou.fr> writes:
> Eric Abrahamsen <eric@ericabrahamsen.net> writes:
>
>> If I remove the two `eval's and treat "hook" like a normal variable, the
>> call to `length' fails with:
>>
>> Wrong type argument: sequencep, org-mime-pre-org-hook
>>
>> So apparently `length' is seeing the symbol name, and not the symbol
>> value.
>
> Indeed.
>
>> I tried changing the `let' to look like:
>>
>> (let ((hook (symbol-value (intern (....
>
> What about (length (symbol-value hook)) instead?
>
>> Here's a fixed version of the previous patch.
>
> Thank you. Applied.
>
>> I suppose I could also alter the "bhook" thing to use `symbol-value'
>> instead of `eval', but that doesn't seem to be a net gain.
>
> IMO, anything is a net gain compared to using `eval'.
Makes sense -- here's a fix for that.
Eric
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: 0001-org-mime.el-Avoid-use-of-eval.patch --]
[-- Type: text/x-diff, Size: 1064 bytes --]
From fc2c492b0e511d157664bf79ce0ba44031f3223b Mon Sep 17 00:00:00 2001
From: Eric Abrahamsen <eric@ericabrahamsen.net>
Date: Thu, 2 Apr 2015 09:29:29 +0800
Subject: [PATCH] org-mime.el: Avoid use of eval
* contrib/lisp/org-mime.el (org-mime-compose): Use a different
workaround for operating on the symbol vs symbol value.
---
contrib/lisp/org-mime.el | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/contrib/lisp/org-mime.el b/contrib/lisp/org-mime.el
index 1e7a3b8..3414876 100644
--- a/contrib/lisp/org-mime.el
+++ b/contrib/lisp/org-mime.el
@@ -292,11 +292,11 @@ export that region, otherwise export the entire body."
(let ((hook (intern (concat "org-mime-pre-"
(symbol-name fmt)
"-hook"))))
- (if (> (eval `(length ,hook)) 0)
+ (if (> (length (symbol-value hook)) 0)
(with-temp-buffer
(insert body)
(goto-char (point-min))
- (eval `(run-hooks ',hook))
+ (run-hooks hook)
(buffer-string))
body))))
(fmt (if (symbolp fmt) fmt (intern fmt))))
--
2.3.5
prev parent reply other threads:[~2015-04-02 1:34 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-03-22 13:56 replace letf with cl-letf in org-mime Eric Abrahamsen
2015-03-22 14:16 ` Nicolas Goaziou
2015-03-22 14:30 ` Eric Abrahamsen
2015-03-30 8:34 ` Eric Abrahamsen
2015-03-31 10:42 ` Nicolas Goaziou
2015-04-01 2:17 ` Eric Abrahamsen
2015-04-01 19:46 ` Nicolas Goaziou
2015-04-02 1:33 ` Eric Abrahamsen [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.orgmode.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87bnj71fgr.fsf@ericabrahamsen.net \
--to=eric@ericabrahamsen.net \
--cc=emacs-orgmode@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).