* Bug: org-files-list duplicate files [9.1.3 (9.1.3-29-g037db0-elpa @ ~/.emacs.d/elpa/org-20171204/)]
@ 2017-12-06 1:47 Renato Ferreira
2017-12-06 22:17 ` Nicolas Goaziou
0 siblings, 1 reply; 2+ messages in thread
From: Renato Ferreira @ 2017-12-06 1:47 UTC (permalink / raw)
To: emacs-orgmode
Hello,
Investigating an issue I was having with (org-resolve-clocks) that i would
need to resolve the same clock twice, i believe i stumbled upon the
following bug on (org-files-list) (used by (org-resolve-clocks)):
It gets a list from (org-agenda-files) and pushes the open org
buffers found through (buffer-list), but i believe it _incorrectly_ uses
(cl-pushnew) since it ultimately uses memql (which compares with eql) to
check existence of the buffer file name (a string) with the
(org-agenda-files) list (of strings), returning duplicate items on lists
since compared strings are not the same lisp objects.
Advising (org-files-list) with (delete-dups) is a workaround i'm using but
(org-files-list) needs to be changed to use member instead of memql.
Thank you very much.
Emacs : GNU Emacs 25.3.1 (x86_64-pc-linux-gnu, GTK+ Version 3.22.19)
of 2017-09-16
Package: Org mode version 9.1.3 (9.1.3-29-g037db0-elpa @ ~/.emacs.d/elpa/org-20171204/)
--
Att.,
Renato Ferreira
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: Bug: org-files-list duplicate files [9.1.3 (9.1.3-29-g037db0-elpa @ ~/.emacs.d/elpa/org-20171204/)]
2017-12-06 1:47 Bug: org-files-list duplicate files [9.1.3 (9.1.3-29-g037db0-elpa @ ~/.emacs.d/elpa/org-20171204/)] Renato Ferreira
@ 2017-12-06 22:17 ` Nicolas Goaziou
0 siblings, 0 replies; 2+ messages in thread
From: Nicolas Goaziou @ 2017-12-06 22:17 UTC (permalink / raw)
To: Renato Ferreira; +Cc: emacs-orgmode
Hello,
Renato Ferreira <renatofdds@gmail.com> writes:
> Investigating an issue I was having with (org-resolve-clocks) that i would
> need to resolve the same clock twice, i believe i stumbled upon the
> following bug on (org-files-list) (used by (org-resolve-clocks)):
>
> It gets a list from (org-agenda-files) and pushes the open org
> buffers found through (buffer-list), but i believe it _incorrectly_ uses
> (cl-pushnew) since it ultimately uses memql (which compares with eql) to
> check existence of the buffer file name (a string) with the
> (org-agenda-files) list (of strings), returning duplicate items on lists
> since compared strings are not the same lisp objects.
>
> Advising (org-files-list) with (delete-dups) is a workaround i'm using but
> (org-files-list) needs to be changed to use member instead of memql.
Fixed. Thank you.
Regards,
--
Nicolas Goaziou
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2017-12-06 22:17 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-12-06 1:47 Bug: org-files-list duplicate files [9.1.3 (9.1.3-29-g037db0-elpa @ ~/.emacs.d/elpa/org-20171204/)] Renato Ferreira
2017-12-06 22:17 ` Nicolas Goaziou
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).