From mboxrd@z Thu Jan  1 00:00:00 1970
From: Nicolas Goaziou <mail@nicolasgoaziou.fr>
Subject: Re: Bug: org-files-list duplicate files [9.1.3
 (9.1.3-29-g037db0-elpa @ ~/.emacs.d/elpa/org-20171204/)]
Date: Wed, 06 Dec 2017 23:17:13 +0100
Message-ID: <87y3mfo61i.fsf@nicolasgoaziou.fr>
References: <87vahk7hkz.fsf@gmail.com>
Mime-Version: 1.0
Content-Type: text/plain
Return-path: <emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([2001:4830:134:3::10]:50523)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <mail@nicolasgoaziou.fr>) id 1eMi0E-0002Tq-4U
	for emacs-orgmode@gnu.org; Wed, 06 Dec 2017 17:17:18 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <mail@nicolasgoaziou.fr>) id 1eMi0D-0005dX-BT
	for emacs-orgmode@gnu.org; Wed, 06 Dec 2017 17:17:18 -0500
Received: from relay2-d.mail.gandi.net ([2001:4b98:c:538::194]:39866)
	by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32)
	(Exim 4.71) (envelope-from <mail@nicolasgoaziou.fr>)
	id 1eMi0D-0005cq-5F
	for emacs-orgmode@gnu.org; Wed, 06 Dec 2017 17:17:17 -0500
In-Reply-To: <87vahk7hkz.fsf@gmail.com> (Renato Ferreira's message of "Tue, 05
	Dec 2017 23:47:40 -0200")
List-Id: "General discussions about Org-mode." <emacs-orgmode.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/emacs-orgmode>,
	<mailto:emacs-orgmode-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/emacs-orgmode/>
List-Post: <mailto:emacs-orgmode@gnu.org>
List-Help: <mailto:emacs-orgmode-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/emacs-orgmode>,
	<mailto:emacs-orgmode-request@gnu.org?subject=subscribe>
Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org
Sender: "Emacs-orgmode"
	<emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org>
To: Renato Ferreira <renatofdds@gmail.com>
Cc: emacs-orgmode@gnu.org

Hello,

Renato Ferreira <renatofdds@gmail.com> writes:

> Investigating an issue I was having with (org-resolve-clocks) that i would
> need to resolve the same clock twice, i believe i stumbled upon the
> following bug on (org-files-list) (used by (org-resolve-clocks)):
>
> It gets a list from (org-agenda-files) and pushes the open org
> buffers found through (buffer-list), but i believe it _incorrectly_ uses
> (cl-pushnew) since it ultimately uses memql (which compares with eql) to
> check existence of the buffer file name (a string) with the
> (org-agenda-files) list (of strings), returning duplicate items on lists
> since compared strings are not the same lisp objects.
>
> Advising (org-files-list) with (delete-dups) is a workaround i'm using but
> (org-files-list) needs to be changed to use member instead of memql.

Fixed. Thank you.

Regards,

-- 
Nicolas Goaziou