From mboxrd@z Thu Jan 1 00:00:00 1970 From: Renato Ferreira Subject: Bug: org-files-list duplicate files [9.1.3 (9.1.3-29-g037db0-elpa @ ~/.emacs.d/elpa/org-20171204/)] Date: Tue, 05 Dec 2017 23:47:40 -0200 Message-ID: <87vahk7hkz.fsf@gmail.com> Mime-Version: 1.0 Content-Type: text/plain Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:42678) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1eMOoO-0007YI-VT for emacs-orgmode@gnu.org; Tue, 05 Dec 2017 20:47:49 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1eMOoL-00076R-NH for emacs-orgmode@gnu.org; Tue, 05 Dec 2017 20:47:49 -0500 Received: from mail-qt0-x236.google.com ([2607:f8b0:400d:c0d::236]:41390) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1eMOoL-000761-Hr for emacs-orgmode@gnu.org; Tue, 05 Dec 2017 20:47:45 -0500 Received: by mail-qt0-x236.google.com with SMTP id i40so5479117qti.8 for ; Tue, 05 Dec 2017 17:47:45 -0800 (PST) Received: from note (179-96-149-30.life.com.br. [179.96.149.30]) by smtp.gmail.com with ESMTPSA id k3sm740322qtj.40.2017.12.05.17.47.42 for (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Tue, 05 Dec 2017 17:47:43 -0800 (PST) List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org Sender: "Emacs-orgmode" To: emacs-orgmode@gnu.org Hello, Investigating an issue I was having with (org-resolve-clocks) that i would need to resolve the same clock twice, i believe i stumbled upon the following bug on (org-files-list) (used by (org-resolve-clocks)): It gets a list from (org-agenda-files) and pushes the open org buffers found through (buffer-list), but i believe it _incorrectly_ uses (cl-pushnew) since it ultimately uses memql (which compares with eql) to check existence of the buffer file name (a string) with the (org-agenda-files) list (of strings), returning duplicate items on lists since compared strings are not the same lisp objects. Advising (org-files-list) with (delete-dups) is a workaround i'm using but (org-files-list) needs to be changed to use member instead of memql. Thank you very much. Emacs : GNU Emacs 25.3.1 (x86_64-pc-linux-gnu, GTK+ Version 3.22.19) of 2017-09-16 Package: Org mode version 9.1.3 (9.1.3-29-g037db0-elpa @ ~/.emacs.d/elpa/org-20171204/) -- Att., Renato Ferreira