* Re: [bzg/org-mode] Added latex export option to ob-plantuml.el (#1)
[not found] ` <bzg/org-mode/pull/1/c389765752@github.com>
@ 2018-05-21 3:03 ` Roger J. H. Welsh
2018-05-22 9:16 ` Nicolas Goaziou
0 siblings, 1 reply; 4+ messages in thread
From: Roger J. H. Welsh @ 2018-05-21 3:03 UTC (permalink / raw)
To: emacs-orgmode
[-- Attachment #1.1: Type: text/plain, Size: 663 bytes --]
Hi,
I have a patch to add the latex export option to ob-plantuml.el .
I originally tried to submit a Pull Request to a repo on github.
https://github.com/rjhwelsh/org-mode/commit/dd69e979b4a8fdd0bb70306e0afb339720659dc5.patch
> Hi, thanks for your contribution but this github repo don't take patches, I should have closed the ability to send PR. Can you resend your patch to emacs-orgmode@gnu.org ? Thanks a lot !
Bastien informed me that I should send it on this way.
Patch is also attached.
Is there any other preferred method to contribute other than patch over email?
--
Kind regards,
Roger Welsh
fpr: 2FCB 9E31 EA77 CDEC A3AE 5DD7 D54C C777 553A 180D
[-- Attachment #1.2: dd69e979b4a8fdd0bb70306e0afb339720659dc5.patch --]
[-- Type: text/x-diff, Size: 919 bytes --]
From dd69e979b4a8fdd0bb70306e0afb339720659dc5 Mon Sep 17 00:00:00 2001
From: rjhwelsh <30714737+rjhwelsh@users.noreply.github.com>
Date: Thu, 17 May 2018 15:36:41 +1200
Subject: [PATCH] Update ob-plantuml.el
---
lisp/ob-plantuml.el | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/lisp/ob-plantuml.el b/lisp/ob-plantuml.el
index 9a9313e7b..3326a6419 100644
--- a/lisp/ob-plantuml.el
+++ b/lisp/ob-plantuml.el
@@ -92,7 +92,9 @@ This function is called by `org-babel-execute-src-block'."
(if (string= (file-name-extension out-file) "eps")
" -teps" "")
(if (string= (file-name-extension out-file) "pdf")
- " -tpdf" "")
+ " -tpdf" "")
+ (if (string= (file-name-extension out-file) "tex")
+ " -tlatex" "")
(if (string= (file-name-extension out-file) "vdx")
" -tvdx" "")
(if (string= (file-name-extension out-file) "xmi")
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [bzg/org-mode] Added latex export option to ob-plantuml.el (#1)
2018-05-21 3:03 ` [bzg/org-mode] Added latex export option to ob-plantuml.el (#1) Roger J. H. Welsh
@ 2018-05-22 9:16 ` Nicolas Goaziou
2018-05-23 4:50 ` Roger J. H. Welsh
0 siblings, 1 reply; 4+ messages in thread
From: Nicolas Goaziou @ 2018-05-22 9:16 UTC (permalink / raw)
To: Roger J. H. Welsh; +Cc: emacs-orgmode
Hello,
"Roger J. H. Welsh" <rjhwelsh@gmail.com> writes:
> Patch is also attached.
Thank you. Could you provide a proper commit message, i.e., including
the function being modified:
* lisp/ob-plantuml.el (... function ...): ... change ...
You also need to add TINYCHANGE at the end of the message if you haven't
signed FSF papers yet.
> Is there any other preferred method to contribute other than patch
> over email?
No there isn't. Patch over email is the way to go.
Regards,
--
Nicolas Goaziou
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [bzg/org-mode] Added latex export option to ob-plantuml.el (#1)
2018-05-22 9:16 ` Nicolas Goaziou
@ 2018-05-23 4:50 ` Roger J. H. Welsh
2018-05-30 11:45 ` Nicolas Goaziou
0 siblings, 1 reply; 4+ messages in thread
From: Roger J. H. Welsh @ 2018-05-23 4:50 UTC (permalink / raw)
To: Nicolas Goaziou; +Cc: emacs-orgmode
[-- Attachment #1.1: Type: text/plain, Size: 562 bytes --]
On Tue, May 22, 2018 at 11:16:44AM +0200 , Nicolas Goaziou wrote:
> Thank you. Could you provide a proper commit message, i.e., including
> the function being modified:
>
> * lisp/ob-plantuml.el (... function ...): ... change ...
I have made the changes to the patch.
Does this fit your requirements?
> You also need to add TINYCHANGE at the end of the message if you haven't
> signed FSF papers yet.
This is my first contribution.
What papers should I sign for regular contributions?
--
Roger Welsh
fpr: 2FCB 9E31 EA77 CDEC A3AE 5DD7 D54C C777 553A 180D
[-- Attachment #1.2: dd69e979b4a8fdd0bb70306e0afb339720659dc5.patch --]
[-- Type: text/x-diff, Size: 960 bytes --]
From dd69e979b4a8fdd0bb70306e0afb339720659dc5 Mon Sep 17 00:00:00 2001
From: rjhwelsh <rjhwelsh@gmail.com>
Date: Thu, 17 May 2018 15:36:41 +1200
Subject: [PATCH] * lisp/ob-plantuml.el (org-babel-execute:plantuml): Added latex output support TINYCHANGE
---
lisp/ob-plantuml.el | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/lisp/ob-plantuml.el b/lisp/ob-plantuml.el
index 9a9313e7b..3326a6419 100644
--- a/lisp/ob-plantuml.el
+++ b/lisp/ob-plantuml.el
@@ -92,7 +92,9 @@ This function is called by `org-babel-execute-src-block'."
(if (string= (file-name-extension out-file) "eps")
" -teps" "")
(if (string= (file-name-extension out-file) "pdf")
- " -tpdf" "")
+ " -tpdf" "")
+ (if (string= (file-name-extension out-file) "tex")
+ " -tlatex" "")
(if (string= (file-name-extension out-file) "vdx")
" -tvdx" "")
(if (string= (file-name-extension out-file) "xmi")
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [bzg/org-mode] Added latex export option to ob-plantuml.el (#1)
2018-05-23 4:50 ` Roger J. H. Welsh
@ 2018-05-30 11:45 ` Nicolas Goaziou
0 siblings, 0 replies; 4+ messages in thread
From: Nicolas Goaziou @ 2018-05-30 11:45 UTC (permalink / raw)
To: Roger J. H. Welsh; +Cc: emacs-orgmode
Hello,
"Roger J. H. Welsh" <rjhwelsh@gmail.com> writes:
> On Tue, May 22, 2018 at 11:16:44AM +0200 , Nicolas Goaziou wrote:
>> Thank you. Could you provide a proper commit message, i.e., including
>> the function being modified:
>>
>> * lisp/ob-plantuml.el (... function ...): ... change ...
> I have made the changes to the patch.
> Does this fit your requirements?
>
>> You also need to add TINYCHANGE at the end of the message if you haven't
>> signed FSF papers yet.
> This is my first contribution.
Thank you.
I applied it to "next" branch, which will be merged in master once Org
9.2 is out.
> What papers should I sign for regular contributions?
You need to fill this form :
<https://orgmode.org/request-assign-future.txt> and send it to
<mailto:assign@gnu.org>.
See <https://orgmode.org/worg/org-contribute.html> for details.
Regards,
--
Nicolas Goaziou
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2018-05-30 11:45 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
[not found] <bzg/org-mode/pull/1@github.com>
[not found] ` <bzg/org-mode/pull/1/c389765752@github.com>
2018-05-21 3:03 ` [bzg/org-mode] Added latex export option to ob-plantuml.el (#1) Roger J. H. Welsh
2018-05-22 9:16 ` Nicolas Goaziou
2018-05-23 4:50 ` Roger J. H. Welsh
2018-05-30 11:45 ` Nicolas Goaziou
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).