emacs-orgmode@gnu.org archives
 help / color / mirror / code / Atom feed

From: "Roger J. H. Welsh" <rjhwelsh@gmail.com>
To: emacs-orgmode@gnu.org
Subject: Re: [bzg/org-mode] Added latex export option to ob-plantuml.el (#1)
Date: Mon, 21 May 2018 15:03:10 +1200	[thread overview]
Message-ID: <20180521030310.ua2ru4ubriephhjy@ponos> (raw)
In-Reply-To: <bzg/org-mode/pull/1/c389765752@github.com>


[-- Attachment #1.1: Type: text/plain, Size: 663 bytes --]

Hi,

I have a patch to add the latex export option to ob-plantuml.el .

I originally tried to submit a Pull Request to a repo on github.
https://github.com/rjhwelsh/org-mode/commit/dd69e979b4a8fdd0bb70306e0afb339720659dc5.patch

> Hi, thanks for your contribution but this github repo don't take patches, I should have closed the ability to send PR. Can you resend your patch to emacs-orgmode@gnu.org ? Thanks a lot !
Bastien informed me that I should send it on this way.
Patch is also attached.

Is there any other preferred method to contribute other than patch over email?

--
Kind regards,
Roger Welsh
fpr: 2FCB 9E31 EA77 CDEC A3AE  5DD7 D54C C777 553A 180D

[-- Attachment #1.2: dd69e979b4a8fdd0bb70306e0afb339720659dc5.patch --]
[-- Type: text/x-diff, Size: 919 bytes --]

From dd69e979b4a8fdd0bb70306e0afb339720659dc5 Mon Sep 17 00:00:00 2001
From: rjhwelsh <30714737+rjhwelsh@users.noreply.github.com>
Date: Thu, 17 May 2018 15:36:41 +1200
Subject: [PATCH] Update ob-plantuml.el

---
 lisp/ob-plantuml.el | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/lisp/ob-plantuml.el b/lisp/ob-plantuml.el
index 9a9313e7b..3326a6419 100644
--- a/lisp/ob-plantuml.el
+++ b/lisp/ob-plantuml.el
@@ -92,7 +92,9 @@ This function is called by `org-babel-execute-src-block'."
 			(if (string= (file-name-extension out-file) "eps")
 			    " -teps" "")
 			(if (string= (file-name-extension out-file) "pdf")
-			    " -tpdf" "")
+			    " -tpdf" "")			
+			(if (string= (file-name-extension out-file) "tex")
+			    " -tlatex" "")
 			(if (string= (file-name-extension out-file) "vdx")
 			    " -tvdx" "")
 			(if (string= (file-name-extension out-file) "xmi")

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

next      parent reply	other threads:[~2018-05-21  3:03 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <bzg/org-mode/pull/1@github.com>
     [not found] ` <bzg/org-mode/pull/1/c389765752@github.com>
2018-05-21  3:03   ` Roger J. H. Welsh [this message]
2018-05-22  9:16     ` [bzg/org-mode] Added latex export option to ob-plantuml.el (#1) Nicolas Goaziou
2018-05-23  4:50       ` Roger J. H. Welsh
2018-05-30 11:45         ` Nicolas Goaziou

find likely ancestor, descendant, or conflicting patches for this message:
dfblob:9a9313e7 dfblob:3326a641
	(help)

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.orgmode.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180521030310.ua2ru4ubriephhjy@ponos \
    --to=rjhwelsh@gmail.com \
    --cc=emacs-orgmode@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).