emacs-orgmode@gnu.org archives
 help / color / mirror / code / Atom feed
* [PATCH] Do not ignore org-odt-styles-file
@ 2020-03-04 23:50 Eric Timmons
  2020-03-06  4:28 ` Kyle Meyer
  0 siblings, 1 reply; 3+ messages in thread
From: Eric Timmons @ 2020-03-04 23:50 UTC (permalink / raw)
  To: emacs-orgmode

:odt-styles-file was duplicated in ox-odt's org-export-define-backend
form. This lead to the org-odt-styles-file custom being completely ignored.
---
 lisp/ox-odt.el | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/lisp/ox-odt.el b/lisp/ox-odt.el
index 2723c60c9..d353a3a2e 100644
--- a/lisp/ox-odt.el
+++ b/lisp/ox-odt.el
@@ -96,7 +96,7 @@
 	      (if a (org-odt-export-to-odt t s v)
 		(org-open-file (org-odt-export-to-odt nil s v) 'system))))))
   :options-alist
-  '((:odt-styles-file "ODT_STYLES_FILE" nil nil t)
+  '((:odt-styles-file "ODT_STYLES_FILE" nil org-odt-styles-file t)
     (:description "DESCRIPTION" nil nil newline)
     (:keywords "KEYWORDS" nil nil space)
     (:subtitle "SUBTITLE" nil nil parse)
@@ -110,7 +110,6 @@
     (:odt-inline-formula-rules nil nil org-odt-inline-formula-rules)
     (:odt-inline-image-rules nil nil org-odt-inline-image-rules)
     (:odt-pixels-per-inch nil nil org-odt-pixels-per-inch)
-    (:odt-styles-file nil nil org-odt-styles-file)
     (:odt-table-styles nil nil org-odt-table-styles)
     (:odt-use-date-fields nil nil org-odt-use-date-fields)
     ;; Redefine regular option.
-- 
2.25.1

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] Do not ignore org-odt-styles-file
  2020-03-04 23:50 [PATCH] Do not ignore org-odt-styles-file Eric Timmons
@ 2020-03-06  4:28 ` Kyle Meyer
  2020-05-05  4:19   ` Kyle Meyer
  0 siblings, 1 reply; 3+ messages in thread
From: Kyle Meyer @ 2020-03-06  4:28 UTC (permalink / raw)
  To: Eric Timmons, emacs-orgmode

Thanks for the patch.

Eric Timmons <etimmons@mit.edu> writes:

> :odt-styles-file was duplicated in ox-odt's org-export-define-backend
> form. This lead to the org-odt-styles-file custom being completely ignored.

That change looks good, and, while I'm not an ox-odt user, light testing
on my end confirms the issue and fix.

Could you update your patch to follow the conventions outlined at
<https://orgmode.org/worg/org-contribute.html>?  In particular, add (1)
a change-log entry to the commit message and (2) a TINYCHANGE cookie.
Also, it's typical for commit subjects in this project to start with
"<area or file>: ...".

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] Do not ignore org-odt-styles-file
  2020-03-06  4:28 ` Kyle Meyer
@ 2020-05-05  4:19   ` Kyle Meyer
  0 siblings, 0 replies; 3+ messages in thread
From: Kyle Meyer @ 2020-05-05  4:19 UTC (permalink / raw)
  To: Eric Timmons, emacs-orgmode

Kyle Meyer writes:

> Could you update your patch to follow the conventions outlined at
> <https://orgmode.org/worg/org-contribute.html>?  In particular, add (1)
> a change-log entry to the commit message and (2) a TINYCHANGE cookie.
> Also, it's typical for commit subjects in this project to start with
> "<area or file>: ...".


I've tweaked the commit message and applied it (0f783cbca).


^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2020-05-05  4:19 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-03-04 23:50 [PATCH] Do not ignore org-odt-styles-file Eric Timmons
2020-03-06  4:28 ` Kyle Meyer
2020-05-05  4:19   ` Kyle Meyer

Code repositories for project(s) associated with this inbox:

	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).