From mboxrd@z Thu Jan 1 00:00:00 1970 From: Kyle Meyer Subject: Re: [PATCH] Do not ignore org-odt-styles-file Date: Fri, 06 Mar 2020 04:28:22 +0000 Message-ID: <878ske85uh.fsf@kyleam.com> References: <87mu8vy915.fsf@rocinante.timmons.dev> Mime-Version: 1.0 Content-Type: text/plain Return-path: Received: from eggs.gnu.org ([2001:470:142:3::10]:45514) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jA4b3-0001la-85 for emacs-orgmode@gnu.org; Thu, 05 Mar 2020 23:28:26 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1jA4b2-0004tp-8k for emacs-orgmode@gnu.org; Thu, 05 Mar 2020 23:28:25 -0500 Received: from pb-smtp2.pobox.com ([64.147.108.71]:65330) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1jA4b2-0004sx-4z for emacs-orgmode@gnu.org; Thu, 05 Mar 2020 23:28:24 -0500 In-Reply-To: <87mu8vy915.fsf@rocinante.timmons.dev> List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane-mx.org@gnu.org Sender: "Emacs-orgmode" To: Eric Timmons , emacs-orgmode@gnu.org Thanks for the patch. Eric Timmons writes: > :odt-styles-file was duplicated in ox-odt's org-export-define-backend > form. This lead to the org-odt-styles-file custom being completely ignored. That change looks good, and, while I'm not an ox-odt user, light testing on my end confirms the issue and fix. Could you update your patch to follow the conventions outlined at ? In particular, add (1) a change-log entry to the commit message and (2) a TINYCHANGE cookie. Also, it's typical for commit subjects in this project to start with ": ...".