emacs-orgmode@gnu.org archives
 help / color / mirror / code / Atom feed
From: Kyle Meyer <kyle@kyleam.com>
To: Eric Timmons <etimmons@mit.edu>, emacs-orgmode@gnu.org
Subject: Re: [PATCH] Do not ignore org-odt-styles-file
Date: Fri, 06 Mar 2020 04:28:22 +0000	[thread overview]
Message-ID: <878ske85uh.fsf@kyleam.com> (raw)
In-Reply-To: <87mu8vy915.fsf@rocinante.timmons.dev>

Thanks for the patch.

Eric Timmons <etimmons@mit.edu> writes:

> :odt-styles-file was duplicated in ox-odt's org-export-define-backend
> form. This lead to the org-odt-styles-file custom being completely ignored.

That change looks good, and, while I'm not an ox-odt user, light testing
on my end confirms the issue and fix.

Could you update your patch to follow the conventions outlined at
<https://orgmode.org/worg/org-contribute.html>?  In particular, add (1)
a change-log entry to the commit message and (2) a TINYCHANGE cookie.
Also, it's typical for commit subjects in this project to start with
"<area or file>: ...".

  reply	other threads:[~2020-03-06  4:28 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-03-04 23:50 Eric Timmons
2020-03-06  4:28 ` Kyle Meyer [this message]
2020-05-05  4:19   ` Kyle Meyer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.orgmode.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=878ske85uh.fsf@kyleam.com \
    --to=kyle@kyleam.com \
    --cc=emacs-orgmode@gnu.org \
    --cc=etimmons@mit.edu \
    --subject='Re: [PATCH] Do not ignore org-odt-styles-file' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Code repositories for project(s) associated with this inbox:

	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).