emacs-orgmode@gnu.org archives
 help / color / mirror / code / Atom feed
* bug#19915: 25.0.50; defadvice for `org-store-link' makes code fail because of `org-called-interactively-p'
       [not found] ` <806cb9a1-9089-45a5-bcf1-5e1563fc4793@default>
@ 2018-01-03 17:09   ` Nicolas Goaziou
  0 siblings, 0 replies; only message in thread
From: Nicolas Goaziou @ 2018-01-03 17:09 UTC (permalink / raw)
  To: Drew Adams; +Cc: 19915-done

Hello,

Drew Adams <drew.adams@oracle.com> writes:

> And yes, `advice-add' does not have the same problem.
>
> But it is a shame to limit users to recent Emacs versions
> just because Org uses `called-interactively' instead of
> adding an argument that indicates whether the command is
> called interactively (as Emacs recommends).

I removed call to `called-interactively-p' in `org-store-link' (in
development version).

Thank you.

Regards,

-- 
Nicolas Goaziou                                                0x80A93738

^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2018-01-03 17:10 UTC | newest]

Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
     [not found] <66d452bd-fa38-40e7-b16e-8fe4756d5fab@default>
     [not found] ` <806cb9a1-9089-45a5-bcf1-5e1563fc4793@default>
2018-01-03 17:09   ` bug#19915: 25.0.50; defadvice for `org-store-link' makes code fail because of `org-called-interactively-p' Nicolas Goaziou

Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).