From mboxrd@z Thu Jan  1 00:00:00 1970
From: Nicolas Goaziou <mail@nicolasgoaziou.fr>
Subject: bug#19915: 25.0.50; defadvice for `org-store-link' makes code fail
 because of `org-called-interactively-p'
Date: Wed, 03 Jan 2018 18:09:55 +0100
Message-ID: <87po6qoom4.fsf@nicolasgoaziou.fr>
References: <66d452bd-fa38-40e7-b16e-8fe4756d5fab@default>
	<806cb9a1-9089-45a5-bcf1-5e1563fc4793@default>
Mime-Version: 1.0
Content-Type: text/plain
Return-path: <emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([2001:4830:134:3::10]:44426)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1eWmYI-00039m-Kt
	for emacs-orgmode@gnu.org; Wed, 03 Jan 2018 12:10:07 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1eWmYF-00056m-DZ
	for emacs-orgmode@gnu.org; Wed, 03 Jan 2018 12:10:06 -0500
Received: from debbugs.gnu.org ([208.118.235.43]:54116)
	by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16)
	(Exim 4.71) (envelope-from <Debian-debbugs@debbugs.gnu.org>)
	id 1eWmYF-00056e-9t
	for emacs-orgmode@gnu.org; Wed, 03 Jan 2018 12:10:03 -0500
Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1eWmYE-0005sZ-UE
	for emacs-orgmode@gnu.org; Wed, 03 Jan 2018 12:10:02 -0500
Sender: "Debbugs-submit" <debbugs-submit-bounces@debbugs.gnu.org>
Resent-To: emacs-orgmode@gnu.org
Resent-Message-ID: <handler.19915.D19915.151499940022579.done@debbugs.gnu.org>
In-Reply-To: <806cb9a1-9089-45a5-bcf1-5e1563fc4793@default> (Drew Adams's
	message of "Sat, 21 Feb 2015 12:30:23 -0800 (PST)")
List-Id: "General discussions about Org-mode." <emacs-orgmode.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/emacs-orgmode>,
	<mailto:emacs-orgmode-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/emacs-orgmode/>
List-Post: <mailto:emacs-orgmode@gnu.org>
List-Help: <mailto:emacs-orgmode-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/emacs-orgmode>,
	<mailto:emacs-orgmode-request@gnu.org?subject=subscribe>
Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org
Sender: "Emacs-orgmode"
	<emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org>
To: Drew Adams <drew.adams@oracle.com>
Cc: 19915-done@debbugs.gnu.org

Hello,

Drew Adams <drew.adams@oracle.com> writes:

> And yes, `advice-add' does not have the same problem.
>
> But it is a shame to limit users to recent Emacs versions
> just because Org uses `called-interactively' instead of
> adding an argument that indicates whether the command is
> called interactively (as Emacs recommends).

I removed call to `called-interactively-p' in `org-store-link' (in
development version).

Thank you.

Regards,

-- 
Nicolas Goaziou                                                0x80A93738