From: Nicolas Goaziou <mail@nicolasgoaziou.fr>
To: Drew Adams <drew.adams@oracle.com>
Cc: 19915-done@debbugs.gnu.org
Subject: bug#19915: 25.0.50; defadvice for `org-store-link' makes code fail because of `org-called-interactively-p'
Date: Wed, 03 Jan 2018 18:09:55 +0100 [thread overview]
Message-ID: <87po6qoom4.fsf@nicolasgoaziou.fr> (raw)
In-Reply-To: <806cb9a1-9089-45a5-bcf1-5e1563fc4793@default> (Drew Adams's message of "Sat, 21 Feb 2015 12:30:23 -0800 (PST)")
Hello,
Drew Adams <drew.adams@oracle.com> writes:
> And yes, `advice-add' does not have the same problem.
>
> But it is a shame to limit users to recent Emacs versions
> just because Org uses `called-interactively' instead of
> adding an argument that indicates whether the command is
> called interactively (as Emacs recommends).
I removed call to `called-interactively-p' in `org-store-link' (in
development version).
Thank you.
Regards,
--
Nicolas Goaziou 0x80A93738
parent reply other threads:[~2018-01-03 17:10 UTC|newest]
Thread overview: expand[flat|nested] mbox.gz Atom feed
[parent not found: <806cb9a1-9089-45a5-bcf1-5e1563fc4793@default>]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.orgmode.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87po6qoom4.fsf@nicolasgoaziou.fr \
--to=mail@nicolasgoaziou.fr \
--cc=19915-done@debbugs.gnu.org \
--cc=drew.adams@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).