From: Nicolas Goaziou <mail@nicolasgoaziou.fr>
To: Florian Lindner <mailinglists@xgm.de>
Cc: emacs-orgmode@gnu.org
Subject: Re: Moving and resetting attachments
Date: Sat, 24 Jun 2017 10:53:33 +0200 [thread overview]
Message-ID: <87mv8x4vhu.fsf@nicolasgoaziou.fr> (raw)
In-Reply-To: <5b786b61-8cf2-6635-5000-fa25512242be@xgm.de> (Florian Lindner's message of "Tue, 20 Jun 2017 20:12:32 +0200")
Hello,
Florian Lindner <mailinglists@xgm.de> writes:
> Ok, so it's basically a conversion to bool.
Correct.
> That I'm not so sure of. I try to get myself aquainted to ert, but my elisp knowledge, you surely know, is very limited.
I think you're doing well so far.
> Do I understand correctly, that there is no test for any org-attach stuff so far? I've found lisp/test-org-attach-annex.el, but that's for git-annex
> stuff.
That's correct. Anyway, tests can be postponed to a later patch. It can
be cumbersome to play with temporary files without clobbering the
repository.
However, I think tests are important in this case, considering we're
moving user's data around.
Regards,
--
Nicolas Goaziou
next prev parent reply other threads:[~2017-06-24 8:53 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-05-31 12:29 Moving and resetting attachments Florian Lindner
2017-06-01 4:39 ` Eric Abrahamsen
2017-06-01 11:20 ` Florian Lindner
2017-06-02 9:19 ` Eric Abrahamsen
2017-06-02 9:51 ` Nicolas Goaziou
2017-06-02 12:34 ` Eric Abrahamsen
2017-06-02 14:34 ` Nicolas Goaziou
2017-06-02 16:51 ` Eric Abrahamsen
2017-06-04 7:59 ` Nicolas Goaziou
2017-06-04 23:25 ` Eric Abrahamsen
2017-06-06 13:56 ` Florian Lindner
2017-06-07 7:52 ` Florian Lindner
2017-06-10 7:36 ` Nicolas Goaziou
2017-06-13 8:49 ` Florian Lindner
2017-06-13 21:41 ` Nicolas Goaziou
2017-06-20 18:12 ` Florian Lindner
2017-06-24 8:53 ` Nicolas Goaziou [this message]
2017-06-28 14:57 ` Florian Lindner
2017-06-13 8:53 ` Florian Lindner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.orgmode.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87mv8x4vhu.fsf@nicolasgoaziou.fr \
--to=mail@nicolasgoaziou.fr \
--cc=emacs-orgmode@gnu.org \
--cc=mailinglists@xgm.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).