From: Nicolas Goaziou <mail@nicolasgoaziou.fr>
To: Eric Abrahamsen <eric@ericabrahamsen.net>
Cc: emacs-orgmode@gnu.org
Subject: Re: Moving and resetting attachments
Date: Fri, 02 Jun 2017 11:51:26 +0200 [thread overview]
Message-ID: <87d1am4t0h.fsf@nicolasgoaziou.fr> (raw)
In-Reply-To: <8737bi21dc.fsf@ericabrahamsen.net> (Eric Abrahamsen's message of "Fri, 02 Jun 2017 17:19:11 +0800")
Hello,
Eric Abrahamsen <eric@ericabrahamsen.net> writes:
> Looks like a good start! My first comment is, this should definitely be
> written as a patch to `org-attach-set-directory'. It's useful
> functionality, and fits well into the whole system -- so long as you
> give users a chance to say no, I don't see why it shouldn't be part of
> the library.
FWIW, I agree.
> Various comments:
[...]
> 3. This is a good use of `copy-directory' with the COPY-CONTENTS flag,
> but I'd still recommend using `directory-files' and then looping over
> all the files with a `map-y-or-n-p'. That will give users a chance to
> selectively choose files to move. This is a matter of taste. If you
> stick with `copy-directory', at least ask the user first.
> 4. I think you're right not to delete the directory afterwards. Best not
> to assume too much.
What about using `rename-file' so as to move the whole directory to the
new location?
Maybe a defcustom could let the user choose between moving and copying
the attachment directory.
> 7. Personally I'd rework things so you only call `org-attach-dir' once.
> How to handle this depends a bit on when when-let was introduced into
> Emacs, and whether Org is okay to support it. Probably safest to use
> when-let*. so:
>
> (when-let* ((attach-dir (org-attach-dir))
> (target (read-directory-name "Move attachments to: ")))
We cannot use `when-let*'. Besides,
(let ((attch-dir (org-attach-dir)))
(when attach-dir
(let ((target (read-directory-name "Move attachments to: ")))
...)))
is fine, too, or even
(let ((attch-dir (or (org-attach-dir) (error "No attachment directory")))
(target (read-directory-name "Move attachments to: ")))
...)
Regards,
--
Nicolas Goaziou
next prev parent reply other threads:[~2017-06-02 9:51 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-05-31 12:29 Moving and resetting attachments Florian Lindner
2017-06-01 4:39 ` Eric Abrahamsen
2017-06-01 11:20 ` Florian Lindner
2017-06-02 9:19 ` Eric Abrahamsen
2017-06-02 9:51 ` Nicolas Goaziou [this message]
2017-06-02 12:34 ` Eric Abrahamsen
2017-06-02 14:34 ` Nicolas Goaziou
2017-06-02 16:51 ` Eric Abrahamsen
2017-06-04 7:59 ` Nicolas Goaziou
2017-06-04 23:25 ` Eric Abrahamsen
2017-06-06 13:56 ` Florian Lindner
2017-06-07 7:52 ` Florian Lindner
2017-06-10 7:36 ` Nicolas Goaziou
2017-06-13 8:49 ` Florian Lindner
2017-06-13 21:41 ` Nicolas Goaziou
2017-06-20 18:12 ` Florian Lindner
2017-06-24 8:53 ` Nicolas Goaziou
2017-06-28 14:57 ` Florian Lindner
2017-06-13 8:53 ` Florian Lindner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.orgmode.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87d1am4t0h.fsf@nicolasgoaziou.fr \
--to=mail@nicolasgoaziou.fr \
--cc=emacs-orgmode@gnu.org \
--cc=eric@ericabrahamsen.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).