emacs-orgmode@gnu.org archives
 help / color / mirror / code / Atom feed

From: Florian Lindner <mailinglists@xgm.de>
To: Nicolas Goaziou <mail@nicolasgoaziou.fr>
Cc: emacs-orgmode@gnu.org
Subject: Re: Moving and resetting attachments
Date: Wed, 28 Jun 2017 16:57:39 +0200	[thread overview]
Message-ID: <4bc8ab3b-173f-b093-fd0d-3b2769683cb6@xgm.de> (raw)
In-Reply-To: <87mv8x4vhu.fsf@nicolasgoaziou.fr>

Am 24.06.2017 um 10:53 schrieb Nicolas Goaziou:> Hello,
>
> Florian Lindner <mailinglists@xgm.de> writes:
>
>> Ok, so it's basically a conversion to bool.
>
> Correct.
>
>> That I'm not so sure of. I try to get myself aquainted to ert, but my elisp knowledge, you surely know, is very limited.
>
> I think you're doing well so far.
>
>> Do I understand correctly, that there is no test for any org-attach stuff so far? I've found
lisp/test-org-attach-annex.el, but that's for git-annex
>> stuff.
>
> That's correct. Anyway, tests can be postponed to a later patch. It can
> be cumbersome to play with temporary files without clobbering the
> repository.
>
> However, I think tests are important in this case, considering we're
> moving user's data around.

Hey,

I have attached a patch, based on the current git master. I'm not sure how the contribution process works. Do I need to
sign stuff such as copyright assignement? Do you use a Git webinterface, GitHub or Lab?

Writing a test for it is on my todo list.

Best,
Florian

next prev parent reply	other threads:[~2017-06-28 14:57 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-05-31 12:29 Moving and resetting attachments Florian Lindner
2017-06-01  4:39 ` Eric Abrahamsen
2017-06-01 11:20   ` Florian Lindner
2017-06-02  9:19     ` Eric Abrahamsen
2017-06-02  9:51       ` Nicolas Goaziou
2017-06-02 12:34         ` Eric Abrahamsen
2017-06-02 14:34           ` Nicolas Goaziou
2017-06-02 16:51             ` Eric Abrahamsen
2017-06-04  7:59               ` Nicolas Goaziou
2017-06-04 23:25                 ` Eric Abrahamsen
2017-06-06 13:56                   ` Florian Lindner
2017-06-07  7:52       ` Florian Lindner
2017-06-10  7:36         ` Nicolas Goaziou
2017-06-13  8:49           ` Florian Lindner
2017-06-13 21:41             ` Nicolas Goaziou
2017-06-20 18:12               ` Florian Lindner
2017-06-24  8:53                 ` Nicolas Goaziou
2017-06-28 14:57                   ` Florian Lindner [this message]
2017-06-13  8:53           ` Florian Lindner

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.orgmode.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4bc8ab3b-173f-b093-fd0d-3b2769683cb6@xgm.de \
    --to=mailinglists@xgm.de \
    --cc=emacs-orgmode@gnu.org \
    --cc=mail@nicolasgoaziou.fr \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).