From mboxrd@z Thu Jan  1 00:00:00 1970
From: Nicolas Goaziou <mail@nicolasgoaziou.fr>
Subject: Re: Moving and resetting attachments
Date: Sat, 24 Jun 2017 10:53:33 +0200
Message-ID: <87mv8x4vhu.fsf@nicolasgoaziou.fr>
References: <ogmcua$c4l$1@blaine.gmane.org>
	<874lw05njr.fsf@ericabrahamsen.net> <ogot9c$aqj$1@blaine.gmane.org>
	<8737bi21dc.fsf@ericabrahamsen.net> <oh8bbr$463$1@blaine.gmane.org>
	<87mv9gz43o.fsf@nicolasgoaziou.fr>
	<f1c95d02-d856-69ec-9bf3-beb22d803839@xgm.de>
	<87tw3jr2f8.fsf@nicolasgoaziou.fr>
	<5b786b61-8cf2-6635-5000-fa25512242be@xgm.de>
Mime-Version: 1.0
Content-Type: text/plain
Return-path: <emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([2001:4830:134:3::10]:40762)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <mail@nicolasgoaziou.fr>) id 1dOgp0-00030K-6f
	for emacs-orgmode@gnu.org; Sat, 24 Jun 2017 04:53:39 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <mail@nicolasgoaziou.fr>) id 1dOgoz-0004rT-Gj
	for emacs-orgmode@gnu.org; Sat, 24 Jun 2017 04:53:38 -0400
Received: from relay4-d.mail.gandi.net ([2001:4b98:c:538::196]:33281)
	by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32)
	(Exim 4.71) (envelope-from <mail@nicolasgoaziou.fr>)
	id 1dOgoz-0004r8-A5
	for emacs-orgmode@gnu.org; Sat, 24 Jun 2017 04:53:37 -0400
In-Reply-To: <5b786b61-8cf2-6635-5000-fa25512242be@xgm.de> (Florian Lindner's
	message of "Tue, 20 Jun 2017 20:12:32 +0200")
List-Id: "General discussions about Org-mode." <emacs-orgmode.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/emacs-orgmode>,
	<mailto:emacs-orgmode-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/emacs-orgmode/>
List-Post: <mailto:emacs-orgmode@gnu.org>
List-Help: <mailto:emacs-orgmode-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/emacs-orgmode>,
	<mailto:emacs-orgmode-request@gnu.org?subject=subscribe>
Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org
Sender: "Emacs-orgmode"
	<emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org>
To: Florian Lindner <mailinglists@xgm.de>
Cc: emacs-orgmode@gnu.org

Hello,

Florian Lindner <mailinglists@xgm.de> writes:

> Ok, so it's basically a conversion to bool.

Correct.

> That I'm not so sure of. I try to get myself aquainted to ert, but my elisp knowledge, you surely know, is very limited.

I think you're doing well so far.

> Do I understand correctly, that there is no test for any org-attach stuff so far? I've found lisp/test-org-attach-annex.el, but that's for git-annex
> stuff.

That's correct. Anyway, tests can be postponed to a later patch. It can
be cumbersome to play with temporary files without clobbering the
repository.

However, I think tests are important in this case, considering we're
moving user's data around.


Regards,

-- 
Nicolas Goaziou