From: Timothy <firstname.lastname@example.org> To: Matt Huszagh <email@example.com> Cc: firstname.lastname@example.org Subject: Re: [PATCH] Fix window width when line numbers present Date: Mon, 22 Nov 2021 03:14:50 +0800 [thread overview] Message-ID: <email@example.com> (raw) In-Reply-To: <firstname.lastname@example.org> [-- Attachment #1: Type: text/plain, Size: 916 bytes --] Hi Matt, > This is a very small patch that I believe fixes a previous, incorrect > fix for computing the window text area when line numbers are > present. The previous fix seemed to assume that > display-line-numbers-width being nil meant that this means line numbers > are not present. However, it can also mean (as described in the > variable documentation) that the line number width is computed > dynamically. Thanks for this patch. I wasn’t aware of `line-number-display-width' when I wrote that, but it looks like a better fit than my `(or ... 0)' statement. As such, I’ve just applied your patch as cd3e138, tweaking the commit message to no longer go over the maximum length :) Looking at the docstring for `line-number-display-width', it seems that the pixelwise mode may be more useful for our purposes, but that improvement can be in a subsequent patch. All the best, Timothy
next prev parent reply other threads:[~2021-11-21 19:21 UTC|newest] Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top 2021-11-21 18:41 Matt Huszagh 2021-11-21 19:14 ` Timothy [this message] 2021-11-21 21:08 ` Nicolas Goaziou 2021-11-21 21:14 ` Matt Huszagh 2021-11-21 21:16 ` Bastien 2021-11-21 21:22 ` Matt Huszagh 2021-11-22 5:14 ` Bastien 2021-11-22 5:31 ` Timothy 2021-11-22 5:44 ` Bastien 2021-11-22 5:51 ` Supported Emacs version (was: [PATCH] Fix window width when line numbers present) Timothy 2021-11-22 6:05 ` Supported Emacs version Bastien 2021-11-22 6:12 ` Timothy 2021-11-22 6:39 ` Bastien 2021-11-22 8:04 ` Timothy 2021-11-22 10:26 ` Bastien 2021-11-22 11:55 ` [PATCH] Fix window width when line numbers present Ihor Radchenko 2021-11-22 12:40 ` Tim Cross 2021-11-23 5:59 ` Bastien 2021-11-23 7:05 ` Tim Cross 2021-11-22 3:16 ` Timothy 2021-11-21 19:19 ` Timothy
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style List information: https://www.orgmode.org/ * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --email@example.com \ --firstname.lastname@example.org \ --email@example.com \ --firstname.lastname@example.org \ --subject='Re: [PATCH] Fix window width when line numbers present' \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
Code repositories for project(s) associated with this inbox: https://git.savannah.gnu.org/cgit/emacs/org-mode.git This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).