From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp2 ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms0.migadu.com with LMTPS id wFHYBiKcmmGwBAEAgWs5BA (envelope-from ) for ; Sun, 21 Nov 2021 20:21:06 +0100 Received: from aspmx1.migadu.com ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp2 with LMTPS id KFeSAiKcmmGWVQAAB5/wlQ (envelope-from ) for ; Sun, 21 Nov 2021 19:21:06 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id C7A6C3179E for ; Sun, 21 Nov 2021 20:21:05 +0100 (CET) Received: from localhost ([::1]:36842 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mosOe-0004p0-E4 for larch@yhetil.org; Sun, 21 Nov 2021 14:21:04 -0500 Received: from eggs.gnu.org ([209.51.188.92]:53374) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mosNA-0004oq-2K for emacs-orgmode@gnu.org; Sun, 21 Nov 2021 14:19:32 -0500 Received: from [2607:f8b0:4864:20::62d] (port=45797 helo=mail-pl1-x62d.google.com) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1mosN8-0002ri-9n for emacs-orgmode@gnu.org; Sun, 21 Nov 2021 14:19:31 -0500 Received: by mail-pl1-x62d.google.com with SMTP id b11so12217064pld.12 for ; Sun, 21 Nov 2021 11:19:29 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:date:references:user-agent:in-reply-to :message-id:mime-version; bh=SuCHckfWCGTccRh4Aw2z8vXsnkhxqUtQtanx4OSuXCM=; b=bXQVGn8G0gmH7eYrt9G6OuL0gKpdFIyBk1oXcRqiIxJlLvH8HntLB9vT6piMUmLz8P mXekjHQYh9xAIjZkMdlgENeA5/2gHeds05HMaJ9JC4CQtsaeDWSz0L8zPvOOQHi0EL7J 26LWrN3Mwot915mxP2x7w5GtkxKjvM9YFPcXaANoIO6paS/1ZIK7A8HxKotM8Gbvq+xK 32Dsgi1aQn2yytfmP7hmlWwYGk/2/88gc53Ve/5HSEaydjO/Icj5oXR8IpzHKdmbhcbc 32bhLIfMeZ8vamb9GUMukDS/7kLsUw+5S2DObCpKhXyc/R5gwkTiV63xrTG4/jIp1XcQ o7HA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:references:user-agent :in-reply-to:message-id:mime-version; bh=SuCHckfWCGTccRh4Aw2z8vXsnkhxqUtQtanx4OSuXCM=; b=aD+78owNu4rCnpj0vv9fV/0MxtAykA7p7s1JheCQxIj2I55W/KVM27jzTkU1emk/x+ /GrW5b1OZRmML7XSn6HnTpBiMYNNBVBjK1Ay+BTdHMaUEY45aFpb4XwYOSGYOiGOP9b7 1i7LNtt9vYBAxZ/ga5z+stOWKX3nZqSLmd/AuCXCJQonK6kQViUrPtSsUttxr0H6K+yb 0VNRuqO6TkLsOzy8lN6DcVU6dUGDdeWoBaIvq6g4Xe3to7koJbezgEQtnAa4mVyv48jB vIW3bkbKxfRl7Dn+cJRfZn7kxVbxbHiAbHPuOiZDJRI/enZmOpWiJOaAnC55uqmZTFsF E62g== X-Gm-Message-State: AOAM530s4vgSLO+oRQwGEKyq/ScCe+/jwKEaRRy4LBtYxpUh5YJgoYHC W8rpd9lciOl6hdYA5Zr90ZgsRFJ34gU= X-Google-Smtp-Source: ABdhPJxfWZSlWWJQzhoj2e+T/8NALc2vjLAoDtOmmeWybF5V7yNQRPIvlTol2T8cK7sS90TZjVGsWQ== X-Received: by 2002:a17:90a:ec05:: with SMTP id l5mr24079365pjy.68.1637522369026; Sun, 21 Nov 2021 11:19:29 -0800 (PST) Received: from localhost (61-245-128-160.3df580.per.nbn.aussiebb.net. [61.245.128.160]) by smtp.gmail.com with ESMTPSA id lx15sm5246762pjb.44.2021.11.21.11.19.27 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 21 Nov 2021 11:19:28 -0800 (PST) From: Timothy To: Matt Huszagh Subject: Re: [PATCH] Fix window width when line numbers present Date: Mon, 22 Nov 2021 03:14:50 +0800 References: <87fsrpuzal.fsf@gmail.com> User-agent: mu4e 1.6.9; emacs 28.0.50 In-reply-to: <87fsrpuzal.fsf@gmail.com> Message-ID: <87lf1h71vn.fsf@gmail.com> MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" X-Host-Lookup-Failed: Reverse DNS lookup failed for 2607:f8b0:4864:20::62d (failed) Received-SPF: pass client-ip=2607:f8b0:4864:20::62d; envelope-from=tecosaur@gmail.com; helo=mail-pl1-x62d.google.com X-Spam_score_int: -12 X-Spam_score: -1.3 X-Spam_bar: - X-Spam_report: (-1.3 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, PDS_HP_HELO_NORDNS=0.001, RCVD_IN_DNSWL_NONE=-0.0001, RDNS_NONE=0.793, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-orgmode@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: emacs-orgmode@gnu.org Errors-To: emacs-orgmode-bounces+larch=yhetil.org@gnu.org Sender: "Emacs-orgmode" X-Migadu-Flow: FLOW_IN X-Migadu-Country: US ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1637522465; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=SuCHckfWCGTccRh4Aw2z8vXsnkhxqUtQtanx4OSuXCM=; b=NprHfnLqx0Nh3Xf+opqGlkmTK/fTlMSK0J3wfpD8twRDDTID5OU7demWhUQ9oxOVA6tb9B rm17UW5GnCO4Ne3bGO5suZGCfVO+QOlcJmYBHyLg3+jtLgkmC5xCvdATylB/hL1TQ9tFb8 PFNUXPVVXRjVKWohlZSTTHGVAwJ6NBasFW7WRYSM3NfF9etV/M7yGefPXktG9U5wufsdEY P0jUxLKvVjb9sh2A8Q48a0w0F7uHyt3SnABxENSAZxG9T3ee0CjHHuuuNL9FdFuG/Ww3HS ZP+JP+BsZMvbOVOQpuxU/aeRxJt8YoJs38L7lQB8Oy+OQ8UtWN8KXe/1tFjm8A== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1637522465; a=rsa-sha256; cv=none; b=GkLgTlX9ABgIyk3H+wrFZ5RBz1VPV6u6InX83mLTGQoOhPcwqHHPEauUoFM7S41w8QdWDV V51vtez+j87D97fckE04hyEEzeNl59JMbTBEgePkBGc7O3TLU4ZPQVSl4bFqUs9/B99vgZ D8bMjHL+BmB9mMIwvxf/ISeFNZIEmj5AYhkkyqqUhRXwQwcSSQlktqLukzpDJhJOX5gAMN BPamN6lm5DaxLwO+0KMpXuqBWPPShUjKVSpsdZ99iWHgjLJ1Hu0uThLygTXJWa7TWDAY98 Y/YNjpzNjQUvFIyGWkuSJAEbGjR7IyLEiTcDSWSGnKXtijf9t24oOOOEZ4L6+A== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=bXQVGn8G; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (aspmx1.migadu.com: domain of "emacs-orgmode-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="emacs-orgmode-bounces+larch=yhetil.org@gnu.org" X-Migadu-Spam-Score: -3.08 Authentication-Results: aspmx1.migadu.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=bXQVGn8G; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (aspmx1.migadu.com: domain of "emacs-orgmode-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="emacs-orgmode-bounces+larch=yhetil.org@gnu.org" X-Migadu-Queue-Id: C7A6C3179E X-Spam-Score: -3.08 X-Migadu-Scanner: scn0.migadu.com X-TUID: Q4zt28y6wA23 --=-=-= Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Hi Matt, > This is a very small patch that I believe fixes a previous, incorrect > fix for computing the window text area when line numbers are > present. The previous fix seemed to assume that > display-line-numbers-width being nil meant that this means line numbers > are not present. However, it can also mean (as described in the > variable documentation) that the line number width is computed > dynamically. Thanks for this patch. I wasn=E2=80=99t aware of `line-number-display-width= ' when I wrote that, but it looks like a better fit than my `(or ... 0)' statement. As suc= h, I=E2=80=99ve just applied your patch as cd3e138, tweaking the commit message to no longe= r go over the maximum length :) Looking at the docstring for `line-number-display-width', it seems that the pixelwise mode may be more useful for our purposes, but that improvement ca= n be in a subsequent patch. All the best, Timothy --=-=-=--