emacs-orgmode@gnu.org archives
 help / color / mirror / code / Atom feed

From: Nicolas Goaziou <mail@nicolasgoaziou.fr>
To: Julien Cubizolles <j.cubizolles@free.fr>
Cc: emacs-orgmode@gnu.org
Subject: Re: removal of org-maybe-keyword-time-regexp
Date: Wed, 11 Mar 2020 22:09:46 +0100	[thread overview]
Message-ID: <87k13qoaxx.fsf@nicolasgoaziou.fr> (raw)
In-Reply-To: <871rpyerjw.fsf@free.fr> (Julien Cubizolles's message of "Wed, 11 Mar 2020 18:21:07 +0100")

Hello,

Julien Cubizolles <j.cubizolles@free.fr> writes:

> I'm using org-caldav (https://github.com/dengste/org-caldav/) to
> synchronize the calendar on my Android phone and Org. Recently this
> synchronization stopped working because org-caldav relies on
> org-maybe-keyword-time-regexp that has been dropped from Org. As a
> workaround, could this variable be reintroduced in org so as not to
> break this very useful package ?

Could you contact upstream instead?

AFAICT, they use this variable only twice. The first occurrence doesn't
seem useful (they check for a planning info keyword in a headline, which
cannot happen), it is probably enough to look for `org-ts-regexp-both'.

I'm not sure about the second one. I guess it would be better for them
to use something like:

    (and (re-search-forward "org-planning-line-re" nil t)
         (org-at-planning-p)
         (progn
           (org-skip-whitespace)
           (looking-at org-ts-regexp-both)))

The (small) issue here is that we cannot properly deprecate a variable
that is not replaced with something else (i.e., we're not using
`define-obsolete-variable-alias' here).

Regards,

-- 
Nicolas Goaziou

next prev parent reply	other threads:[~2020-03-11 21:09 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-03-11 17:21 removal of org-maybe-keyword-time-regexp Julien Cubizolles
2020-03-11 21:09 ` Nicolas Goaziou [this message]
2020-03-11 21:29   ` Eric Abrahamsen
2020-03-11 22:20     ` Nicolas Goaziou
2020-03-11 22:57       ` Eric Abrahamsen
2020-03-12  8:21         ` Nicolas Goaziou
2020-03-12 19:03           ` Eric Abrahamsen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.orgmode.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87k13qoaxx.fsf@nicolasgoaziou.fr \
    --to=mail@nicolasgoaziou.fr \
    --cc=emacs-orgmode@gnu.org \
    --cc=j.cubizolles@free.fr \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).