From: Eric Abrahamsen <eric@ericabrahamsen.net>
To: emacs-orgmode@gnu.org
Subject: Re: removal of org-maybe-keyword-time-regexp
Date: Wed, 11 Mar 2020 15:57:14 -0700 [thread overview]
Message-ID: <87eety4i0l.fsf@ericabrahamsen.net> (raw)
In-Reply-To: <87fteeo7nf.fsf@nicolasgoaziou.fr> (Nicolas Goaziou's message of "Wed, 11 Mar 2020 23:20:52 +0100")
On 03/11/20 23:20 PM, Nicolas Goaziou wrote:
> Hello,
>
> Eric Abrahamsen <eric@ericabrahamsen.net> writes:
>
>> But if we use `make-obsolete-variable', the CURRENT-NAME arg can be a
>> simply explanatory string.
>
> You're right. However, I'm not sure what the CURRENT-NAME should be,
> besides "don't use this, you probably want something else"
I would have liked to know what the "something else" was! Or even "Org
link regexps have been rewritten", something like that.
> Also, my suggestions still holds: it is useful to warn upstream about
> it.
Absolutely. I don't think Org has a responsibility to maintain backwards
compatibility for these variables, and upstream packages should be
tracking changes. But the more help we can provide, the better.
>> I was also recently bit by the removal of a bunch of regexps (in my
>> case, link regexps), and it would have been useful to have some sort of
>> a pointer, either in the obsolescence message or in the docs, about what
>> we're supposed to do instead.
>
> I'm not sure about what "bunch of regexps" you are talking about.
Looks like commit "Move link-related core functions out of \"org.el\"".
Nearly a year ago -- I wasn't paying attention! But defining link
regexps as aliases of other link regexps meant that the regexps matched,
but the match groups were off: that led to silent failure, and took
quite a while to debug. I guess I would have preferred a loud failure.
Anyway, it's not a big deal, I only bring it up because someone else
did!
Eric
next prev parent reply other threads:[~2020-03-11 22:57 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-11 17:21 removal of org-maybe-keyword-time-regexp Julien Cubizolles
2020-03-11 21:09 ` Nicolas Goaziou
2020-03-11 21:29 ` Eric Abrahamsen
2020-03-11 22:20 ` Nicolas Goaziou
2020-03-11 22:57 ` Eric Abrahamsen [this message]
2020-03-12 8:21 ` Nicolas Goaziou
2020-03-12 19:03 ` Eric Abrahamsen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.orgmode.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87eety4i0l.fsf@ericabrahamsen.net \
--to=eric@ericabrahamsen.net \
--cc=emacs-orgmode@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).