From: Nicolas Goaziou <mail@nicolasgoaziou.fr>
To: Eric Abrahamsen <eric@ericabrahamsen.net>
Cc: emacs-orgmode@gnu.org
Subject: Re: removal of org-maybe-keyword-time-regexp
Date: Thu, 12 Mar 2020 09:21:51 +0100 [thread overview]
Message-ID: <878sk6nfts.fsf@nicolasgoaziou.fr> (raw)
In-Reply-To: <87eety4i0l.fsf@ericabrahamsen.net> (Eric Abrahamsen's message of "Wed, 11 Mar 2020 15:57:14 -0700")
Hello,
Eric Abrahamsen <eric@ericabrahamsen.net> writes:
> I would have liked to know what the "something else" was! Or even "Org
> link regexps have been rewritten", something like that.
I added an obsolescence warning about it in "org-compat.el". It will
still break upstream, since there is no replacement for the variable.
> Looks like commit "Move link-related core functions out of \"org.el\"".
> Nearly a year ago -- I wasn't paying attention! But defining link
> regexps as aliases of other link regexps meant that the regexps matched,
> but the match groups were off: that led to silent failure, and took
> quite a while to debug. I guess I would have preferred a loud failure.
Most variables were only renamed. It's possible that a few of them
changed match groups, but that was probably not intentional (I cannot
remember). The only intended change was `org-link-bracket-re', which is
documented in ORG-NEWS.
Regards,
--
Nicolas Goaziou
next prev parent reply other threads:[~2020-03-12 8:21 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-11 17:21 removal of org-maybe-keyword-time-regexp Julien Cubizolles
2020-03-11 21:09 ` Nicolas Goaziou
2020-03-11 21:29 ` Eric Abrahamsen
2020-03-11 22:20 ` Nicolas Goaziou
2020-03-11 22:57 ` Eric Abrahamsen
2020-03-12 8:21 ` Nicolas Goaziou [this message]
2020-03-12 19:03 ` Eric Abrahamsen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.orgmode.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=878sk6nfts.fsf@nicolasgoaziou.fr \
--to=mail@nicolasgoaziou.fr \
--cc=emacs-orgmode@gnu.org \
--cc=eric@ericabrahamsen.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).