From mboxrd@z Thu Jan 1 00:00:00 1970 From: Nicolas Goaziou Subject: Re: removal of org-maybe-keyword-time-regexp Date: Thu, 12 Mar 2020 09:21:51 +0100 Message-ID: <878sk6nfts.fsf@nicolasgoaziou.fr> References: <871rpyerjw.fsf@free.fr> <87k13qoaxx.fsf@nicolasgoaziou.fr> <87pndi4m2h.fsf@ericabrahamsen.net> <87fteeo7nf.fsf@nicolasgoaziou.fr> <87eety4i0l.fsf@ericabrahamsen.net> Mime-Version: 1.0 Content-Type: text/plain Return-path: Received: from eggs.gnu.org ([2001:470:142:3::10]:44284) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jCJ6M-0007LF-Qf for emacs-orgmode@gnu.org; Thu, 12 Mar 2020 04:21:59 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1jCJ6L-0007rx-8v for emacs-orgmode@gnu.org; Thu, 12 Mar 2020 04:21:58 -0400 Received: from relay9-d.mail.gandi.net ([217.70.183.199]:48381) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1jCJ6L-0007rM-3M for emacs-orgmode@gnu.org; Thu, 12 Mar 2020 04:21:57 -0400 In-Reply-To: <87eety4i0l.fsf@ericabrahamsen.net> (Eric Abrahamsen's message of "Wed, 11 Mar 2020 15:57:14 -0700") List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane-mx.org@gnu.org Sender: "Emacs-orgmode" To: Eric Abrahamsen Cc: emacs-orgmode@gnu.org Hello, Eric Abrahamsen writes: > I would have liked to know what the "something else" was! Or even "Org > link regexps have been rewritten", something like that. I added an obsolescence warning about it in "org-compat.el". It will still break upstream, since there is no replacement for the variable. > Looks like commit "Move link-related core functions out of \"org.el\"". > Nearly a year ago -- I wasn't paying attention! But defining link > regexps as aliases of other link regexps meant that the regexps matched, > but the match groups were off: that led to silent failure, and took > quite a while to debug. I guess I would have preferred a loud failure. Most variables were only renamed. It's possible that a few of them changed match groups, but that was probably not intentional (I cannot remember). The only intended change was `org-link-bracket-re', which is documented in ORG-NEWS. Regards, -- Nicolas Goaziou