From mboxrd@z Thu Jan 1 00:00:00 1970 From: Eric Abrahamsen Subject: Re: removal of org-maybe-keyword-time-regexp Date: Wed, 11 Mar 2020 15:57:14 -0700 Message-ID: <87eety4i0l.fsf@ericabrahamsen.net> References: <871rpyerjw.fsf@free.fr> <87k13qoaxx.fsf@nicolasgoaziou.fr> <87pndi4m2h.fsf@ericabrahamsen.net> <87fteeo7nf.fsf@nicolasgoaziou.fr> Mime-Version: 1.0 Content-Type: text/plain Return-path: Received: from eggs.gnu.org ([2001:470:142:3::10]:37238) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jCAI1-00077O-L8 for emacs-orgmode@gnu.org; Wed, 11 Mar 2020 18:57:26 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1jCAI0-0004pR-GJ for emacs-orgmode@gnu.org; Wed, 11 Mar 2020 18:57:25 -0400 Received: from ericabrahamsen.net ([52.70.2.18]:59212 helo=mail.ericabrahamsen.net) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1jCAI0-0004Mp-C1 for emacs-orgmode@gnu.org; Wed, 11 Mar 2020 18:57:24 -0400 Received: from localhost (97-126-77-193.tukw.qwest.net [97.126.77.193]) (Authenticated sender: eric@ericabrahamsen.net) by mail.ericabrahamsen.net (Postfix) with ESMTPSA id 2C78CFA094 for ; Wed, 11 Mar 2020 22:57:16 +0000 (UTC) In-Reply-To: <87fteeo7nf.fsf@nicolasgoaziou.fr> (Nicolas Goaziou's message of "Wed, 11 Mar 2020 23:20:52 +0100") List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane-mx.org@gnu.org Sender: "Emacs-orgmode" To: emacs-orgmode@gnu.org On 03/11/20 23:20 PM, Nicolas Goaziou wrote: > Hello, > > Eric Abrahamsen writes: > >> But if we use `make-obsolete-variable', the CURRENT-NAME arg can be a >> simply explanatory string. > > You're right. However, I'm not sure what the CURRENT-NAME should be, > besides "don't use this, you probably want something else" I would have liked to know what the "something else" was! Or even "Org link regexps have been rewritten", something like that. > Also, my suggestions still holds: it is useful to warn upstream about > it. Absolutely. I don't think Org has a responsibility to maintain backwards compatibility for these variables, and upstream packages should be tracking changes. But the more help we can provide, the better. >> I was also recently bit by the removal of a bunch of regexps (in my >> case, link regexps), and it would have been useful to have some sort of >> a pointer, either in the obsolescence message or in the docs, about what >> we're supposed to do instead. > > I'm not sure about what "bunch of regexps" you are talking about. Looks like commit "Move link-related core functions out of \"org.el\"". Nearly a year ago -- I wasn't paying attention! But defining link regexps as aliases of other link regexps meant that the regexps matched, but the match groups were off: that led to silent failure, and took quite a while to debug. I guess I would have preferred a loud failure. Anyway, it's not a big deal, I only bring it up because someone else did! Eric