From mboxrd@z Thu Jan  1 00:00:00 1970
From: Nicolas Goaziou <mail@nicolasgoaziou.fr>
Subject: Re: removal of org-maybe-keyword-time-regexp
Date: Wed, 11 Mar 2020 22:09:46 +0100
Message-ID: <87k13qoaxx.fsf@nicolasgoaziou.fr>
References: <871rpyerjw.fsf@free.fr>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
Return-path: <emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane-mx.org@gnu.org>
Received: from eggs.gnu.org ([2001:470:142:3::10]:50200)
 by lists.gnu.org with esmtp (Exim 4.90_1)
 (envelope-from <mail@nicolasgoaziou.fr>) id 1jC8bx-00037O-Us
 for emacs-orgmode@gnu.org; Wed, 11 Mar 2020 17:09:54 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
 (envelope-from <mail@nicolasgoaziou.fr>) id 1jC8bv-0008U2-EC
 for emacs-orgmode@gnu.org; Wed, 11 Mar 2020 17:09:53 -0400
Received: from relay11.mail.gandi.net ([217.70.178.231]:50657)
 by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32)
 (Exim 4.71) (envelope-from <mail@nicolasgoaziou.fr>)
 id 1jC8bv-0008N5-7m
 for emacs-orgmode@gnu.org; Wed, 11 Mar 2020 17:09:51 -0400
In-Reply-To: <871rpyerjw.fsf@free.fr> (Julien Cubizolles's message of "Wed, 11
 Mar 2020 18:21:07 +0100")
List-Id: "General discussions about Org-mode." <emacs-orgmode.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/emacs-orgmode>,
 <mailto:emacs-orgmode-request@gnu.org?subject=unsubscribe>
List-Archive: <https://lists.gnu.org/archive/html/emacs-orgmode>
List-Post: <mailto:emacs-orgmode@gnu.org>
List-Help: <mailto:emacs-orgmode-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/emacs-orgmode>,
 <mailto:emacs-orgmode-request@gnu.org?subject=subscribe>
Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane-mx.org@gnu.org
Sender: "Emacs-orgmode"
 <emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane-mx.org@gnu.org>
To: Julien Cubizolles <j.cubizolles@free.fr>
Cc: emacs-orgmode@gnu.org

Hello,

Julien Cubizolles <j.cubizolles@free.fr> writes:

> I'm using org-caldav (https://github.com/dengste/org-caldav/) to
> synchronize the calendar on my Android phone and Org. Recently this
> synchronization stopped working because org-caldav relies on
> org-maybe-keyword-time-regexp that has been dropped from Org. As a
> workaround, could this variable be reintroduced in org so as not to
> break this very useful package=C2=A0?

Could you contact upstream instead?

AFAICT, they use this variable only twice. The first occurrence doesn't
seem useful (they check for a planning info keyword in a headline, which
cannot happen), it is probably enough to look for `org-ts-regexp-both'.

I'm not sure about the second one. I guess it would be better for them
to use something like:

    (and (re-search-forward "org-planning-line-re" nil t)
         (org-at-planning-p)
         (progn
           (org-skip-whitespace)
           (looking-at org-ts-regexp-both)))

The (small) issue here is that we cannot properly deprecate a variable
that is not replaced with something else (i.e., we're not using
`define-obsolete-variable-alias' here).

Regards,

--=20
Nicolas Goaziou