emacs-orgmode@gnu.org archives
 help / color / mirror / code / Atom feed
From: Bastien <bzg@gnu.org>
To: Alex Kosorukoff <alex@3form.com>
Cc: emacs-orgmode@gnu.org
Subject: Re: [PATCH] Fix: Capture abort: (error: The mark is not set now, so there is no region)
Date: Fri, 23 May 2014 19:28:11 +0200	[thread overview]
Message-ID: <87ha4gv1zo.fsf@bzg.ath.cx> (raw)
In-Reply-To: <CAHD9_tQSRupfv1ZaUH_6AZtuOBMo8ca+DxocjLfWTR-T0hmAsw@mail.gmail.com> (Alex Kosorukoff's message of "Fri, 23 May 2014 09:37:48 -0700")

Hi Alex,

Alex Kosorukoff <alex@3form.com> writes:

> Excluding mark-active will work, the result will be the same as after
> my patch, except performance will not be the same. Excluding variable
> requires filtering the list of variables which takes O(n) whereas my
> patch takes O(1). Mark-active is nil before
> org-capture-steal-local-variables because this is a new buffer. It
> seems in this case setting it back to nil is faster than trying to
> preserve its original value nil.

I see what you mean but there is no performance issue here and not
copying the value of mark-active is cleaner than setting it back to
nil -- we never want to copy the value of the mark at all.


  reply	other threads:[~2014-05-23 17:28 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-04-26  0:06 [PATCH] Fix: Capture abort: (error: The mark is not set now, so there is no region) Alex Kosorukoff
2014-04-29 11:05 ` Bastien
2014-05-09  3:55   ` Alex Kosorukoff
2014-05-23 12:03     ` Bastien
2014-05-23 16:37       ` Alex Kosorukoff
2014-05-23 17:28         ` Bastien [this message]
2014-05-23 17:56           ` Alex Kosorukoff
2014-05-23 19:19             ` Bastien
2014-05-23 19:53               ` Bastien

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

  List information: https://www.orgmode.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87ha4gv1zo.fsf@bzg.ath.cx \
    --to=bzg@gnu.org \
    --cc=alex@3form.com \
    --cc=emacs-orgmode@gnu.org \


* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox


This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).