From: Alex Kosorukoff <alex@3form.com>
To: Bastien <bzg@gnu.org>
Cc: emacs-orgmode@gnu.org
Subject: Re: [PATCH] Fix: Capture abort: (error: The mark is not set now, so there is no region)
Date: Fri, 23 May 2014 09:37:48 -0700 [thread overview]
Message-ID: <CAHD9_tQSRupfv1ZaUH_6AZtuOBMo8ca+DxocjLfWTR-T0hmAsw@mail.gmail.com> (raw)
In-Reply-To: <87zji88vye.fsf@bzg.ath.cx>
[-- Attachment #1: Type: text/plain, Size: 1662 bytes --]
On Fri, May 23, 2014 at 5:03 AM, Bastien <bzg@gnu.org> wrote:
> Hi Alex,
>
> Alex Kosorukoff <alex@3form.com> writes:
>
> > After I replaced my patch and merged Bastien's fix, I started seeing
> > the error though less frequently than before. It didn't occur in the
> > template I posted, but I started seeing it again in another template.
> >
> > ("w" "org-protocol tag" entry (file "~/org/bookmarks.org")
> > "* %:description %(org-set-tags)\n %i\n\n %:link\n%?
> > "
> > :prepend t :empty-lines-after 1 :clock-in t
> > :clock-resume t)
>
> If I may ask, why using %(org-set-tags) instead of %^g or %^G?
>
I am using org-set-tags to avoid autocompletion, both %^g and %^G take too
much time because my org files have many tagged items. Capture should be
fast to be effective.
> I switched back to my initial patch that was checking if the mark was
> > set before trying to access the region. This worked: the errors
> > disappeared.
>
> I think the right fix is to exclude `mark-active' from the local
> variable that are imported through `org-capture-steal-local-variables'.
> I installed such a fix in maint, please update Org and let me know if
> this works for you.
>
Excluding mark-active will work, the result will be the same as after my
patch, except performance will not be the same. Excluding variable requires
filtering the list of variables which takes O(n) whereas my patch takes
O(1). Mark-active is nil before org-capture-steal-local-variables because
this is a new buffer. It seems in this case setting it back to nil is
faster than trying to preserve its original value nil.
> Thanks,
>
> --
> Bastien
>
[-- Attachment #2: Type: text/html, Size: 2849 bytes --]
next prev parent reply other threads:[~2014-05-23 16:38 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-04-26 0:06 [PATCH] Fix: Capture abort: (error: The mark is not set now, so there is no region) Alex Kosorukoff
2014-04-29 11:05 ` Bastien
2014-05-09 3:55 ` Alex Kosorukoff
2014-05-23 12:03 ` Bastien
2014-05-23 16:37 ` Alex Kosorukoff [this message]
2014-05-23 17:28 ` Bastien
2014-05-23 17:56 ` Alex Kosorukoff
2014-05-23 19:19 ` Bastien
2014-05-23 19:53 ` Bastien
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.orgmode.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAHD9_tQSRupfv1ZaUH_6AZtuOBMo8ca+DxocjLfWTR-T0hmAsw@mail.gmail.com \
--to=alex@3form.com \
--cc=bzg@gnu.org \
--cc=emacs-orgmode@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).