From: Alex Kosorukoff <alex@3form.com>
To: emacs-orgmode@gnu.org
Subject: [PATCH] Fix: Capture abort: (error: The mark is not set now, so there is no region)
Date: Fri, 25 Apr 2014 17:06:30 -0700 [thread overview]
Message-ID: <CAHD9_tRzBRPy6LFem9zDFrqKf9Qzb4egvTg60FOpm+sTDuk21w@mail.gmail.com> (raw)
[-- Attachment #1.1: Type: text/plain, Size: 219 bytes --]
I noticed a regression in the capture functionality after upgrading org.
Capture fails with error in subj
Here is a simple config to reproduce the problem and a patch that fixes it.
emacs -q -l capfail.el
Best,
Alex
[-- Attachment #1.2: Type: text/html, Size: 374 bytes --]
[-- Attachment #2: 0001-fix-org-capture-error-The-mark-is-not-set-now-so-the.patch --]
[-- Type: text/x-patch, Size: 959 bytes --]
From ac50a5300e35d7abd5f50317069b2a795fde4ad8 Mon Sep 17 00:00:00 2001
From: Alex Kosorukoff <alex@3form.com>
Date: Mon, 17 Mar 2014 12:56:09 -0700
Subject: [PATCH] fix org-capture error "The mark is not set now, so there is no region"
---
lisp/org.el | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/lisp/org.el b/lisp/org.el
index dc4f2cc..bc5a69e 100644
--- a/lisp/org.el
+++ b/lisp/org.el
@@ -14611,7 +14611,7 @@ When JUST-ALIGN is non-nil, only align tags.
When JUST-ALIGN is 'ignore-column, align tags without trying to set
the column by ignoring invisible text."
(interactive "P")
- (if (and (org-region-active-p) org-loop-over-headlines-in-active-region)
+ (if (and (mark t) (org-region-active-p) org-loop-over-headlines-in-active-region)
(let ((cl (if (eq org-loop-over-headlines-in-active-region 'start-level)
'region-start-level 'region))
org-loop-over-headlines-in-active-region)
--
1.7.0.4
[-- Attachment #3: capfail.el --]
[-- Type: text/x-emacs-lisp, Size: 605 bytes --]
;; capfail.el org-mode capture failure when region is active
;; $ emacs -q -l capfail.el
(setq inhibit-splash-screen t)
(add-to-list 'load-path "~/.emacs.d/org/lisp")
(require 'org)
(setq org-capture-templates
'(("t" "Todo" entry (file "test.org")
"* TODO Test %^g\n %?")))
(define-key global-map (kbd "C-c c") 'org-capture)
(find-file "test.org")
(insert
"Select some text to make a region, then try C-c c t\ntest\n"
"Emacs 23.1.1/23.3.1/24.1/24.2 & Org-mode version 8.2.6 result:\n"
"Capture abort: (error: The mark is not set now, so there is no region)\n")
(provide 'capfail)
next reply other threads:[~2014-04-26 0:06 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-04-26 0:06 Alex Kosorukoff [this message]
2014-04-29 11:05 ` [PATCH] Fix: Capture abort: (error: The mark is not set now, so there is no region) Bastien
2014-05-09 3:55 ` Alex Kosorukoff
2014-05-23 12:03 ` Bastien
2014-05-23 16:37 ` Alex Kosorukoff
2014-05-23 17:28 ` Bastien
2014-05-23 17:56 ` Alex Kosorukoff
2014-05-23 19:19 ` Bastien
2014-05-23 19:53 ` Bastien
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.orgmode.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAHD9_tRzBRPy6LFem9zDFrqKf9Qzb4egvTg60FOpm+sTDuk21w@mail.gmail.com \
--to=alex@3form.com \
--cc=emacs-orgmode@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).