From mboxrd@z Thu Jan 1 00:00:00 1970 From: Bastien Subject: Re: [PATCH] Fix: Capture abort: (error: The mark is not set now, so there is no region) Date: Fri, 23 May 2014 19:28:11 +0200 Message-ID: <87ha4gv1zo.fsf@bzg.ath.cx> References: <877g681jma.fsf@bzg.ath.cx> <87zji88vye.fsf@bzg.ath.cx> Mime-Version: 1.0 Content-Type: text/plain Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:33178) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WntGY-0000l3-E1 for emacs-orgmode@gnu.org; Fri, 23 May 2014 13:28:28 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1WntGQ-0002Lw-Um for emacs-orgmode@gnu.org; Fri, 23 May 2014 13:28:22 -0400 Received: from mail-wg0-x22a.google.com ([2a00:1450:400c:c00::22a]:40812) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WntGQ-0002Lr-Mi for emacs-orgmode@gnu.org; Fri, 23 May 2014 13:28:14 -0400 Received: by mail-wg0-f42.google.com with SMTP id y10so5032621wgg.13 for ; Fri, 23 May 2014 10:28:13 -0700 (PDT) In-Reply-To: (Alex Kosorukoff's message of "Fri, 23 May 2014 09:37:48 -0700") List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org Sender: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org To: Alex Kosorukoff Cc: emacs-orgmode@gnu.org Hi Alex, Alex Kosorukoff writes: > Excluding mark-active will work, the result will be the same as after > my patch, except performance will not be the same. Excluding variable > requires filtering the list of variables which takes O(n) whereas my > patch takes O(1). Mark-active is nil before > org-capture-steal-local-variables because this is a new buffer. It > seems in this case setting it back to nil is faster than trying to > preserve its original value nil. I see what you mean but there is no performance issue here and not copying the value of mark-active is cleaner than setting it back to nil -- we never want to copy the value of the mark at all. -- Bastien