* Bug: Docstrings of =org-agenda-todo-ignore-with-date= and =org-agenda-todo-ignore-timestamp= unclear [9.2 (release_9.2-215-g5b39d8 @ /home/mbork/others-works/emacs/org-mode/lisp/)]
@ 2019-06-18 6:55 Marcin Borkowski
2019-06-19 19:19 ` Nicolas Goaziou
0 siblings, 1 reply; 12+ messages in thread
From: Marcin Borkowski @ 2019-06-18 6:55 UTC (permalink / raw)
To: emacs-orgmode
Remember to cover the basics, that is, what you expected to happen and
what in fact did happen. You don't know how to make a good report? See
https://orgmode.org/manual/Feedback.html#Feedback
Your bug report will be posted to the Org mailing list.
------------------------------------------------------------------------
The docstrings of =org-agenda-todo-ignore-with-date= and
=org-agenda-todo-ignore-timestamp= do not really tell what these
settings are doing. They should (imho) emphasize that the former just
omits from the global todo list all entries with at least one active
timestamp (in the hedaline or the body), and the latter checks the first
active timestamp which is not SCHEDULED or DEADLINE and compares it to
today's date.
It could also be mentioned in the manual.
I have GNU papers for Emacs signed. If this is enough, I'd be happy to
submit a patch. If so, what would be better: to patch only the
docstrings or the docstrings and the manual.
Best,
mb
Emacs : GNU Emacs 27.0.50 (build 2, x86_64-pc-linux-gnu, GTK+ Version 3.24.8)
of 2019-06-15
Package: Org mode version 9.2 (release_9.2-215-g5b39d8 @ /home/mbork/others-works/emacs/org-mode/lisp/)
--
Marcin Borkowski
http://mbork.pl
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: Bug: Docstrings of =org-agenda-todo-ignore-with-date= and =org-agenda-todo-ignore-timestamp= unclear [9.2 (release_9.2-215-g5b39d8 @ /home/mbork/others-works/emacs/org-mode/lisp/)]
2019-06-18 6:55 Bug: Docstrings of =org-agenda-todo-ignore-with-date= and =org-agenda-todo-ignore-timestamp= unclear [9.2 (release_9.2-215-g5b39d8 @ /home/mbork/others-works/emacs/org-mode/lisp/)] Marcin Borkowski
@ 2019-06-19 19:19 ` Nicolas Goaziou
2019-06-23 11:23 ` Marcin Borkowski
0 siblings, 1 reply; 12+ messages in thread
From: Nicolas Goaziou @ 2019-06-19 19:19 UTC (permalink / raw)
To: Marcin Borkowski; +Cc: emacs-orgmode
Hello,
Marcin Borkowski <mbork@mbork.pl> writes:
> The docstrings of =org-agenda-todo-ignore-with-date= and
> =org-agenda-todo-ignore-timestamp= do not really tell what these
> settings are doing. They should (imho) emphasize that the former just
> omits from the global todo list all entries with at least one active
> timestamp (in the hedaline or the body), and the latter checks the first
> active timestamp which is not SCHEDULED or DEADLINE and compares it to
> today's date.
>
> It could also be mentioned in the manual.
>
> I have GNU papers for Emacs signed. If this is enough, I'd be happy to
> submit a patch. If so, what would be better: to patch only the
> docstrings or the docstrings and the manual.
I would say the latter. Thank you.
Regards,
--
Nicolas Goaziou
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: Bug: Docstrings of =org-agenda-todo-ignore-with-date= and =org-agenda-todo-ignore-timestamp= unclear [9.2 (release_9.2-215-g5b39d8 @ /home/mbork/others-works/emacs/org-mode/lisp/)]
2019-06-19 19:19 ` Nicolas Goaziou
@ 2019-06-23 11:23 ` Marcin Borkowski
2019-06-23 19:29 ` Samuel Wales
2019-06-24 19:09 ` Marcin Borkowski
0 siblings, 2 replies; 12+ messages in thread
From: Marcin Borkowski @ 2019-06-23 11:23 UTC (permalink / raw)
To: Nicolas Goaziou; +Cc: emacs-orgmode
[-- Attachment #1: Type: text/plain, Size: 995 bytes --]
On 2019-06-19, at 21:19, Nicolas Goaziou <mail@nicolasgoaziou.fr> wrote:
> Hello,
>
> Marcin Borkowski <mbork@mbork.pl> writes:
>
>> The docstrings of =org-agenda-todo-ignore-with-date= and
>> =org-agenda-todo-ignore-timestamp= do not really tell what these
>> settings are doing. They should (imho) emphasize that the former just
>> omits from the global todo list all entries with at least one active
>> timestamp (in the hedaline or the body), and the latter checks the first
>> active timestamp which is not SCHEDULED or DEADLINE and compares it to
>> today's date.
>>
>> It could also be mentioned in the manual.
>>
>> I have GNU papers for Emacs signed. If this is enough, I'd be happy to
>> submit a patch. If so, what would be better: to patch only the
>> docstrings or the docstrings and the manual.
>
> I would say the latter. Thank you.
I only patched the doctsrings for now. If this is fine, I'll do
a similar thing in the manual.
WDYT?
--
Marcin Borkowski
http://mbork.pl
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: 0001-Make-two-docstrings-more-clear.patch --]
[-- Type: text/x-patch; size=1.79KiB, Size: 1833 bytes --]
From d5a1c1ff3a9a7ccbf2765332971973b2c4233e16 Mon Sep 17 00:00:00 2001
From: Marcin Borkowski <mbork@mbork.pl>
Date: Sun, 23 Jun 2019 13:22:04 +0200
Subject: [PATCH] Make two docstrings more clear
The docstrings of `org-agenda-todo-ignore-with-date` and
`org-agenda-todo-ignore-timestamp` were not very clear. Now they are
better.
---
lisp/org-agenda.el | 10 +++++++---
1 file changed, 7 insertions(+), 3 deletions(-)
diff --git a/lisp/org-agenda.el b/lisp/org-agenda.el
index fbf520c5e..daf51601d 100644
--- a/lisp/org-agenda.el
+++ b/lisp/org-agenda.el
@@ -690,9 +690,10 @@ potentially much shorter TODO lists."
"Non-nil means don't show entries with a date in the global todo list.
You can use this if you prefer to mark mere appointments with a TODO keyword,
but don't want them to show up in the TODO list.
-When this is set, it also covers deadlines and scheduled items, the settings
-of `org-agenda-todo-ignore-scheduled' and `org-agenda-todo-ignore-deadlines'
-will be ignored.
+When this is set, it also covers deadlines and scheduled items
+(more precisely, every entry with at least one active timestamp will be ignored),
+the settings of `org-agenda-todo-ignore-scheduled'
+and `org-agenda-todo-ignore-deadlines' will be ignored.
See also the variable `org-agenda-tags-todo-honor-ignore-options'."
:group 'org-agenda-skip
:group 'org-agenda-todo-list
@@ -700,6 +701,9 @@ See also the variable `org-agenda-tags-todo-honor-ignore-options'."
(defcustom org-agenda-todo-ignore-timestamp nil
"Non-nil means don't show entries with a timestamp.
+If this variable is non-nil, Org agenda looks at the first active
+timestamp in the entry which is neither a DEADLINE nor
+a SCHEDULED timestamp and compares it to \"today\".
This applies when creating the global todo list.
Valid values are:
--
2.22.0
^ permalink raw reply related [flat|nested] 12+ messages in thread
* Re: Bug: Docstrings of =org-agenda-todo-ignore-with-date= and =org-agenda-todo-ignore-timestamp= unclear [9.2 (release_9.2-215-g5b39d8 @ /home/mbork/others-works/emacs/org-mode/lisp/)]
2019-06-23 11:23 ` Marcin Borkowski
@ 2019-06-23 19:29 ` Samuel Wales
2019-06-24 19:08 ` Marcin Borkowski
2019-06-24 19:09 ` Marcin Borkowski
1 sibling, 1 reply; 12+ messages in thread
From: Samuel Wales @ 2019-06-23 19:29 UTC (permalink / raw)
To: Marcin Borkowski; +Cc: emacs-orgmode, Nicolas Goaziou
this looks good, but i wonder if newcomers get confused about that todo thing.
i am not proposing any solution, just brainstorming.
the word todo is used in a few contexts in org:
- the todo keyword per se [TODO]
- todoish keywords as opposed to doneish keywords
- the global todo view as opposed to the general views that cover
time [called daily/weekly], structured search [called tags], and
free-form search [called search]
newcomers might wonder if the global todo view does anything that the
general views cannot do, otherwise why does it exist.
some newcomers might even wonder if todo means keyword as opposed to blank.
don't take this too seriously, but i wonder if that todo- confuses
newcomers even though the docstring is now clear.
On 6/23/19, Marcin Borkowski <mbork@mbork.pl> wrote:
>
> On 2019-06-19, at 21:19, Nicolas Goaziou <mail@nicolasgoaziou.fr> wrote:
>
>> Hello,
>>
>> Marcin Borkowski <mbork@mbork.pl> writes:
>>
>>> The docstrings of =org-agenda-todo-ignore-with-date= and
>>> =org-agenda-todo-ignore-timestamp= do not really tell what these
>>> settings are doing. They should (imho) emphasize that the former just
>>> omits from the global todo list all entries with at least one active
>>> timestamp (in the hedaline or the body), and the latter checks the first
>>> active timestamp which is not SCHEDULED or DEADLINE and compares it to
>>> today's date.
>>>
>>> It could also be mentioned in the manual.
>>>
>>> I have GNU papers for Emacs signed. If this is enough, I'd be happy to
>>> submit a patch. If so, what would be better: to patch only the
>>> docstrings or the docstrings and the manual.
>>
>> I would say the latter. Thank you.
>
> I only patched the doctsrings for now. If this is fine, I'll do
> a similar thing in the manual.
>
> WDYT?
>
> --
> Marcin Borkowski
> http://mbork.pl
>
--
The Kafka Pandemic
What is misopathy?
https://thekafkapandemic.blogspot.com/2013/10/why-some-diseases-are-wronged.html
The disease DOES progress. MANY people have died from it. And ANYBODY
can get it at any time.
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: Bug: Docstrings of =org-agenda-todo-ignore-with-date= and =org-agenda-todo-ignore-timestamp= unclear [9.2 (release_9.2-215-g5b39d8 @ /home/mbork/others-works/emacs/org-mode/lisp/)]
2019-06-23 19:29 ` Samuel Wales
@ 2019-06-24 19:08 ` Marcin Borkowski
0 siblings, 0 replies; 12+ messages in thread
From: Marcin Borkowski @ 2019-06-24 19:08 UTC (permalink / raw)
To: Samuel Wales; +Cc: emacs-orgmode, Nicolas Goaziou
On 2019-06-23, at 21:29, Samuel Wales <samologist@gmail.com> wrote:
> this looks good, but i wonder if newcomers get confused about that todo thing.
>
> i am not proposing any solution, just brainstorming.
>
> the word todo is used in a few contexts in org:
>
> - the todo keyword per se [TODO]
> - todoish keywords as opposed to doneish keywords
> - the global todo view as opposed to the general views that cover
> time [called daily/weekly], structured search [called tags], and
> free-form search [called search]
>
> newcomers might wonder if the global todo view does anything that the
> general views cannot do, otherwise why does it exist.
>
> some newcomers might even wonder if todo means keyword as opposed to blank.
>
> don't take this too seriously, but i wonder if that todo- confuses
> newcomers even though the docstring is now clear.
Good points, though (as you said) this is out of scope of my humble
patch:-).
Best,
--
Marcin Borkowski
http://mbork.pl
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: Bug: Docstrings of =org-agenda-todo-ignore-with-date= and =org-agenda-todo-ignore-timestamp= unclear [9.2 (release_9.2-215-g5b39d8 @ /home/mbork/others-works/emacs/org-mode/lisp/)]
2019-06-23 11:23 ` Marcin Borkowski
2019-06-23 19:29 ` Samuel Wales
@ 2019-06-24 19:09 ` Marcin Borkowski
2019-07-07 7:51 ` Marcin Borkowski
1 sibling, 1 reply; 12+ messages in thread
From: Marcin Borkowski @ 2019-06-24 19:09 UTC (permalink / raw)
To: Nicolas Goaziou; +Cc: emacs-orgmode
[-- Attachment #1: Type: text/plain, Size: 1234 bytes --]
On 2019-06-23, at 13:23, Marcin Borkowski <mbork@mbork.pl> wrote:
> On 2019-06-19, at 21:19, Nicolas Goaziou <mail@nicolasgoaziou.fr> wrote:
>
>> Hello,
>>
>> Marcin Borkowski <mbork@mbork.pl> writes:
>>
>>> The docstrings of =org-agenda-todo-ignore-with-date= and
>>> =org-agenda-todo-ignore-timestamp= do not really tell what these
>>> settings are doing. They should (imho) emphasize that the former just
>>> omits from the global todo list all entries with at least one active
>>> timestamp (in the hedaline or the body), and the latter checks the first
>>> active timestamp which is not SCHEDULED or DEADLINE and compares it to
>>> today's date.
>>>
>>> It could also be mentioned in the manual.
>>>
>>> I have GNU papers for Emacs signed. If this is enough, I'd be happy to
>>> submit a patch. If so, what would be better: to patch only the
>>> docstrings or the docstrings and the manual.
>>
>> I would say the latter. Thank you.
>
> I only patched the doctsrings for now. If this is fine, I'll do
> a similar thing in the manual.
I attach two more patches: one for the manual and one for the (apparent)
bug in `org-agenda-check-for-timestamp-as-reason-to-ignore-todo-item`.
WDYT?
--
Marcin Borkowski
http://mbork.pl
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: 0002-Explain-the-org-agenda-todo-ignore-.-variables-in-th.patch --]
[-- Type: text/x-patch; size=1.41KiB, Size: 1448 bytes --]
From 89e1254d04802b13f4bd8c753287bce4eb1ae044 Mon Sep 17 00:00:00 2001
From: Marcin Borkowski <mbork@mbork.pl>
Date: Mon, 24 Jun 2019 21:05:32 +0200
Subject: [PATCH] Explain the `org-agenda-todo-ignore-...` variables in the
manual
---
doc/org-manual.org | 12 +++++++-----
1 file changed, 7 insertions(+), 5 deletions(-)
diff --git a/doc/org-manual.org b/doc/org-manual.org
index 440888b4e..573c59b99 100644
--- a/doc/org-manual.org
+++ b/doc/org-manual.org
@@ -8545,11 +8545,13 @@ it more compact:
#+vindex: org-agenda-todo-ignore-with-date
Some people view a TODO item that has been /scheduled/ for execution
or have a /deadline/ (see [[*Timestamps]]) as no longer /open/.
- Configure the variables ~org-agenda-todo-ignore-scheduled~,
- ~org-agenda-todo-ignore-deadlines~,
- ~org-agenda-todo-ignore-timestamp~ and/or
- ~org-agenda-todo-ignore-with-date~ to exclude such items from the
- global TODO list.
+ Configure the variables ~org-agenda-todo-ignore-scheduled~ to
+ exclude some or all scheduled items from the global TODO list,
+ ~org-agenda-todo-ignore-deadlines~ to exclude some or all items with
+ a deadline set, ~org-agenda-todo-ignore-timestamp~ to exclude some
+ or all items with an active timestamp other than a DEADLINE or
+ a SCHEDULED timestamp and/or ~org-agenda-todo-ignore-with-date~ to
+ exclude items with at least one active timestamp.
-
#+vindex: org-agenda-todo-list-sublevels
--
2.22.0
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #3: 0003-Fix-a-bug-when-org-agenda-todo-ignore-deadlines-is-s.patch --]
[-- Type: text/x-patch; size=914B, Size: 914 bytes --]
From 0bf1e6e6b25847ce4bee74487782b82c822138a3 Mon Sep 17 00:00:00 2001
From: Marcin Borkowski <mbork@mbork.pl>
Date: Mon, 24 Jun 2019 21:05:56 +0200
Subject: [PATCH] Fix a bug when `org-agenda-todo-ignore-deadlines` is set to t
---
lisp/org-agenda.el | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/lisp/org-agenda.el b/lisp/org-agenda.el
index daf51601d..673c3c311 100644
--- a/lisp/org-agenda.el
+++ b/lisp/org-agenda.el
@@ -5444,7 +5444,7 @@ This function is invoked if `org-agenda-todo-ignore-deadlines',
(and org-agenda-todo-ignore-deadlines
(re-search-forward org-deadline-time-regexp end t)
(cond
- ((memq org-agenda-todo-ignore-deadlines '(t all)) t)
+ ((eq org-agenda-todo-ignore-deadlines 'all) t)
((eq org-agenda-todo-ignore-deadlines 'far)
(not (org-deadline-close-p (match-string 1))))
((eq org-agenda-todo-ignore-deadlines 'future)
--
2.22.0
^ permalink raw reply related [flat|nested] 12+ messages in thread
* Re: Bug: Docstrings of =org-agenda-todo-ignore-with-date= and =org-agenda-todo-ignore-timestamp= unclear [9.2 (release_9.2-215-g5b39d8 @ /home/mbork/others-works/emacs/org-mode/lisp/)]
2019-06-24 19:09 ` Marcin Borkowski
@ 2019-07-07 7:51 ` Marcin Borkowski
2019-07-09 10:22 ` Nicolas Goaziou
0 siblings, 1 reply; 12+ messages in thread
From: Marcin Borkowski @ 2019-07-07 7:51 UTC (permalink / raw)
To: Nicolas Goaziou; +Cc: emacs-orgmode
Hello there,
any comments?
Best,
mb
On 2019-06-24, at 21:09, Marcin Borkowski <mbork@mbork.pl> wrote:
> On 2019-06-23, at 13:23, Marcin Borkowski <mbork@mbork.pl> wrote:
>
>> On 2019-06-19, at 21:19, Nicolas Goaziou <mail@nicolasgoaziou.fr> wrote:
>>
>>> Hello,
>>>
>>> Marcin Borkowski <mbork@mbork.pl> writes:
>>>
>>>> The docstrings of =org-agenda-todo-ignore-with-date= and
>>>> =org-agenda-todo-ignore-timestamp= do not really tell what these
>>>> settings are doing. They should (imho) emphasize that the former just
>>>> omits from the global todo list all entries with at least one active
>>>> timestamp (in the hedaline or the body), and the latter checks the first
>>>> active timestamp which is not SCHEDULED or DEADLINE and compares it to
>>>> today's date.
>>>>
>>>> It could also be mentioned in the manual.
>>>>
>>>> I have GNU papers for Emacs signed. If this is enough, I'd be happy to
>>>> submit a patch. If so, what would be better: to patch only the
>>>> docstrings or the docstrings and the manual.
>>>
>>> I would say the latter. Thank you.
>>
>> I only patched the doctsrings for now. If this is fine, I'll do
>> a similar thing in the manual.
>
> I attach two more patches: one for the manual and one for the (apparent)
> bug in `org-agenda-check-for-timestamp-as-reason-to-ignore-todo-item`.
>
> WDYT?
>
> --
> Marcin Borkowski
> http://mbork.pl
> From 89e1254d04802b13f4bd8c753287bce4eb1ae044 Mon Sep 17 00:00:00 2001
> From: Marcin Borkowski <mbork@mbork.pl>
> Date: Mon, 24 Jun 2019 21:05:32 +0200
> Subject: [PATCH] Explain the `org-agenda-todo-ignore-...` variables in the
> manual
>
> ---
> doc/org-manual.org | 12 +++++++-----
> 1 file changed, 7 insertions(+), 5 deletions(-)
>
> diff --git a/doc/org-manual.org b/doc/org-manual.org
> index 440888b4e..573c59b99 100644
> --- a/doc/org-manual.org
> +++ b/doc/org-manual.org
> @@ -8545,11 +8545,13 @@ it more compact:
> #+vindex: org-agenda-todo-ignore-with-date
> Some people view a TODO item that has been /scheduled/ for execution
> or have a /deadline/ (see [[*Timestamps]]) as no longer /open/.
> - Configure the variables ~org-agenda-todo-ignore-scheduled~,
> - ~org-agenda-todo-ignore-deadlines~,
> - ~org-agenda-todo-ignore-timestamp~ and/or
> - ~org-agenda-todo-ignore-with-date~ to exclude such items from the
> - global TODO list.
> + Configure the variables ~org-agenda-todo-ignore-scheduled~ to
> + exclude some or all scheduled items from the global TODO list,
> + ~org-agenda-todo-ignore-deadlines~ to exclude some or all items with
> + a deadline set, ~org-agenda-todo-ignore-timestamp~ to exclude some
> + or all items with an active timestamp other than a DEADLINE or
> + a SCHEDULED timestamp and/or ~org-agenda-todo-ignore-with-date~ to
> + exclude items with at least one active timestamp.
>
> -
> #+vindex: org-agenda-todo-list-sublevels
> --
> 2.22.0
>
> From 0bf1e6e6b25847ce4bee74487782b82c822138a3 Mon Sep 17 00:00:00 2001
> From: Marcin Borkowski <mbork@mbork.pl>
> Date: Mon, 24 Jun 2019 21:05:56 +0200
> Subject: [PATCH] Fix a bug when `org-agenda-todo-ignore-deadlines` is set to t
>
> ---
> lisp/org-agenda.el | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/lisp/org-agenda.el b/lisp/org-agenda.el
> index daf51601d..673c3c311 100644
> --- a/lisp/org-agenda.el
> +++ b/lisp/org-agenda.el
> @@ -5444,7 +5444,7 @@ This function is invoked if `org-agenda-todo-ignore-deadlines',
> (and org-agenda-todo-ignore-deadlines
> (re-search-forward org-deadline-time-regexp end t)
> (cond
> - ((memq org-agenda-todo-ignore-deadlines '(t all)) t)
> + ((eq org-agenda-todo-ignore-deadlines 'all) t)
> ((eq org-agenda-todo-ignore-deadlines 'far)
> (not (org-deadline-close-p (match-string 1))))
> ((eq org-agenda-todo-ignore-deadlines 'future)
--
Marcin Borkowski
http://mbork.pl
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: Bug: Docstrings of =org-agenda-todo-ignore-with-date= and =org-agenda-todo-ignore-timestamp= unclear [9.2 (release_9.2-215-g5b39d8 @ /home/mbork/others-works/emacs/org-mode/lisp/)]
2019-07-07 7:51 ` Marcin Borkowski
@ 2019-07-09 10:22 ` Nicolas Goaziou
2019-07-11 19:06 ` Marcin Borkowski
0 siblings, 1 reply; 12+ messages in thread
From: Nicolas Goaziou @ 2019-07-09 10:22 UTC (permalink / raw)
To: Marcin Borkowski; +Cc: emacs-orgmode
Hello,
Marcin Borkowski <mbork@mbork.pl> writes:
> Hello there,
>
> any comments?
Thank you for the patches.
I applied the first one. Could you expound the commit message in the
second one: what bug is it?
Regards,
--
Nicolas Goaziou
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: Bug: Docstrings of =org-agenda-todo-ignore-with-date= and =org-agenda-todo-ignore-timestamp= unclear [9.2 (release_9.2-215-g5b39d8 @ /home/mbork/others-works/emacs/org-mode/lisp/)]
2019-07-09 10:22 ` Nicolas Goaziou
@ 2019-07-11 19:06 ` Marcin Borkowski
2019-07-12 8:53 ` Nicolas Goaziou
0 siblings, 1 reply; 12+ messages in thread
From: Marcin Borkowski @ 2019-07-11 19:06 UTC (permalink / raw)
To: Nicolas Goaziou; +Cc: emacs-orgmode
On 2019-07-09, at 12:22, Nicolas Goaziou <mail@nicolasgoaziou.fr> wrote:
> Hello,
>
> Marcin Borkowski <mbork@mbork.pl> writes:
>
>> Hello there,
>>
>> any comments?
>
> Thank you for the patches.
>
> I applied the first one. Could you expound the commit message in the
> second one: what bug is it?
Thanks. I meant that - according to the manual - `t' should be
synonymous with `near' and not `all'. I can fix the commit message, but
could you confirm that I'm right first?
Best,
--
Marcin Borkowski
http://mbork.pl
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: Bug: Docstrings of =org-agenda-todo-ignore-with-date= and =org-agenda-todo-ignore-timestamp= unclear [9.2 (release_9.2-215-g5b39d8 @ /home/mbork/others-works/emacs/org-mode/lisp/)]
2019-07-11 19:06 ` Marcin Borkowski
@ 2019-07-12 8:53 ` Nicolas Goaziou
2019-07-14 20:30 ` Marcin Borkowski
0 siblings, 1 reply; 12+ messages in thread
From: Nicolas Goaziou @ 2019-07-12 8:53 UTC (permalink / raw)
To: Marcin Borkowski; +Cc: emacs-orgmode
Hello,
Marcin Borkowski <mbork@mbork.pl> writes:
> Thanks. I meant that - according to the manual - `t' should be
> synonymous with `near' and not `all'. I can fix the commit message, but
> could you confirm that I'm right first?
AFAICT, your guess sounds right.
Regards,
--
Nicolas Goaziou
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: Bug: Docstrings of =org-agenda-todo-ignore-with-date= and =org-agenda-todo-ignore-timestamp= unclear [9.2 (release_9.2-215-g5b39d8 @ /home/mbork/others-works/emacs/org-mode/lisp/)]
2019-07-12 8:53 ` Nicolas Goaziou
@ 2019-07-14 20:30 ` Marcin Borkowski
2019-07-14 22:00 ` Nicolas Goaziou
0 siblings, 1 reply; 12+ messages in thread
From: Marcin Borkowski @ 2019-07-14 20:30 UTC (permalink / raw)
To: Nicolas Goaziou; +Cc: emacs-orgmode
[-- Attachment #1: Type: text/plain, Size: 426 bytes --]
On 2019-07-12, at 10:53, Nicolas Goaziou <mail@nicolasgoaziou.fr> wrote:
> Hello,
>
> Marcin Borkowski <mbork@mbork.pl> writes:
>
>> Thanks. I meant that - according to the manual - `t' should be
>> synonymous with `near' and not `all'. I can fix the commit message, but
>> could you confirm that I'm right first?
>
> AFAICT, your guess sounds right.
Thanks. How about this?
Best,
--
Marcin Borkowski
http://mbork.pl
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: 0001-Fix-a-bug-when-org-agenda-todo-ignore-deadlines-is-s.patch --]
[-- Type: text/x-patch; size=996B, Size: 996 bytes --]
From 669b4347f35dd87815e9f232ab72533d6514d7d1 Mon Sep 17 00:00:00 2001
From: Marcin Borkowski <mbork@mbork.pl>
Date: Mon, 24 Jun 2019 21:05:56 +0200
Subject: [PATCH] Fix a bug when `org-agenda-todo-ignore-deadlines` is set to t
Make `t' synonymous with `near' instead of `all' (as is stated in the
docstring).
---
lisp/org-agenda.el | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/lisp/org-agenda.el b/lisp/org-agenda.el
index daf51601d..673c3c311 100644
--- a/lisp/org-agenda.el
+++ b/lisp/org-agenda.el
@@ -5444,7 +5444,7 @@ This function is invoked if `org-agenda-todo-ignore-deadlines',
(and org-agenda-todo-ignore-deadlines
(re-search-forward org-deadline-time-regexp end t)
(cond
- ((memq org-agenda-todo-ignore-deadlines '(t all)) t)
+ ((eq org-agenda-todo-ignore-deadlines 'all) t)
((eq org-agenda-todo-ignore-deadlines 'far)
(not (org-deadline-close-p (match-string 1))))
((eq org-agenda-todo-ignore-deadlines 'future)
--
2.22.0
^ permalink raw reply related [flat|nested] 12+ messages in thread
* Re: Bug: Docstrings of =org-agenda-todo-ignore-with-date= and =org-agenda-todo-ignore-timestamp= unclear [9.2 (release_9.2-215-g5b39d8 @ /home/mbork/others-works/emacs/org-mode/lisp/)]
2019-07-14 20:30 ` Marcin Borkowski
@ 2019-07-14 22:00 ` Nicolas Goaziou
0 siblings, 0 replies; 12+ messages in thread
From: Nicolas Goaziou @ 2019-07-14 22:00 UTC (permalink / raw)
To: Marcin Borkowski; +Cc: emacs-orgmode
Hello,
Marcin Borkowski <mbork@mbork.pl> writes:
> Thanks. How about this?
Applied. Thank you.
Regards,
--
Nicolas Goaziou
^ permalink raw reply [flat|nested] 12+ messages in thread
end of thread, other threads:[~2019-07-14 22:01 UTC | newest]
Thread overview: 12+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-06-18 6:55 Bug: Docstrings of =org-agenda-todo-ignore-with-date= and =org-agenda-todo-ignore-timestamp= unclear [9.2 (release_9.2-215-g5b39d8 @ /home/mbork/others-works/emacs/org-mode/lisp/)] Marcin Borkowski
2019-06-19 19:19 ` Nicolas Goaziou
2019-06-23 11:23 ` Marcin Borkowski
2019-06-23 19:29 ` Samuel Wales
2019-06-24 19:08 ` Marcin Borkowski
2019-06-24 19:09 ` Marcin Borkowski
2019-07-07 7:51 ` Marcin Borkowski
2019-07-09 10:22 ` Nicolas Goaziou
2019-07-11 19:06 ` Marcin Borkowski
2019-07-12 8:53 ` Nicolas Goaziou
2019-07-14 20:30 ` Marcin Borkowski
2019-07-14 22:00 ` Nicolas Goaziou
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).