emacs-orgmode@gnu.org archives
 help / color / mirror / code / Atom feed

From: Bastien <bzg@gnu.org>
To: Achim Gratz <Stromeko@nexgo.de>
Cc: emacs-orgmode@gnu.org
Subject: Re: Problems with (defvar foo) and Emacs 23
Date: Mon, 02 Apr 2012 08:12:49 +0200	[thread overview]
Message-ID: <87bona64ri.fsf@gnu.org> (raw)
In-Reply-To: <87aa2vp5ri.fsf@Rainer.invalid> (Achim Gratz's message of "Sun, 01 Apr 2012 22:16:17 +0200")

Achim Gratz <Stromeko@nexgo.de> writes:

> Bernt Hansen writes:
>> I can see the variable in the source defined as
>>
>> lisp/org-clock.el:(defvar org-clock-state) ;; dynamically scoped into this function
>>
>> but I don't get a variable definition with this code in emacs 23.2.1.
>
> You aren't supposed to get one, as this should have been pulling in a
> local variable defined elsewhere (from within another function).
>
>> If I change the definition to
>>
>> (defvar org-clock-state nil)
>>
>> then it works for me.
>
> Yes, but the bug introduced by renaming the variable is still there.
> You do get a variable, but not the one you're supposed to be scoping.

I fixed the problem with `org-clock-state'.  This should be `org-state'.

`state' is a local variable in many org.el functions, I renamed it to
`org-state' in org-clock.el and in "caller" sexp from org.el.  

> Again, the missing value is not the problem.  The problem arises when
> the variable name in the caller and the callee becomes different.  I'll
> let Bastien and Martyn sort that one out... :-)

Let's sort this out by slowly fixing problems that we can spot.

-- 
 Bastien

next prev parent reply	other threads:[~2012-04-02  6:11 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-04-01 18:57 Problems with (defvar foo) and Emacs 23 Bernt Hansen
2012-04-01 20:16 ` Achim Gratz
2012-04-01 20:29   ` [URGENT] " Achim Gratz
2012-04-02  6:15     ` Bastien
2012-04-01 20:37   ` Bastien
2012-04-01 21:18     ` Achim Gratz
2012-04-02  0:53       ` Nick Dokos
2012-04-02  5:31         ` Achim Gratz
2012-04-02  6:01           ` Nick Dokos
2012-04-02  8:21             ` Bastien
2012-04-02  6:28           ` Bastien
2012-04-02  6:27       ` Bastien
2012-04-02 18:11         ` Achim Gratz
2012-04-03  5:49           ` Bastien
2012-04-03  6:04             ` Achim Gratz
2012-04-04  7:25               ` Bastien
2012-04-02  6:12   ` Bastien [this message]
2012-04-07 12:15     ` Matt Lundin
2012-04-09 14:57       ` Bastien
2012-04-01 20:46 ` Nick Dokos
2012-04-01 20:48   ` Bernt Hansen
2012-04-02  6:09   ` Bastien

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.orgmode.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87bona64ri.fsf@gnu.org \
    --to=bzg@gnu.org \
    --cc=Stromeko@nexgo.de \
    --cc=emacs-orgmode@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).