emacs-orgmode@gnu.org archives
 help / color / mirror / code / Atom feed
From: Bastien <bzg@gnu.org>
To: Achim Gratz <Stromeko@nexgo.de>
Cc: emacs-orgmode@gnu.org
Subject: Re: Problems with (defvar foo) and Emacs 23
Date: Mon, 02 Apr 2012 08:27:36 +0200	[thread overview]
Message-ID: <87398m642v.fsf@gnu.org> (raw)
In-Reply-To: <87y5qfp2wd.fsf@Rainer.invalid> (Achim Gratz's message of "Sun, 01 Apr 2012 23:18:10 +0200")

Achim Gratz <Stromeko@nexgo.de> writes:

> Bastien writes:
>> Well -- I'll be pretty busy next week, so hopefully we can fix this
>> soon...  any help welcome!  :)
> Ditto, but you do realize this will be horribly broken in Emacs 24?


are fine.


was problematic, as reported by Bernt, and I think I fixed it.

It leaves us with 


which should be carefully reviewed/tested/amended.

> Anyway, for that single dynamic "state" variable: it is let-bound in
> org.el/org-todo and then dynamically scoped in many, many places:
> contrib/lisp/{org-{checklist,choose},org2rem}.el
> /lisp/{org-{agenda,clock,icalendar,mouse,taskjuggler},org}.el

The `state' dynamically scoped in these files is not necessarily the
same `state' that is dynamically scoped in `org-todo'.  

For example in org-agenda.el there is `state' in `org-agenda-log-mode',
but this is dynamically scoped in another function org-agenda.el that
does not depend on org.el's definition for `state'...

> So the correct prefixed name should probably be org-todo-state (there
> are other such "state"s in other places, don't know yet if they are also
> dynamically scoped into other functions).  You need to also keep track
> of which functions use "state" as a formal parameter name, since these
> shadow the dynamic variable from the outside, but provide another
> "state" for calls on the inside…

Yep -- I guess we're good for a fun ride.

> Haven't yet checked any of the other definitions that had their name
> changed, gotta fetch some sleep before work.

Please do!

Let's do some heavy testing against current HEAD and let's carefully 
review code.  But let's not panic -- Emacs is still in pretest, that's
the whole purpose of a pretest.  

Thanks all for your help,


  parent reply	other threads:[~2012-04-02  6:26 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-04-01 18:57 Problems with (defvar foo) and Emacs 23 Bernt Hansen
2012-04-01 20:16 ` Achim Gratz
2012-04-01 20:29   ` [URGENT] " Achim Gratz
2012-04-02  6:15     ` Bastien
2012-04-01 20:37   ` Bastien
2012-04-01 21:18     ` Achim Gratz
2012-04-02  0:53       ` Nick Dokos
2012-04-02  5:31         ` Achim Gratz
2012-04-02  6:01           ` Nick Dokos
2012-04-02  8:21             ` Bastien
2012-04-02  6:28           ` Bastien
2012-04-02  6:27       ` Bastien [this message]
2012-04-02 18:11         ` Achim Gratz
2012-04-03  5:49           ` Bastien
2012-04-03  6:04             ` Achim Gratz
2012-04-04  7:25               ` Bastien
2012-04-02  6:12   ` Bastien
2012-04-07 12:15     ` Matt Lundin
2012-04-09 14:57       ` Bastien
2012-04-01 20:46 ` Nick Dokos
2012-04-01 20:48   ` Bernt Hansen
2012-04-02  6:09   ` Bastien

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

  List information: https://www.orgmode.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87398m642v.fsf@gnu.org \
    --to=bzg@gnu.org \
    --cc=Stromeko@nexgo.de \
    --cc=emacs-orgmode@gnu.org \


* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox


This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).