From: Nick Dokos <nicholas.dokos@hp.com>
To: Achim Gratz <Stromeko@nexgo.de>
Cc: nicholas.dokos@hp.com, emacs-orgmode@gnu.org
Subject: Re: Problems with (defvar foo) and Emacs 23
Date: Mon, 02 Apr 2012 02:01:32 -0400 [thread overview]
Message-ID: <18469.1333346492@alphaville> (raw)
In-Reply-To: Message from Achim Gratz <Stromeko@nexgo.de> of "Mon, 02 Apr 2012 07:31:34 +0200." <87wr5yg0nd.fsf@Rainer.invalid>
Achim Gratz <Stromeko@nexgo.de> wrote:
> Nick Dokos writes:
> > I assume that we are talking about the seven commits
>
> Yes, but likely not all of them (or all changes in them). The only
> problematic ones are where a dynamically scoped variable is renamed and
> there are a bunch of others that probably are OK.
>
Agreed, but the point is that each and every variable renaming will need
to be checked in the light of these criteria. Bugs like this have the
potential of creating havoc for a long time to come.
It may be easier to start from a working state than to try to fix the
current broken state piecemeal. Besides, I'd rather have a single commit
in the history that does the right thing: having one commit that creates
the initial buggy state and then N commits at various times to fix the
brokenness might create all sorts of problems (breaking bisectability
e.g.)
Nick
> > $ git log --oneline -100 | grep 'Fix global'
> > 6cbf1f4 Fix global dynamic variables in org-agenda.el and org.el.
> > b689cbf Fix global dynamic variables in org-table.el.
> > 9054ba3 Fix global dynamic variables in org-special-blocks.el.
> > b46fa17 Fix global dynamic variables in org-clock.el.
> > 08d9b46 Fix global dynamic variables prefixes in org-bibtex.el.
> > c24fa19 Fix global dynamic variables prefixes in org-mouse.el.
> > fcf13e0 Fix global dynamic variables prefixes in org-beamer.el.
> >
> > I tried reverting these in a branch: I had to merge lisp/org.el by hand
> > while reverting the first one, but the rest went through without any
> > problems.
> >
> > Does that seem like the right thing to do for now then?
>
> For Emacs 24, it is probably the right thing to do, depending on how
> much time there is left before release. In hotfix/master the changes
> should be corrected so that they do what they were supposed to do
> (i.e. also rename the variables in the caller).
>
>
> Regards,
> Achim.
> --
> +<[Q+ Matrix-12 WAVE#46+305 Neuron microQkb Andromeda XTk Blofeld]>+
>
> Wavetables for the Waldorf Blofeld:
> http://Synth.Stromeko.net/Downloads.html#BlofeldUserWavetables
>
>
next prev parent reply other threads:[~2012-04-02 6:01 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-04-01 18:57 Problems with (defvar foo) and Emacs 23 Bernt Hansen
2012-04-01 20:16 ` Achim Gratz
2012-04-01 20:29 ` [URGENT] " Achim Gratz
2012-04-02 6:15 ` Bastien
2012-04-01 20:37 ` Bastien
2012-04-01 21:18 ` Achim Gratz
2012-04-02 0:53 ` Nick Dokos
2012-04-02 5:31 ` Achim Gratz
2012-04-02 6:01 ` Nick Dokos [this message]
2012-04-02 8:21 ` Bastien
2012-04-02 6:28 ` Bastien
2012-04-02 6:27 ` Bastien
2012-04-02 18:11 ` Achim Gratz
2012-04-03 5:49 ` Bastien
2012-04-03 6:04 ` Achim Gratz
2012-04-04 7:25 ` Bastien
2012-04-02 6:12 ` Bastien
2012-04-07 12:15 ` Matt Lundin
2012-04-09 14:57 ` Bastien
2012-04-01 20:46 ` Nick Dokos
2012-04-01 20:48 ` Bernt Hansen
2012-04-02 6:09 ` Bastien
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.orgmode.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=18469.1333346492@alphaville \
--to=nicholas.dokos@hp.com \
--cc=Stromeko@nexgo.de \
--cc=emacs-orgmode@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).