From: Nick Dokos <nicholas.dokos@hp.com>
To: Bastien <bzg@gnu.org>
Cc: Achim Gratz <Stromeko@nexgo.de>,
nicholas.dokos@hp.com, emacs-orgmode@gnu.org
Subject: Re: Problems with (defvar foo) and Emacs 23
Date: Sun, 01 Apr 2012 20:53:56 -0400 [thread overview]
Message-ID: <15968.1333328036@alphaville> (raw)
In-Reply-To: Message from Achim Gratz <Stromeko@nexgo.de> of "Sun\, 01 Apr 2012 23\:18\:10 +0200." <87y5qfp2wd.fsf@Rainer.invalid>
Achim Gratz <Stromeko@nexgo.de> wrote:
> Bastien writes:
> > Well -- I'll be pretty busy next week, so hopefully we can fix this
> > soon... any help welcome! :)
>
> Ditto, but you do realize this will be horribly broken in Emacs 24?
>
> Anyway, for that single dynamic "state" variable: it is let-bound in
> org.el/org-todo and then dynamically scoped in many, many places:
>
> contrib/lisp/{org-{checklist,choose},org2rem}.el
>
> /lisp/{org-{agenda,clock,icalendar,mouse,taskjuggler},org}.el
>
> So the correct prefixed name should probably be org-todo-state (there
> are other such "state"s in other places, don't know yet if they are also
> dynamically scoped into other functions). You need to also keep track
> of which functions use "state" as a formal parameter name, since these
> shadow the dynamic variable from the outside, but provide another
> "state" for calls on the inside…
>
> Haven't yet checked any of the other definitions that had their name
> changed, gotta fetch some sleep before work.
>
>
I assume that we are talking about the seven commits
$ git log --oneline -100 | grep 'Fix global'
6cbf1f4 Fix global dynamic variables in org-agenda.el and org.el.
b689cbf Fix global dynamic variables in org-table.el.
9054ba3 Fix global dynamic variables in org-special-blocks.el.
b46fa17 Fix global dynamic variables in org-clock.el.
08d9b46 Fix global dynamic variables prefixes in org-bibtex.el.
c24fa19 Fix global dynamic variables prefixes in org-mouse.el.
fcf13e0 Fix global dynamic variables prefixes in org-beamer.el.
I tried reverting these in a branch: I had to merge lisp/org.el by hand
while reverting the first one, but the rest went through without any
problems.
Does that seem like the right thing to do for now then?
Nick
next prev parent reply other threads:[~2012-04-02 0:54 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-04-01 18:57 Problems with (defvar foo) and Emacs 23 Bernt Hansen
2012-04-01 20:16 ` Achim Gratz
2012-04-01 20:29 ` [URGENT] " Achim Gratz
2012-04-02 6:15 ` Bastien
2012-04-01 20:37 ` Bastien
2012-04-01 21:18 ` Achim Gratz
2012-04-02 0:53 ` Nick Dokos [this message]
2012-04-02 5:31 ` Achim Gratz
2012-04-02 6:01 ` Nick Dokos
2012-04-02 8:21 ` Bastien
2012-04-02 6:28 ` Bastien
2012-04-02 6:27 ` Bastien
2012-04-02 18:11 ` Achim Gratz
2012-04-03 5:49 ` Bastien
2012-04-03 6:04 ` Achim Gratz
2012-04-04 7:25 ` Bastien
2012-04-02 6:12 ` Bastien
2012-04-07 12:15 ` Matt Lundin
2012-04-09 14:57 ` Bastien
2012-04-01 20:46 ` Nick Dokos
2012-04-01 20:48 ` Bernt Hansen
2012-04-02 6:09 ` Bastien
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.orgmode.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=15968.1333328036@alphaville \
--to=nicholas.dokos@hp.com \
--cc=Stromeko@nexgo.de \
--cc=bzg@gnu.org \
--cc=emacs-orgmode@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).