emacs-orgmode@gnu.org archives
 help / color / mirror / code / Atom feed
From: Ihor Radchenko <yantar92@posteo.net>
To: Pedro Andres Aranda Gutierrez <paaguti@gmail.com>
Cc: Bastien <bzg@gnu.org>, Org Mode List <emacs-orgmode@gnu.org>
Subject: Re: PATCH: include controlling language= in my previous patch
Date: Tue, 13 Dec 2022 11:51:53 +0000	[thread overview]
Message-ID: <87bko7cyhy.fsf@localhost> (raw)
In-Reply-To: <CAO48Bk-f=6dW76s1UgoDRRH7R0ne5Hb9BYHJhzQXJT0rKv1p1g@mail.gmail.com>

Pedro Andres Aranda Gutierrez <paaguti@gmail.com> writes:

> thanks for the patience. I hope to have implemented all suggestions by now.

No. You missed several.

1. :version is not necessary. See 15.1 Common Item Keywords section of
Elisp manual:

2. Please also provide changelog entries. See
https://orgmode.org/worg/org-contribute.html#commit-messages

More comments below.
 
> +*** New =org-latex-listings-src-omit-language= variable for LaTeX export
> +
> +The =org-latex-listings-src-omit-language= customization variable
> +allows you to omit the =language= parameter in the exported
> +=lstlisting= environment. This is necessary when the =listings= backend
> +forwards the actual listing generation to another package like
> +=fancyvrb= using the following setup in the document header:

Please use ~code~ for Elisp symbols and double space between sentences.
You may refer to etc/Documentation_Standards.org file for details.

> +#+BEGIN_example
> +#+LATEX_HEADER: \\RequirePackage{fancyvrb}
> +#+LATEX_HEADER: \\DefineVerbatimEnvironment{verbatim}{Verbatim}{...whatever...}
> +#+LATEX_HEADER: \\DefineVerbatimEnvironment{lstlisting}{Verbatim}{...whatever...}
> +#+END_example

Please quote #+LATEX_HEADER in the example block with commas. (Org will
do it automatically for you if you edit the example block with C-c ')

> +*** The LaTeX export backend only emits =label= and =caption= when they are not empty
> +
> +When exporting a SRC block and using the listings backend , =label==
> +and =caption== parameters for the =lstlisting= environment will be
> +only generated when they are not empty. Things like
> +
> +#+BEGIN_src latex
> +\begin{lstlisting}[label= ,caption= ,captionpos=b]
> +\end{lstlisting}
> +#+END_src
> +
> +will no more appear.

This is probably not something people need to take note of. Not necessary.
  
> Subject: [PATCH 2/4] Allow to suppress language= in SRC blocks
> Subject: [PATCH 3/4] Refine DOCSTRING for org-latex-listings-src-omit-language

2nd and 3rd patches can be merged into one.

-- 
Ihor Radchenko // yantar92,
Org mode contributor,
Learn more about Org mode at <https://orgmode.org/>.
Support Org development at <https://liberapay.com/org-mode>,
or support my work at <https://liberapay.com/yantar92>


  reply	other threads:[~2022-12-13 11:53 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-12-11  8:06 PATCH: include controlling language= in my previous patch Pedro Andres Aranda Gutierrez
2022-12-11 10:05 ` Ihor Radchenko
2022-12-11 11:23   ` Pedro Andres Aranda Gutierrez
2022-12-12 10:11     ` Ihor Radchenko
2022-12-12 12:57       ` Pedro Andres Aranda Gutierrez
2022-12-13  9:24         ` Ihor Radchenko
2022-12-13 11:08           ` Pedro Andres Aranda Gutierrez
2022-12-13 11:51             ` Ihor Radchenko [this message]
2022-12-14  6:37               ` Pedro Andres Aranda Gutierrez
2022-12-14  9:29                 ` Ihor Radchenko
2022-12-18 13:17                   ` Ihor Radchenko
2022-12-18  9:31           ` Bastien Guerry

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.orgmode.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87bko7cyhy.fsf@localhost \
    --to=yantar92@posteo.net \
    --cc=bzg@gnu.org \
    --cc=emacs-orgmode@gnu.org \
    --cc=paaguti@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).