From: Ihor Radchenko <yantar92@posteo.net>
To: Pedro Andres Aranda Gutierrez <paaguti@gmail.com>
Cc: Org Mode List <emacs-orgmode@gnu.org>
Subject: Re: PATCH: include controlling language= in my previous patch
Date: Sun, 11 Dec 2022 10:05:09 +0000 [thread overview]
Message-ID: <87cz8qdzmy.fsf@localhost> (raw)
In-Reply-To: <CAO48Bk9rjGXZMkuPNyXLeRYow95PfBB=+O0S0UuCMTW_pjar0g@mail.gmail.com>
Note: This email thread is a followup for https://orgmode.org/list/CAO48Bk_6bqKgp1MgnZaARYku2+St6R1D4Bziq5NzMWNEWqfitw@mail.gmail.com
Pedro Andres Aranda Gutierrez <paaguti@gmail.com> writes:
> I have a second version of my previous patch, inlcuing and extra variable
> to control whether you want to include the language= or not. It is made in
> a backwards-compatible way. Default is to include it and you have to
>
> (setq org-latex-listings-src-omit-language t)
>
> to omit language=
Makes sense from a first glance.
> + (when label ; label= w/o label makes little sense
> + `(("label" ,(org-latex--label src-block info))))
> + (when caption-str ; caption= w/o caption makes little sense
> + `(("caption" ,caption-str))
> + `(("captionpos" ,(if caption-above-p "t" "b")))) ; as does captionpos w/o caption
This is not true. We do need that empty caption/label.
See
https://git.savannah.gnu.org/cgit/emacs/org-mode.git/commit/?id=eaaa5c2e4
and
https://orgmode.org/list/534BEAFB.4080607@gmx.de
Also, if you can, please create a proper patch instead of diff. See
https://orgmode.org/worg/org-contribute.html#first-patch
--
Ihor Radchenko // yantar92,
Org mode contributor,
Learn more about Org mode at <https://orgmode.org/>.
Support Org development at <https://liberapay.com/org-mode>,
or support my work at <https://liberapay.com/yantar92>
next prev parent reply other threads:[~2022-12-11 10:06 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-12-11 8:06 PATCH: include controlling language= in my previous patch Pedro Andres Aranda Gutierrez
2022-12-11 10:05 ` Ihor Radchenko [this message]
2022-12-11 11:23 ` Pedro Andres Aranda Gutierrez
2022-12-12 10:11 ` Ihor Radchenko
2022-12-12 12:57 ` Pedro Andres Aranda Gutierrez
2022-12-13 9:24 ` Ihor Radchenko
2022-12-13 11:08 ` Pedro Andres Aranda Gutierrez
2022-12-13 11:51 ` Ihor Radchenko
2022-12-14 6:37 ` Pedro Andres Aranda Gutierrez
2022-12-14 9:29 ` Ihor Radchenko
2022-12-18 13:17 ` Ihor Radchenko
2022-12-18 9:31 ` Bastien Guerry
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.orgmode.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87cz8qdzmy.fsf@localhost \
--to=yantar92@posteo.net \
--cc=emacs-orgmode@gnu.org \
--cc=paaguti@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).