emacs-orgmode@gnu.org archives
 help / color / mirror / code / Atom feed

From: Ihor Radchenko <yantar92@posteo.net>
To: Pedro Andres Aranda Gutierrez <paaguti@gmail.com>, Bastien <bzg@gnu.org>
Cc: Org Mode List <emacs-orgmode@gnu.org>
Subject: Re: PATCH: include controlling language= in my previous patch
Date: Tue, 13 Dec 2022 09:24:26 +0000	[thread overview]
Message-ID: <87bko7ejw5.fsf@localhost> (raw)
In-Reply-To: <CAO48Bk9sv-FG_aKGXVR7f_rTgAEYOCT9ytQX2XR8JPStd_mZZw@mail.gmail.com>

Pedro Andres Aranda Gutierrez <paaguti@gmail.com> writes:

> I've (finally) followed the procedure and broken up the patch in two. One
> for the labels= ,caption=  and one for the language= control.

Thanks!
You also need to provide etc/ORG-NEWS entry since we are adding a new
feature here.

> FYI, I have already cleared the FSF paperwork for an emacs patch.

Bastien, could you kindly confirm?

> Subject: [PATCH 2/2] Allow to suppress language= in SRC blocks

Please also provide changelog entries. See
https://orgmode.org/worg/org-contribute.html#commit-messages

> +(defcustom org-latex-listings-src-omit-language nil
> +  "Set this option to t to omit the
> +\"language=\"
> +in the parameters to \\begin{lstlisting} when exporting a src block"

Please describe in the docstring when this kind of setting is needed.

> +  :group 'org-export-latex
> +  :version "30.0"

:version is not necessary. See 15.1 Common Item Keywords section of
Elisp manual:

    ‘:version VERSION’
         This keyword specifies that the item was first introduced in Emacs
         version VERSION, or that its default value was changed in that
         version.  The value VERSION must be a string.
    
    ‘:package-version '(PACKAGE . VERSION)’
         This keyword specifies that the item was first introduced in
         PACKAGE version VERSION, or that its meaning or default value was
         changed in that version.  This keyword takes priority over
                                   ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
         ‘:version’.
         ^^^^^^^^^^^

-- 
Ihor Radchenko // yantar92,
Org mode contributor,
Learn more about Org mode at <https://orgmode.org/>.
Support Org development at <https://liberapay.com/org-mode>,
or support my work at <https://liberapay.com/yantar92>

next prev parent reply	other threads:[~2022-12-13  9:27 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-12-11  8:06 PATCH: include controlling language= in my previous patch Pedro Andres Aranda Gutierrez
2022-12-11 10:05 ` Ihor Radchenko
2022-12-11 11:23   ` Pedro Andres Aranda Gutierrez
2022-12-12 10:11     ` Ihor Radchenko
2022-12-12 12:57       ` Pedro Andres Aranda Gutierrez
2022-12-13  9:24         ` Ihor Radchenko [this message]
2022-12-13 11:08           ` Pedro Andres Aranda Gutierrez
2022-12-13 11:51             ` Ihor Radchenko
2022-12-14  6:37               ` Pedro Andres Aranda Gutierrez
2022-12-14  9:29                 ` Ihor Radchenko
2022-12-18 13:17                   ` Ihor Radchenko
2022-12-18  9:31           ` Bastien Guerry

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.orgmode.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87bko7ejw5.fsf@localhost \
    --to=yantar92@posteo.net \
    --cc=bzg@gnu.org \
    --cc=emacs-orgmode@gnu.org \
    --cc=paaguti@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).