From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp12.migadu.com ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms5.migadu.com with LMTPS id GNL/Fa9nmGNLOQAAbAwnHQ (envelope-from ) for ; Tue, 13 Dec 2022 12:53:19 +0100 Received: from aspmx1.migadu.com ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp12.migadu.com with LMTPS id yMALFq9nmGO/DAEAauVa8A (envelope-from ) for ; Tue, 13 Dec 2022 12:53:19 +0100 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 3156118198 for ; Tue, 13 Dec 2022 12:53:19 +0100 (CET) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1p53pN-00008s-J4; Tue, 13 Dec 2022 06:52:05 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1p53pJ-00008I-EJ for emacs-orgmode@gnu.org; Tue, 13 Dec 2022 06:52:01 -0500 Received: from mout02.posteo.de ([185.67.36.66]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1p53pH-0006BF-Nm for emacs-orgmode@gnu.org; Tue, 13 Dec 2022 06:52:01 -0500 Received: from submission (posteo.de [185.67.36.169]) by mout02.posteo.de (Postfix) with ESMTPS id 378B2240104 for ; Tue, 13 Dec 2022 12:51:58 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.net; s=2017; t=1670932318; bh=DKR9lG17POIMB1yZvxfyav+RcKzqH3Mj+caSr2ba/hQ=; h=From:To:Cc:Subject:Date:From; b=OgXdZpcMf1C/e2b27xkxhwLJQ3DLd2+rLJ3IUYGBejoA7W+jVbQrQVIKFmdFF2o+Y 5Fzxx9DvP4OM8BCQ1cAzJWcqSz+N3Svz2w1OfLx7sii/kRZcHrZ97K+h9XZmNPspRZ +yydag8q2ANS0/MMLI0JPLOnaGieA+K4mZKgcSWXgdw6jbL4Tpp8tjsrQJcHTBCTH5 uG6qrsI1xVEB+QRDe+WX7RlMHFsYk1v+Hhi7jHFnFrp3/xW0C6kOSQzPJ9iXY+4faV ZJxan3zr34bBoqDgZZdolbAGnit1FuTkEgPgjxkD7cS1KpxRasEPOjDIyXjpRjRBzT 1bTBiKIxJUkHg== Received: from customer (localhost [127.0.0.1]) by submission (posteo.de) with ESMTPSA id 4NWcKk6q9Wz9rxB; Tue, 13 Dec 2022 12:51:54 +0100 (CET) From: Ihor Radchenko To: Pedro Andres Aranda Gutierrez Cc: Bastien , Org Mode List Subject: Re: PATCH: include controlling language= in my previous patch In-Reply-To: References: <87cz8qdzmy.fsf@localhost> <877cyxhqy1.fsf@localhost> <87bko7ejw5.fsf@localhost> Date: Tue, 13 Dec 2022 11:51:53 +0000 Message-ID: <87bko7cyhy.fsf@localhost> MIME-Version: 1.0 Content-Type: text/plain Received-SPF: pass client-ip=185.67.36.66; envelope-from=yantar92@posteo.net; helo=mout02.posteo.de X-Spam_score_int: -43 X-Spam_score: -4.4 X-Spam_bar: ---- X-Spam_report: (-4.4 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_MED=-2.3, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-orgmode@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-orgmode-bounces+larch=yhetil.org@gnu.org Sender: emacs-orgmode-bounces+larch=yhetil.org@gnu.org X-Migadu-Country: US X-Migadu-Flow: FLOW_IN ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1670932399; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=L0dBb7A703hMnAwDFUY4yyjCeZuS+Rav0PzOylWszfE=; b=KgByTG6sIQgDgBwkx7Dgr7LlwDdcxR/T/GwCkcidgcQm0o/HrcfG3vuHp3XzR1B6U7qqjc ZkJXrAlVFG2yH2/D6QX96pi0JAwL4YVSCBc38J1UvHmqVEPgub7rvQnZX9IiWbPdH3bnDl NxqZQsO/d1nq6Rut89+heSCQNCytp+om356nH7vOpl1OYcdmsroKVkdKL6+uZAjQkCuyvn 9ccM1494wZzsLl5LDSkutThWlSpDiLc8ND/tObHXrzr2DXdpHi3F1a8lm3dkXsy/F29IW6 vYQT8Qvu8VTwYs3BupOC+YAd3ixjjkMfjG/COgISwSoMfXA8v9SweHAufyhrTA== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=pass header.d=posteo.net header.s=2017 header.b=OgXdZpcM; spf=pass (aspmx1.migadu.com: domain of "emacs-orgmode-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="emacs-orgmode-bounces+larch=yhetil.org@gnu.org"; dmarc=pass (policy=none) header.from=posteo.net ARC-Seal: i=1; s=key1; d=yhetil.org; t=1670932399; a=rsa-sha256; cv=none; b=fiRAuQxfyZPur/YJf/6HydD2v3rt6jBSbaDuI8Iont51D2J3dFesxYhXdBxm/tVjR0bG4O Q9/EYVmFFCocw5XrH9FFKnkIvoKeUmyIVrVdOCHMwR8K3m9e5+aXb7l3Z6W7puLXhtPKRJ /CCKT4nuMUEwbOttYb0XWu6TrMASlTMd75W/3qaaNbVYoPMRpP/BAZrq+umG+e26S0KTRy Xa/JBdkIGjL6sDm8+d9EpwCKlm12iY7mGQw2TYpaEkfPrU8JSgbNfpVvL5CsZlgHR5cCmL +JDJwNt1AEbapCVhV3iQTOB7vTF8wdqZWsU1a/+Yl2xdtnD5OBblP8gDvJ/13w== X-Migadu-Spam-Score: -4.36 X-Spam-Score: -4.36 X-Migadu-Queue-Id: 3156118198 X-Migadu-Scanner: scn1.migadu.com Authentication-Results: aspmx1.migadu.com; dkim=pass header.d=posteo.net header.s=2017 header.b=OgXdZpcM; spf=pass (aspmx1.migadu.com: domain of "emacs-orgmode-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="emacs-orgmode-bounces+larch=yhetil.org@gnu.org"; dmarc=pass (policy=none) header.from=posteo.net X-TUID: +SkwAa9KZvoO Pedro Andres Aranda Gutierrez writes: > thanks for the patience. I hope to have implemented all suggestions by now. No. You missed several. 1. :version is not necessary. See 15.1 Common Item Keywords section of Elisp manual: 2. Please also provide changelog entries. See https://orgmode.org/worg/org-contribute.html#commit-messages More comments below. > +*** New =org-latex-listings-src-omit-language= variable for LaTeX export > + > +The =org-latex-listings-src-omit-language= customization variable > +allows you to omit the =language= parameter in the exported > +=lstlisting= environment. This is necessary when the =listings= backend > +forwards the actual listing generation to another package like > +=fancyvrb= using the following setup in the document header: Please use ~code~ for Elisp symbols and double space between sentences. You may refer to etc/Documentation_Standards.org file for details. > +#+BEGIN_example > +#+LATEX_HEADER: \\RequirePackage{fancyvrb} > +#+LATEX_HEADER: \\DefineVerbatimEnvironment{verbatim}{Verbatim}{...whatever...} > +#+LATEX_HEADER: \\DefineVerbatimEnvironment{lstlisting}{Verbatim}{...whatever...} > +#+END_example Please quote #+LATEX_HEADER in the example block with commas. (Org will do it automatically for you if you edit the example block with C-c ') > +*** The LaTeX export backend only emits =label= and =caption= when they are not empty > + > +When exporting a SRC block and using the listings backend , =label== > +and =caption== parameters for the =lstlisting= environment will be > +only generated when they are not empty. Things like > + > +#+BEGIN_src latex > +\begin{lstlisting}[label= ,caption= ,captionpos=b] > +\end{lstlisting} > +#+END_src > + > +will no more appear. This is probably not something people need to take note of. Not necessary. > Subject: [PATCH 2/4] Allow to suppress language= in SRC blocks > Subject: [PATCH 3/4] Refine DOCSTRING for org-latex-listings-src-omit-language 2nd and 3rd patches can be merged into one. -- Ihor Radchenko // yantar92, Org mode contributor, Learn more about Org mode at . Support Org development at , or support my work at