emacs-orgmode@gnu.org archives
 help / color / mirror / code / Atom feed
From: Rasmus <rasmus@gmx.us>
To: emacs-orgmode@gnu.org
Subject: Re: [bug] org-cycle changed behavior in orgstruct-mode
Date: Mon, 31 Aug 2015 09:53:32 +0200	[thread overview]
Message-ID: <878u8rc2rn.fsf@gmx.us> (raw)
In-Reply-To: 874mjg360d.fsf@nicolasgoaziou.fr

Hi,

>> But are the slowdowns associated with outline.el functions anything that
>> will realistically be felt in normal usage?
>
> They are noticeable under certain circumstances. I implemented
> `org-show-children' because `show-children' was /reported/ as slow.

OK.

> Generally speaking, outline doesn't cope well with dense sub-trees. As
> an example, consider `org-forward-heading-same-level'. Using outline, we
> need to move to next headline, check its level, compare with original,
> rinse and repeat, possibly many times, until we find a match. However,
> we could simply do
>
>   (re-search-forward some-appropriate-regexp nil t)
>
> and be done with it since we can turn level into a regexp.

Indeed.  That seems like a better implementation in any case.

>> IMO the biggest advantage of orgstruct is that it has more sensible
>> keybindings than outline.  Of course it's also nice with lists and tables
>> (assuming they are not in orgstruct++; don't remember)...
>
> Table is orgtbl-mode, not orgstruct-mode. 
>
> List handling is a real concern however, because we cannot use the
> parser (there is no context to know about) but still have to analyze
> lists.

In an ideal world it should also "ignore" comment-start in the sense that
I it should help me with lists after, e.g. ";;".  I wonder if any of
Thorsten's packages on this already solved this issue.

>> Adding advice to orgstruct, which is a mess anyway, won't make it any
>> worse than it is...
>
> Agreed.

OK, so I'll experiment with an "old advice" around orgstruct.

BTW: We have 20 defadvice in lisp/.  That seems like enough reason (to me)
to bump Org 9 to 24.4.

Rasmus

-- 
And when I’m finished thinking, I have to die a lot

  reply	other threads:[~2015-08-31  7:53 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-08-11  9:50 [bug] org-cycle changed behavior in orgstruct-mode Rasmus
2015-08-11 12:24 ` Nicolas Goaziou
2015-08-11 12:34   ` Rasmus
2015-08-11 12:45     ` Nicolas Goaziou
2015-08-11 13:31       ` Rasmus
2015-08-14 15:53         ` Nicolas Goaziou
2015-08-16  9:10           ` Rasmus
2015-08-11 15:59     ` Nicolas Goaziou
2015-08-29 21:12       ` Rasmus
2015-08-30  7:13         ` Nicolas Goaziou
2015-08-30 18:22           ` Rasmus
2015-08-30 19:26             ` Nicolas Goaziou
2015-08-30 19:39               ` Rasmus
2015-08-30 19:56                 ` Nicolas Goaziou
2015-08-31  7:53                   ` Rasmus [this message]
2015-09-13 11:21                   ` Rasmus

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.orgmode.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=878u8rc2rn.fsf@gmx.us \
    --to=rasmus@gmx.us \
    --cc=emacs-orgmode@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).