From: Rasmus <rasmus@gmx.us>
To: emacs-orgmode@gnu.org
Subject: Re: [bug] org-cycle changed behavior in orgstruct-mode
Date: Sun, 30 Aug 2015 21:39:14 +0200 [thread overview]
Message-ID: <87io7wbm71.fsf@gmx.us> (raw)
In-Reply-To: <87egik37dq.fsf@nicolasgoaziou.fr> (Nicolas Goaziou's message of "Sun, 30 Aug 2015 21:26:25 +0200")
Hi,
>> Do you mean to change org-cycle-internal-local as in this patch or to make
>> a hook around it?
>
> The former. However, a hook is OK too, but I couldn't find an acceptable
> candidate.
>
> Funnily, `org-end-of-subtree' does the exact opposite: it hard-codes
> behaviour and switch to the slow, outline.el, function when in
> a different mode. Other functions do not even have a fast path (e.g.
> `org-forward-heading-same-level').
>
> We could make these functions faster, but we first need to decide how to
> proceed when it happens.
But are the slowdowns associated with outline.el functions anything that
will realistically be felt in normal usage?
> After all, maybe the most simple path is good ole advice. Since
> `orgstruct-mode' already hijacks bindings, the next step would be to do
> the same for functions.
>
> WDYT?
IMO the biggest advantage of orgstruct is that it has more sensible
keybindings than outline. Of course it's also nice with lists and tables
(assuming they are not in orgstruct++; don't remember)... Adding advice
to orgstruct, which is a mess anyway, won't make it any worse than it
is...
I'm all for advising if that's easier or if we want to add workarounds in
more places. For my problem, the proposed one line patch fixes it,
though.
>> Maybe the exception should be if orgstruct is detected rather than if
>> org is not detected.
>
> Not really, because you can have orgstruct on even in an Org buffer.
OK.
--
. . . It begins of course with The Internet. A Net of Peers
next prev parent reply other threads:[~2015-08-30 19:39 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-08-11 9:50 [bug] org-cycle changed behavior in orgstruct-mode Rasmus
2015-08-11 12:24 ` Nicolas Goaziou
2015-08-11 12:34 ` Rasmus
2015-08-11 12:45 ` Nicolas Goaziou
2015-08-11 13:31 ` Rasmus
2015-08-14 15:53 ` Nicolas Goaziou
2015-08-16 9:10 ` Rasmus
2015-08-11 15:59 ` Nicolas Goaziou
2015-08-29 21:12 ` Rasmus
2015-08-30 7:13 ` Nicolas Goaziou
2015-08-30 18:22 ` Rasmus
2015-08-30 19:26 ` Nicolas Goaziou
2015-08-30 19:39 ` Rasmus [this message]
2015-08-30 19:56 ` Nicolas Goaziou
2015-08-31 7:53 ` Rasmus
2015-09-13 11:21 ` Rasmus
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.orgmode.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87io7wbm71.fsf@gmx.us \
--to=rasmus@gmx.us \
--cc=emacs-orgmode@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).