From: Rasmus <rasmus@gmx.us>
To: emacs-orgmode@gnu.org
Subject: Re: [bug] org-cycle changed behavior in orgstruct-mode
Date: Sun, 16 Aug 2015 11:10:15 +0200 [thread overview]
Message-ID: <87twrzoayw.fsf@gmx.us> (raw)
In-Reply-To: 87mvxteuir.fsf@nicolasgoaziou.fr
Nicolas Goaziou <mail@nicolasgoaziou.fr> writes:
> Rasmus <rasmus@gmx.us> writes:
>
>> Great. The bad commit seems to be:
>>
>> commit 898cfbcac0560d1d742d939a62c5a8253fe9b66f
>> Author: Nicolas Goaziou <mail@nicolasgoaziou.fr>
>> Date: Mon Aug 10 13:34:07 2015 +0200
>>
>> Implement faster `show-children' function
>>
>> * lisp/org.el (org-show-children): New function.
>> (org-cycle-internal-local):
>> (org-set-visibility-according-to-property):
>> (org-content):
>> (org-move-subtree-down):
>> (orgstruct-setup):
>> (org-show-set-visibility):
>> * contrib/lisp/org-toc.el (org-toc-cycle-subtree):
>> (org-toc-restore-config):
>> * lisp/org-agenda.el (org-agenda-show-1):
>> * lisp/org-feed.el (org-feed-update): Use new function.
>>
>> * etc/ORG-NEWS: Document new function.
>>
>> Suggested-by: Samuel Wales <samologist@gmail.com>
>> <http://permalink.gmane.org/gmane.emacs.orgmode/99616>
>>
>> I guess I will have to dissect it more to figure out what broke.
>
> `org-cycle-internal-local' calls `org-show-children', which is the Org
> specific implementation of `show-children'.
OK
> I don't think orgstruct details should leak into `org-show-children', so
> I suggest to plug orgstruct stuff, i.e., make sure `show-children' is
> called instead of `org-show-children', elsewhere.
Sounds right.
> One possibility is to use a hook in `org-cycle', not sure which one
> though. `orgstruct-mode' could also assume its kludge status and use
> something like `add-function'.
This is a possibility. Isn't nadvice.el is too recent though? [Do you
check NEWS files to see when something is added?]. Anyway, we can add an
advice around it and redefine org-show-children or something.... Sounds
ugly.
Would it be enough to just change the keymap of TAB-like keys?
I would love to rip orgstruct out of org.el and make it less
hacky/"kludgy". The implementation remains mostly opaque to me.
Rasmus
--
The Kids call him Billy the Saint
next prev parent reply other threads:[~2015-08-16 9:10 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-08-11 9:50 [bug] org-cycle changed behavior in orgstruct-mode Rasmus
2015-08-11 12:24 ` Nicolas Goaziou
2015-08-11 12:34 ` Rasmus
2015-08-11 12:45 ` Nicolas Goaziou
2015-08-11 13:31 ` Rasmus
2015-08-14 15:53 ` Nicolas Goaziou
2015-08-16 9:10 ` Rasmus [this message]
2015-08-11 15:59 ` Nicolas Goaziou
2015-08-29 21:12 ` Rasmus
2015-08-30 7:13 ` Nicolas Goaziou
2015-08-30 18:22 ` Rasmus
2015-08-30 19:26 ` Nicolas Goaziou
2015-08-30 19:39 ` Rasmus
2015-08-30 19:56 ` Nicolas Goaziou
2015-08-31 7:53 ` Rasmus
2015-09-13 11:21 ` Rasmus
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.orgmode.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87twrzoayw.fsf@gmx.us \
--to=rasmus@gmx.us \
--cc=emacs-orgmode@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).