From mboxrd@z Thu Jan 1 00:00:00 1970 From: Rasmus Subject: Re: [bug] org-cycle changed behavior in orgstruct-mode Date: Mon, 31 Aug 2015 09:53:32 +0200 Message-ID: <878u8rc2rn.fsf@gmx.us> References: <87fv3q2lxs.fsf@gmx.us> <878u9ic8sv.fsf@nicolasgoaziou.fr> <87zj1y0zst.fsf@gmx.us> <87614l95p7.fsf@nicolasgoaziou.fr> <877fodpzn0.fsf@gmx.us> <8737z145bo.fsf@nicolasgoaziou.fr> <87vbbwbpro.fsf@gmx.us> <87egik37dq.fsf@nicolasgoaziou.fr> <87io7wbm71.fsf@gmx.us> <874mjg360d.fsf@nicolasgoaziou.fr> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:57657) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZWJuU-0004qZ-0x for emacs-orgmode@gnu.org; Mon, 31 Aug 2015 03:53:47 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZWJuQ-0000Wt-Qo for emacs-orgmode@gnu.org; Mon, 31 Aug 2015 03:53:45 -0400 Received: from plane.gmane.org ([80.91.229.3]:33236) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZWJuQ-0000WY-Ja for emacs-orgmode@gnu.org; Mon, 31 Aug 2015 03:53:42 -0400 Received: from list by plane.gmane.org with local (Exim 4.69) (envelope-from ) id 1ZWJuN-0006sG-RM for emacs-orgmode@gnu.org; Mon, 31 Aug 2015 09:53:40 +0200 Received: from 62.80.108.9 ([62.80.108.9]) by main.gmane.org with esmtp (Gmexim 0.1 (Debian)) id 1AlnuQ-0007hv-00 for ; Mon, 31 Aug 2015 09:53:39 +0200 Received: from rasmus by 62.80.108.9 with local (Gmexim 0.1 (Debian)) id 1AlnuQ-0007hv-00 for ; Mon, 31 Aug 2015 09:53:39 +0200 List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org Sender: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org To: emacs-orgmode@gnu.org Hi, >> But are the slowdowns associated with outline.el functions anything that >> will realistically be felt in normal usage? > > They are noticeable under certain circumstances. I implemented > `org-show-children' because `show-children' was /reported/ as slow. OK. > Generally speaking, outline doesn't cope well with dense sub-trees. As > an example, consider `org-forward-heading-same-level'. Using outline, we > need to move to next headline, check its level, compare with original, > rinse and repeat, possibly many times, until we find a match. However, > we could simply do > > (re-search-forward some-appropriate-regexp nil t) > > and be done with it since we can turn level into a regexp. Indeed. That seems like a better implementation in any case. >> IMO the biggest advantage of orgstruct is that it has more sensible >> keybindings than outline. Of course it's also nice with lists and tables >> (assuming they are not in orgstruct++; don't remember)... > > Table is orgtbl-mode, not orgstruct-mode. > > List handling is a real concern however, because we cannot use the > parser (there is no context to know about) but still have to analyze > lists. In an ideal world it should also "ignore" comment-start in the sense that I it should help me with lists after, e.g. ";;". I wonder if any of Thorsten's packages on this already solved this issue. >> Adding advice to orgstruct, which is a mess anyway, won't make it any >> worse than it is... > > Agreed. OK, so I'll experiment with an "old advice" around orgstruct. BTW: We have 20 defadvice in lisp/. That seems like enough reason (to me) to bump Org 9 to 24.4. Rasmus -- And when I’m finished thinking, I have to die a lot