* Re: Error when using org-ctrl-c-ctrl-c to add tags
@ 2015-04-18 18:50 Vicente Vera
2015-04-19 14:36 ` Marc Ihm
0 siblings, 1 reply; 14+ messages in thread
From: Vicente Vera @ 2015-04-18 18:50 UTC (permalink / raw)
To: rasmus, emacs-orgmode
Hi.
Don't think there are more details to provide. The error message
appears upon pressing C-c C-c (bound to the org-ctrl-c-ctrl-c command)
on a headline, doesn't matter which level.
It happened in 3 different Org files, one of which was created for testing.
Also tried with "emacs -q" but the error persisted.
Strange message though, org-tags-completion-function is a function,
not a variable, so why is Emacs complaining that it isn't a list?
Probably related to commit acf7f47ecd20a48c05f97dc660b00d1850b57e10?
^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: Error when using org-ctrl-c-ctrl-c to add tags
2015-04-18 18:50 Error when using org-ctrl-c-ctrl-c to add tags Vicente Vera
@ 2015-04-19 14:36 ` Marc Ihm
2015-04-19 14:53 ` Rasmus
` (2 more replies)
0 siblings, 3 replies; 14+ messages in thread
From: Marc Ihm @ 2015-04-19 14:36 UTC (permalink / raw)
To: Vicente Vera; +Cc: emacs-orgmode, rasmus
Vicente Vera <vicentemvp@gmail.com> writes:
> Hi.
> Don't think there are more details to provide. The error message
> appears upon pressing C-c C-c (bound to the org-ctrl-c-ctrl-c command)
> on a headline, doesn't matter which level.
> It happened in 3 different Org files, one of which was created for testing.
> Also tried with "emacs -q" but the error persisted.
>
> Strange message though, org-tags-completion-function is a function,
> not a variable, so why is Emacs complaining that it isn't a list?
> Probably related to commit acf7f47ecd20a48c05f97dc660b00d1850b57e10?
I see this error too; the patch below fixes it for me (and corrects the
nexting level of 'completing-read too ...)
best regards
Marc
diff --git a/lisp/org.el b/lisp/org.el
index 8a00847..f440382 100755
--- a/lisp/org.el
+++ b/lisp/org.el
@@ -10512,10 +10512,11 @@ from."
(listp (second args)))
'org-iswitchb-completing-read)
(t (or (and (boundp 'completing-read-function)
- completing-read-function)
- 'completing-read)))
+ completing-read-function))
+ 'completing-read))
(concat (car args))
- (if (consp (car (nth 1 args)))
+ (if (and (consp (nth 1 args))
+ (consp (car (nth 1 args))))
(mapcar 'car (nth 1 args))
(nth 1 args))
(cddr args)))))
^ permalink raw reply related [flat|nested] 14+ messages in thread* Re: Error when using org-ctrl-c-ctrl-c to add tags
2015-04-19 14:36 ` Marc Ihm
@ 2015-04-19 14:53 ` Rasmus
2015-04-19 15:03 ` Vicente Vera
2015-04-19 16:05 ` Marc Ihm
2 siblings, 0 replies; 14+ messages in thread
From: Rasmus @ 2015-04-19 14:53 UTC (permalink / raw)
To: emacs-orgmode
Hi Marc (and Vincent),
Marc Ihm <marc@ihm.name> writes:
> Vicente Vera <vicentemvp@gmail.com> writes:
>
>> Don't think there are more details to provide. The error message
>> appears upon pressing C-c C-c (bound to the org-ctrl-c-ctrl-c command)
>> on a headline, doesn't matter which level.
>> It happened in 3 different Org files, one of which was created for testing.
>> Also tried with "emacs -q" but the error persisted.
Thanks for confirming.
>> Strange message though, org-tags-completion-function is a function,
>> not a variable, so why is Emacs complaining that it isn't a list?
>> Probably related to commit acf7f47ecd20a48c05f97dc660b00d1850b57e10?
>
> I see this error too; the patch below fixes it for me (and corrects the
> nexting level of 'completing-read too ...)
Thanks for confirming. Do you (also) see it when starting Emacs with
"emacs -q", as Vincent?
Finally, can you repost post the patch via git am against master?
Thanks,
Rasmus
--
Summon the Mothership!
^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: Error when using org-ctrl-c-ctrl-c to add tags
2015-04-19 14:36 ` Marc Ihm
2015-04-19 14:53 ` Rasmus
@ 2015-04-19 15:03 ` Vicente Vera
2015-04-19 16:05 ` Marc Ihm
2 siblings, 0 replies; 14+ messages in thread
From: Vicente Vera @ 2015-04-19 15:03 UTC (permalink / raw)
To: Marc Ihm; +Cc: emacs-orgmode, rasmus
Hello Marc. Yes, upon further inspection it seems the problem is in
org-icompleting-read. This function is complaining that
org-tags-completion--function---one of its arguments---is not a list.
2015-04-19 11:36 GMT-03:00 Marc Ihm <marc@ihm.name>:
> Vicente Vera <vicentemvp@gmail.com> writes:
>
>> Hi.
>> Don't think there are more details to provide. The error message
>> appears upon pressing C-c C-c (bound to the org-ctrl-c-ctrl-c command)
>> on a headline, doesn't matter which level.
>> It happened in 3 different Org files, one of which was created for testing.
>> Also tried with "emacs -q" but the error persisted.
>>
>> Strange message though, org-tags-completion-function is a function,
>> not a variable, so why is Emacs complaining that it isn't a list?
>> Probably related to commit acf7f47ecd20a48c05f97dc660b00d1850b57e10?
>
> I see this error too; the patch below fixes it for me (and corrects the
> nexting level of 'completing-read too ...)
>
> best regards
> Marc
>
>
> diff --git a/lisp/org.el b/lisp/org.el
> index 8a00847..f440382 100755
> --- a/lisp/org.el
> +++ b/lisp/org.el
> @@ -10512,10 +10512,11 @@ from."
> (listp (second args)))
> 'org-iswitchb-completing-read)
> (t (or (and (boundp 'completing-read-function)
> - completing-read-function)
> - 'completing-read)))
> + completing-read-function))
> + 'completing-read))
> (concat (car args))
> - (if (consp (car (nth 1 args)))
> + (if (and (consp (nth 1 args))
> + (consp (car (nth 1 args))))
> (mapcar 'car (nth 1 args))
> (nth 1 args))
> (cddr args)))))
^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: Error when using org-ctrl-c-ctrl-c to add tags
2015-04-19 14:36 ` Marc Ihm
2015-04-19 14:53 ` Rasmus
2015-04-19 15:03 ` Vicente Vera
@ 2015-04-19 16:05 ` Marc Ihm
2015-04-20 2:06 ` Vicente Vera
2015-04-20 8:19 ` Rasmus
2 siblings, 2 replies; 14+ messages in thread
From: Marc Ihm @ 2015-04-19 16:05 UTC (permalink / raw)
To: Vicente Vera; +Cc: emacs-orgmode, rasmus
Okay, this one only tries to fix, what seems broken ...
Could someone please check ?
best regards
Marc
diff --git a/lisp/org.el b/lisp/org.el
index 24b3a69..8a00847 100755
--- a/lisp/org.el
+++ b/lisp/org.el
@@ -10515,8 +10515,7 @@ from."
completing-read-function)
'completing-read)))
(concat (car args))
- (if (and (consp (nth 1 args))
- (consp (car (nth 1 args))))
+ (if (consp (car (nth 1 args)))
(mapcar 'car (nth 1 args))
(nth 1 args))
(cddr args)))))
^ permalink raw reply related [flat|nested] 14+ messages in thread* Re: Error when using org-ctrl-c-ctrl-c to add tags
2015-04-19 16:05 ` Marc Ihm
@ 2015-04-20 2:06 ` Vicente Vera
2015-04-20 8:19 ` Rasmus
1 sibling, 0 replies; 14+ messages in thread
From: Vicente Vera @ 2015-04-20 2:06 UTC (permalink / raw)
To: Marc Ihm; +Cc: emacs-orgmode, rasmus
Worked for me.
2015-04-19 13:05 GMT-03:00 Marc Ihm <marc@ihm.name>:
>
> Okay, this one only tries to fix, what seems broken ...
> Could someone please check ?
>
> best regards
> Marc
>
>
> diff --git a/lisp/org.el b/lisp/org.el
> index 24b3a69..8a00847 100755
> --- a/lisp/org.el
> +++ b/lisp/org.el
> @@ -10515,8 +10515,7 @@ from."
> completing-read-function)
> 'completing-read)))
> (concat (car args))
> - (if (and (consp (nth 1 args))
> - (consp (car (nth 1 args))))
> + (if (consp (car (nth 1 args)))
> (mapcar 'car (nth 1 args))
> (nth 1 args))
> (cddr args)))))
^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: Error when using org-ctrl-c-ctrl-c to add tags
2015-04-19 16:05 ` Marc Ihm
2015-04-20 2:06 ` Vicente Vera
@ 2015-04-20 8:19 ` Rasmus
2015-04-20 12:20 ` Rasmus
1 sibling, 1 reply; 14+ messages in thread
From: Rasmus @ 2015-04-20 8:19 UTC (permalink / raw)
To: marc; +Cc: emacs-orgmode, vicentemvp
Hi,
Marc Ihm <marc@ihm.name> writes:
> Okay, this one only tries to fix, what seems broken ...
> Could someone please check ?
Please run pull the latest version and create your patch using git am.
I still don't know how to reproduce the error. I have tried with Emacs
24.4 and the git version.
Combining your two diffs I get:
diff --git a/lisp/org.el b/lisp/org.el
index 8a00847..f440382 100755
--- a/lisp/org.el
+++ b/lisp/org.el
@@ -10512,11 +10512,11 @@ from."
(listp (second args)))
'org-iswitchb-completing-read)
(t (or (and (boundp 'completing-read-function)
- completing-read-function)
- 'completing-read)))
+ completing-read-function))
+ 'completing-read))
(concat (car args))
which seems wrong (notice that the or becomes irrelevant).
What is completing-read-function?
Thanks,
Rasmus
--
You people at the NSA are becoming my new best friends!
^ permalink raw reply related [flat|nested] 14+ messages in thread* Re: Error when using org-ctrl-c-ctrl-c to add tags
2015-04-20 8:19 ` Rasmus
@ 2015-04-20 12:20 ` Rasmus
2015-04-20 20:02 ` Marc Ihm
0 siblings, 1 reply; 14+ messages in thread
From: Rasmus @ 2015-04-20 12:20 UTC (permalink / raw)
To: marc; +Cc: emacs-orgmode, vicentemvp
Hi,
Rasmus <rasmus@gmx.us> writes:
> I still don't know how to reproduce the error. I have tried with Emacs
> 24.4 and the git version.
Sorry for the noise. This should be fixed now.
Thanks,
Rasmus
--
I feel emotional landscapes they puzzle me
^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: Error when using org-ctrl-c-ctrl-c to add tags
2015-04-20 12:20 ` Rasmus
@ 2015-04-20 20:02 ` Marc Ihm
2015-04-26 21:59 ` Ken Mankoff
0 siblings, 1 reply; 14+ messages in thread
From: Marc Ihm @ 2015-04-20 20:02 UTC (permalink / raw)
To: Rasmus; +Cc: emacs-orgmode, vicentemvp
Works for me too, and probably better than my suggestion :-)
best regards
Marc
^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: Error when using org-ctrl-c-ctrl-c to add tags
2015-04-20 20:02 ` Marc Ihm
@ 2015-04-26 21:59 ` Ken Mankoff
2015-04-27 8:26 ` Rasmus
0 siblings, 1 reply; 14+ messages in thread
From: Ken Mankoff @ 2015-04-26 21:59 UTC (permalink / raw)
To: Marc Ihm; +Cc: Org-mode, vicentemvp, Rasmus
[-- Attachment #1: Type: text/plain, Size: 595 bytes --]
Hi,
I'm still experiencing this bug, although with a slightly different error
message. When "C-c C-c" on a headline, I see:
org-set-tags: Wrong type argument: listp, org-tags-completion-function
Compared to the original report of:
apply: Wrong type argument: listp, org-tags-completion-function
I'm running latest git head:
Org-mode version 8.3beta (release_8.3beta-1078-gd13a2b @
/Users/mankoff/local/src/org-mode/lisp/)
-k.
On Mon, Apr 20, 2015 at 4:02 PM, Marc Ihm <marc@ihm.name> wrote:
> Works for me too, and probably better than my suggestion :-)
>
> best regards
> Marc
>
>
[-- Attachment #2: Type: text/html, Size: 2070 bytes --]
^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: Error when using org-ctrl-c-ctrl-c to add tags
2015-04-26 21:59 ` Ken Mankoff
@ 2015-04-27 8:26 ` Rasmus
2015-04-27 12:32 ` Ken Mankoff
0 siblings, 1 reply; 14+ messages in thread
From: Rasmus @ 2015-04-27 8:26 UTC (permalink / raw)
To: emacs-orgmode
Ken Mankoff <mankoff@gmail.com> writes:
> I'm still experiencing this bug, although with a slightly different error
> message. When "C-c C-c" on a headline, I see:
>
> org-set-tags: Wrong type argument: listp, org-tags-completion-function
Do you see this from emacs -q? If not, how can I get to the state where
this happens from emacs -q?
Thanks,
Rasmus
--
Warning: Everything saved will be lost
^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: Error when using org-ctrl-c-ctrl-c to add tags
2015-04-27 8:26 ` Rasmus
@ 2015-04-27 12:32 ` Ken Mankoff
0 siblings, 0 replies; 14+ messages in thread
From: Ken Mankoff @ 2015-04-27 12:32 UTC (permalink / raw)
To: Rasmus; +Cc: emacs-orgmode
On 2015-04-27 at 04:26, Rasmus <rasmus@gmx.us> wrote:
> Ken Mankoff <mankoff@gmail.com> writes:
>
>> I'm still experiencing this bug, although with a slightly different error
>> message. When "C-c C-c" on a headline, I see:
>>
>> org-set-tags: Wrong type argument: listp, org-tags-completion-function
>
> Do you see this from emacs -q? If not, how can I get to the state where
> this happens from emacs -q?
A "make clean" before "make autoloads" fixed it.
Sorry for the noise,
-k.
^ permalink raw reply [flat|nested] 14+ messages in thread
* Error when using org-ctrl-c-ctrl-c to add tags
@ 2015-04-18 2:05 Vicente Vera
2015-04-18 17:08 ` Rasmus
0 siblings, 1 reply; 14+ messages in thread
From: Vicente Vera @ 2015-04-18 2:05 UTC (permalink / raw)
To: emacs-orgmode
Hello. This shows up when trying to add tags to a headline with
org-ctrl-c-ctrl-c:
apply: Wrong type argument: listp, org-tags-completion-function
Org-mode version 8.3beta (release_8.3beta-1045-gd8494b @
/usr/local/share/emacs/site-lisp/org/)
GNU Emacs 24.5.50.1 (i686-pc-linux-gnu, GTK+ Version 3.4.2)
^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: Error when using org-ctrl-c-ctrl-c to add tags
2015-04-18 2:05 Vicente Vera
@ 2015-04-18 17:08 ` Rasmus
0 siblings, 0 replies; 14+ messages in thread
From: Rasmus @ 2015-04-18 17:08 UTC (permalink / raw)
To: emacs-orgmode
Hi Vicenet,
Vicente Vera <vicentemvp@gmail.com> writes:
> Hello. This shows up when trying to add tags to a headline with
> org-ctrl-c-ctrl-c:
>
> apply: Wrong type argument: listp, org-tags-completion-function
I can't reproduce by clicking C-c C-c on a headline. Can you be more
specific as to how you trigger the error? Do you see it when you start
Emacs via emacs -q?
Thanks,
Rasmus
--
Need more coffee. . .
^ permalink raw reply [flat|nested] 14+ messages in thread
end of thread, other threads:[~2015-04-27 12:32 UTC | newest]
Thread overview: 14+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2015-04-18 18:50 Error when using org-ctrl-c-ctrl-c to add tags Vicente Vera
2015-04-19 14:36 ` Marc Ihm
2015-04-19 14:53 ` Rasmus
2015-04-19 15:03 ` Vicente Vera
2015-04-19 16:05 ` Marc Ihm
2015-04-20 2:06 ` Vicente Vera
2015-04-20 8:19 ` Rasmus
2015-04-20 12:20 ` Rasmus
2015-04-20 20:02 ` Marc Ihm
2015-04-26 21:59 ` Ken Mankoff
2015-04-27 8:26 ` Rasmus
2015-04-27 12:32 ` Ken Mankoff
-- strict thread matches above, loose matches on Subject: below --
2015-04-18 2:05 Vicente Vera
2015-04-18 17:08 ` Rasmus
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).