emacs-orgmode@gnu.org archives
 help / color / mirror / code / Atom feed
From: Vicente Vera <vicentemvp@gmail.com>
To: Marc Ihm <marc@ihm.name>
Cc: emacs-orgmode <emacs-orgmode@gnu.org>, rasmus@gmx.us
Subject: Re: Error when using org-ctrl-c-ctrl-c to add tags
Date: Sun, 19 Apr 2015 12:03:42 -0300	[thread overview]
Message-ID: <CAMfbzvCghBoWAcZao93eC6LSiZGdZ-r0UWwhsHHQ0rtA9d+Ukw@mail.gmail.com> (raw)
In-Reply-To: <xkf8udo89sa.fsf@ihm.name>

Hello Marc. Yes, upon further inspection it seems the problem is in
org-icompleting-read. This function is complaining that
org-tags-completion--function---one of its arguments---is not a list.

2015-04-19 11:36 GMT-03:00 Marc Ihm <marc@ihm.name>:
> Vicente Vera <vicentemvp@gmail.com> writes:
>
>> Hi.
>> Don't think there are more details to provide. The error message
>> appears upon pressing C-c C-c (bound to the org-ctrl-c-ctrl-c command)
>> on a headline, doesn't matter which level.
>> It happened in 3 different Org files, one of which was created for testing.
>> Also tried with "emacs -q" but the error persisted.
>>
>> Strange message though, org-tags-completion-function is a function,
>> not a variable, so why is Emacs complaining that it isn't a list?
>> Probably related to commit acf7f47ecd20a48c05f97dc660b00d1850b57e10?
>
> I see this error too; the patch below fixes it for me (and corrects the
> nexting level of 'completing-read too ...)
>
> best regards
> Marc
>
>
> diff --git a/lisp/org.el b/lisp/org.el
> index 8a00847..f440382 100755
> --- a/lisp/org.el
> +++ b/lisp/org.el
> @@ -10512,10 +10512,11 @@ from."
>                   (listp (second args)))
>              'org-iswitchb-completing-read)
>             (t (or (and (boundp 'completing-read-function)
> -                       completing-read-function)
> -                  'completing-read)))
> +                       completing-read-function))
> +              'completing-read))
>        (concat (car args))
> -      (if (consp (car (nth 1 args)))
> +      (if (and (consp (nth 1 args))
> +              (consp (car (nth 1 args))))
>           (mapcar 'car (nth 1 args))
>         (nth 1 args))
>        (cddr args)))))

  parent reply	other threads:[~2015-04-19 15:03 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-04-18 18:50 Error when using org-ctrl-c-ctrl-c to add tags Vicente Vera
2015-04-19 14:36 ` Marc Ihm
2015-04-19 14:53   ` Rasmus
2015-04-19 15:03   ` Vicente Vera [this message]
2015-04-19 16:05   ` Marc Ihm
2015-04-20  2:06     ` Vicente Vera
2015-04-20  8:19     ` Rasmus
2015-04-20 12:20       ` Rasmus
2015-04-20 20:02         ` Marc Ihm
2015-04-26 21:59           ` Ken Mankoff
2015-04-27  8:26             ` Rasmus
2015-04-27 12:32               ` Ken Mankoff
  -- strict thread matches above, loose matches on Subject: below --
2015-04-18  2:05 Vicente Vera
2015-04-18 17:08 ` Rasmus

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.orgmode.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAMfbzvCghBoWAcZao93eC6LSiZGdZ-r0UWwhsHHQ0rtA9d+Ukw@mail.gmail.com \
    --to=vicentemvp@gmail.com \
    --cc=emacs-orgmode@gnu.org \
    --cc=marc@ihm.name \
    --cc=rasmus@gmx.us \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).