From mboxrd@z Thu Jan 1 00:00:00 1970 From: Rasmus Subject: Re: Error when using org-ctrl-c-ctrl-c to add tags Date: Mon, 20 Apr 2015 10:19:43 +0200 Message-ID: <877ft7qkio.fsf@gmx.us> References: Mime-Version: 1.0 Content-Type: text/plain Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:34813) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Yk6w3-0007oL-Pn for emacs-orgmode@gnu.org; Mon, 20 Apr 2015 04:20:15 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Yk6vm-0003go-HJ for emacs-orgmode@gnu.org; Mon, 20 Apr 2015 04:20:07 -0400 Received: from mout.gmx.net ([212.227.17.20]:52580) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Yk6vm-0003eu-4b for emacs-orgmode@gnu.org; Mon, 20 Apr 2015 04:19:50 -0400 In-Reply-To: (Marc Ihm's message of "Sun, 19 Apr 2015 18:05:45 +0200") List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org Sender: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org To: marc@ihm.name Cc: emacs-orgmode@gnu.org, vicentemvp@gmail.com Hi, Marc Ihm writes: > Okay, this one only tries to fix, what seems broken ... > Could someone please check ? Please run pull the latest version and create your patch using git am. I still don't know how to reproduce the error. I have tried with Emacs 24.4 and the git version. Combining your two diffs I get: diff --git a/lisp/org.el b/lisp/org.el index 8a00847..f440382 100755 --- a/lisp/org.el +++ b/lisp/org.el @@ -10512,11 +10512,11 @@ from." (listp (second args))) 'org-iswitchb-completing-read) (t (or (and (boundp 'completing-read-function) - completing-read-function) - 'completing-read))) + completing-read-function)) + 'completing-read)) (concat (car args)) which seems wrong (notice that the or becomes irrelevant). What is completing-read-function? Thanks, Rasmus -- You people at the NSA are becoming my new best friends!