emacs-orgmode@gnu.org archives
 help / color / mirror / code / Atom feed
* Subject: Bug: org-time-stamp-inactive on the end of a CLOCK interval edits start time [8.3.1 (8.3.1-elpaplus @ c:/Users/clange/.emacs.d/elpa/org-plus-contrib-20150805/)]
@ 2015-08-09 14:37 Christoph LANGE
  2015-08-09 22:30 ` Nicolas Goaziou
  0 siblings, 1 reply; 8+ messages in thread
From: Christoph LANGE @ 2015-08-09 14:37 UTC (permalink / raw)
  To: emacs-orgmode@gnu.org

Dear developers,

I frequently use org-time-stamp or org-time-stamp-inactive to adjust
intervals logged with CLOCK:.  Before upgrading to 8.3.1 I was able to
adjust the end of a CLOCK'ed interval of the format "CLOCK: start--end
=> difference" by calling org-time-stamp or org-time-stamp-inactive
while having the point placed on "end".  As of 8.3.1 it seems that the
function always offers to edit "start".

If this is not a bug, is there some other way to request "end" to be
edited?

Cheers,

Christoph

Emacs  : GNU Emacs 25.0.50.1 (x86_64-w64-mingw32)
 of 2015-07-11 on KAEL
Package: Org-mode version 8.3.1 (8.3.1-elpaplus @
c:/Users/clange/.emacs.d/elpa/org-plus-contrib-20150805/)

current state:
==============
(setq
 org-tab-first-hook '(org-hide-block-toggle-maybe
org-babel-hide-result-toggle-maybe
                      org-babel-header-arg-expand)
 org-speed-command-hook '(org-speed-command-default-hook
org-babel-speed-command-hook)
 org-time-clocksum-format '(:hours "%d" :require-hours t :minutes
":%02d" :require-minutes t)
 org-clock-history-length 20
 org-occur-hook '(org-first-headline-recenter)
 org-metaup-hook '(org-babel-load-in-session-maybe)
 org-clock-into-drawer 2
 org-confirm-shell-link-function 'yes-or-no-p
 org-id-link-to-org-use-id 'create-if-interactive-and-no-custom-id
 org-finalize-agenda-hook '(bh/org-agenda-to-appt)
 org-clock-idle-time 10
 org-agenda-sticky t
 org-file-apps '((auto-mode . emacs) ("\\.mm\\'" . default))
 org-pretty-entities t
 org-agenda-custom-commands '(("h" "Work todos" tags-todo
                               "-personal-doat={.+}-dowith={.+}/!-TASK"
                               ((org-agenda-todo-ignore-scheduled t)))
                              ("H" "All work todos" tags-todo
"-personal/!-TASK-MAYBE"
                               ((org-agenda-todo-ignore-scheduled nil)))
                              ("A" "Work todos with doat or dowith"
tags-todo
                               "-personal+doat={.+}|dowith={.+}/!-TASK"
                               ((org-agenda-todo-ignore-scheduled nil)))
                              ("j" "TODO dowith and TASK with"
                               ((org-sec-with-view "TODO dowith")
                                (org-sec-where-view "TODO doat")
                                (org-sec-assigned-with-view "TASK with")
                                (org-sec-stuck-with-view "STUCK with"))
                               )
                              ("J" "Interactive TODO dowith and TASK with"
                               ((org-sec-who-view "TODO dowith")))
                              )
 org-return-follows-link t
 org-todo-keyword-faces '(("TODO" :foreground "DarkOrange1" :weight bold)
                          ("MAYBE" :foreground "sea green")
                          ("DONE" :foreground "light sea green")
                          ("CANCELLED" :foreground "forest green")
("TASK" :foreground "blue"))
 org-agenda-include-diary t
 org-after-todo-state-change-hook '(org-clock-out-if-current)
 org-from-is-user-regexp nil
 org-src-mode-hook '(org-src-babel-configure-edit-buffer
org-src-mode-configure-edit-buffer)
 org-agenda-before-write-hook '(org-agenda-add-entry-text)
 org-babel-pre-tangle-hook '(save-buffer)
 org-mode-hook '(org-mode-reftex-setup org-clock-load evil-org-mode
                 #[nil "\300\301\302\303\304$\207"
                   [org-add-hook change-major-mode-hook
org-show-block-all append local] 5]
                 #[nil "\300\301\302\303\304$\207"
                   [org-add-hook change-major-mode-hook
org-babel-show-result-all append local]
                   5]
                 org-babel-result-hide-spec org-babel-hide-all-hashes
org-eldoc-load)
 org-goto-auto-isearch nil
 org-stuck-projects '("+prj/-MAYBE-DONE" ("TODO" "TASK") nil)
 org-archive-hook '(org-attach-archive-delete-maybe)
 org-use-speed-commands t
 org-clock-persist 'history
 org-ctrl-c-ctrl-c-hook '(org-babel-hash-at-point
org-babel-execute-safely-maybe)
 org-enforce-todo-dependencies t
 org-cycle-hook '(org-cycle-hide-archived-subtrees org-cycle-hide-drawers
                  org-cycle-show-empty-lines
org-optimize-window-after-visibility-change)
 org-tags-exclude-from-inheritance '("prj")
 org-agenda-start-with-log-mode t
 org-agenda-finalize-hook '(bh/org-agenda-to-appt)
 org-enforce-todo-checkbox-dependencies t
 org-modules '(org-bbdb org-bibtex org-docview org-gnus org-info
org-jsinfo org-habit org-irc
               org-mew org-mhe org-rmail org-vm org-wl org-w3m)
 org-confirm-elisp-link-function 'yes-or-no-p
 org-metadown-hook '(org-babel-pop-to-session-maybe)
 org-log-into-drawer t
 org-blocker-hook '(org-block-todo-from-checkboxes
                    org-block-todo-from-children-or-siblings-or-parent)
 org-completion-use-ido t
 org-babel-load-languages '((sh . t))
 org-clock-out-hook '(org-clock-remove-empty-clock-drawer)
 org-clock-out-remove-zero-time-clocks t
 )

-- 
Dr. Christoph Lange, Enterprise Information Systems Department
Applied Computer Science @ University of Bonn; Fraunhofer IAIS
http://langec.wordpress.com/about, Skype duke4701

→ Web Intelligence Summer School “Question Answering with the Web”
  Saint-Étienne, FR.  Apply by 4 July @ https://wiss.univ-st-etienne.fr/

^ permalink raw reply	[flat|nested] 8+ messages in thread

* Re: Subject: Bug: org-time-stamp-inactive on the end of a CLOCK interval edits start time [8.3.1 (8.3.1-elpaplus @ c:/Users/clange/.emacs.d/elpa/org-plus-contrib-20150805/)]
  2015-08-09 14:37 Subject: Bug: org-time-stamp-inactive on the end of a CLOCK interval edits start time [8.3.1 (8.3.1-elpaplus @ c:/Users/clange/.emacs.d/elpa/org-plus-contrib-20150805/)] Christoph LANGE
@ 2015-08-09 22:30 ` Nicolas Goaziou
  2015-08-10  0:45   ` Christoph LANGE
  0 siblings, 1 reply; 8+ messages in thread
From: Nicolas Goaziou @ 2015-08-09 22:30 UTC (permalink / raw)
  To: Christoph LANGE; +Cc: emacs-orgmode@gnu.org

Hello,

Christoph LANGE <math.semantic.web@gmail.com> writes:

> I frequently use org-time-stamp or org-time-stamp-inactive to adjust
> intervals logged with CLOCK:.  Before upgrading to 8.3.1 I was able to
> adjust the end of a CLOCK'ed interval of the format "CLOCK: start--end
> => difference" by calling org-time-stamp or org-time-stamp-inactive
> while having the point placed on "end".  As of 8.3.1 it seems that the
> function always offers to edit "start".

I cannot reproduce the problem. I can edit both with C-c !, depending on
the point.

Regards,

-- 
Nicolas Goaziou

^ permalink raw reply	[flat|nested] 8+ messages in thread

* Re: Subject: Bug: org-time-stamp-inactive on the end of a CLOCK interval edits start time [8.3.1 (8.3.1-elpaplus @ c:/Users/clange/.emacs.d/elpa/org-plus-contrib-20150805/)]
  2015-08-09 22:30 ` Nicolas Goaziou
@ 2015-08-10  0:45   ` Christoph LANGE
  2015-08-10  7:29     ` Nicolas Goaziou
  0 siblings, 1 reply; 8+ messages in thread
From: Christoph LANGE @ 2015-08-10  0:45 UTC (permalink / raw)
  To: emacs-orgmode@gnu.org

Nicolas Goaziou on 2015-08-10 00:30:
> Christoph LANGE <math.semantic.web@gmail.com> writes:
>> I frequently use org-time-stamp or org-time-stamp-inactive to adjust
>> intervals logged with CLOCK:.  Before upgrading to 8.3.1 I was able to
>> adjust the end of a CLOCK'ed interval of the format "CLOCK: start--end
>> => difference" by calling org-time-stamp or org-time-stamp-inactive
>> while having the point placed on "end".  As of 8.3.1 it seems that the
>> function always offers to edit "start".
> 
> I cannot reproduce the problem. I can edit both with C-c !, depending on
> the point.

Indeed that's what I get in the same *.org file when starting Emacs with
"-q".  So it must depend on my configuration.

I'm not sure how to investigate this – would you have an idea?

Many thanks in advance,

Christoph

-- 
Dr. Christoph Lange, Enterprise Information Systems Department
Applied Computer Science @ University of Bonn; Fraunhofer IAIS
http://langec.wordpress.com/about, Skype duke4701

→ Web Intelligence Summer School “Question Answering with the Web”
  Saint-Étienne, FR.  Apply by 4 July @ https://wiss.univ-st-etienne.fr/

^ permalink raw reply	[flat|nested] 8+ messages in thread

* Re: Subject: Bug: org-time-stamp-inactive on the end of a CLOCK interval edits start time [8.3.1 (8.3.1-elpaplus @ c:/Users/clange/.emacs.d/elpa/org-plus-contrib-20150805/)]
  2015-08-10  0:45   ` Christoph LANGE
@ 2015-08-10  7:29     ` Nicolas Goaziou
  2015-08-10 11:28       ` Christoph LANGE
  0 siblings, 1 reply; 8+ messages in thread
From: Nicolas Goaziou @ 2015-08-10  7:29 UTC (permalink / raw)
  To: Christoph LANGE; +Cc: emacs-orgmode@gnu.org

Christoph LANGE <math.semantic.web@gmail.com> writes:

> Indeed that's what I get in the same *.org file when starting Emacs with
> "-q".  So it must depend on my configuration.
>
> I'm not sure how to investigate this – would you have an idea?

You can bisect your configuration to find out the wrong part. You can
also check what is called by C-c ! with your configuration.


Regards,

^ permalink raw reply	[flat|nested] 8+ messages in thread

* Re: Subject: Bug: org-time-stamp-inactive on the end of a CLOCK interval edits start time [8.3.1 (8.3.1-elpaplus @ c:/Users/clange/.emacs.d/elpa/org-plus-contrib-20150805/)]
  2015-08-10  7:29     ` Nicolas Goaziou
@ 2015-08-10 11:28       ` Christoph LANGE
  2015-08-10 17:40         ` Kyle Meyer
  0 siblings, 1 reply; 8+ messages in thread
From: Christoph LANGE @ 2015-08-10 11:28 UTC (permalink / raw)
  To: emacs-orgmode@gnu.org

Hi Nicolas,

Nicolas Goaziou on 2015-08-10 09:29:
> You can bisect your configuration to find out the wrong part. You can
> also check what is called by C-c ! with your configuration.

C-c ! and C-c . call org-time-stamp[-inactive] in my full configuration.

And now I'm sure that I'm _always_ getting the wrong behaviour I
reported initially.

When I said in my previous email that I didn't get the wrong behaviour
with "emacs -q" this was wrong, because "emacs -q" doesn't load org-mode
8.3.1, which I installed from elpa, but loads the bundled org-mode 8.2.x.

Running "emacs -q" and then (package-initialize) and then opening a
minimal file like

* Hello
  CLOCK: [2015-08-07 Fri 10:14]--[2015-08-07 Fri 10:20] =>  0:06

was enough to reproduce the bug.  I.e. C-c ! or C-c . on the second
timestamp prompted me with the time of the first one.

Cheers,

Christoph

-- 
Dr. Christoph Lange, Enterprise Information Systems Department
Applied Computer Science @ University of Bonn; Fraunhofer IAIS
http://langec.wordpress.com/about, Skype duke4701

→ Web Intelligence Summer School “Question Answering with the Web”
  Saint-Étienne, FR.  Apply by 4 July @ https://wiss.univ-st-etienne.fr/

^ permalink raw reply	[flat|nested] 8+ messages in thread

* Re: Subject: Bug: org-time-stamp-inactive on the end of a CLOCK interval edits start time [8.3.1 (8.3.1-elpaplus @ c:/Users/clange/.emacs.d/elpa/org-plus-contrib-20150805/)]
  2015-08-10 11:28       ` Christoph LANGE
@ 2015-08-10 17:40         ` Kyle Meyer
  2015-08-10 20:37           ` Nicolas Goaziou
  0 siblings, 1 reply; 8+ messages in thread
From: Kyle Meyer @ 2015-08-10 17:40 UTC (permalink / raw)
  To: Christoph LANGE; +Cc: emacs-orgmode@gnu.org

Christoph LANGE <math.semantic.web@gmail.com> wrote:
[...]
> Running "emacs -q" and then (package-initialize) and then opening a
> minimal file like
>
> * Hello
>   CLOCK: [2015-08-07 Fri 10:14]--[2015-08-07 Fri 10:20] =>  0:06
>
> was enough to reproduce the bug.  I.e. C-c ! or C-c . on the second
> timestamp prompted me with the time of the first one.

Yes, I can reproduce this too.  Bisecting indicates e50baa4 ("Fix
`org-time-stamp'", 2015-02-13) changed this behavior.

I think this is the problematic bit

  (let* ((ts
	  (cond ((org-at-date-range-p t)
		 (save-excursion
		   (goto-char (match-beginning 0))
		   (looking-at (if inactive org-ts-regexp-both org-ts-regexp)))
		 (match-string 0))
		((org-at-timestamp-p t) (match-string 0))))
	 ;; Default time is either the timestamp at point or today.
	 ;; When entering a range, only the range start is considered.
         (default-time (if (not ts) (current-time)
			 (apply #'encode-time (org-parse-time-string ts))))

because it jumps to the beginning of a date range match and grabs the
first group as the default.

--
Kyle

^ permalink raw reply	[flat|nested] 8+ messages in thread

* Re: Subject: Bug: org-time-stamp-inactive on the end of a CLOCK interval edits start time [8.3.1 (8.3.1-elpaplus @ c:/Users/clange/.emacs.d/elpa/org-plus-contrib-20150805/)]
  2015-08-10 17:40         ` Kyle Meyer
@ 2015-08-10 20:37           ` Nicolas Goaziou
  2015-08-10 20:43             ` Christoph LANGE
  0 siblings, 1 reply; 8+ messages in thread
From: Nicolas Goaziou @ 2015-08-10 20:37 UTC (permalink / raw)
  To: Kyle Meyer; +Cc: emacs-orgmode@gnu.org

Kyle Meyer <kyle@kyleam.com> writes:

> Christoph LANGE <math.semantic.web@gmail.com> wrote:
> [...]
>> Running "emacs -q" and then (package-initialize) and then opening a
>> minimal file like
>>
>> * Hello
>>   CLOCK: [2015-08-07 Fri 10:14]--[2015-08-07 Fri 10:20] =>  0:06
>>
>> was enough to reproduce the bug.  I.e. C-c ! or C-c . on the second
>> timestamp prompted me with the time of the first one.
>
> Yes, I can reproduce this too.  Bisecting indicates e50baa4 ("Fix
> `org-time-stamp'", 2015-02-13) changed this behavior.
>
> I think this is the problematic bit
>
>   (let* ((ts
> 	  (cond ((org-at-date-range-p t)
> 		 (save-excursion
> 		   (goto-char (match-beginning 0))
> 		   (looking-at (if inactive org-ts-regexp-both org-ts-regexp)))
> 		 (match-string 0))
> 		((org-at-timestamp-p t) (match-string 0))))
> 	 ;; Default time is either the timestamp at point or today.
> 	 ;; When entering a range, only the range start is considered.
>          (default-time (if (not ts) (current-time)
> 			 (apply #'encode-time (org-parse-time-string ts))))
>
> because it jumps to the beginning of a date range match and grabs the
> first group as the default.

Correct. Fixed. Thank you to you both.

Regards,

^ permalink raw reply	[flat|nested] 8+ messages in thread

* Re: Subject: Bug: org-time-stamp-inactive on the end of a CLOCK interval edits start time [8.3.1 (8.3.1-elpaplus @ c:/Users/clange/.emacs.d/elpa/org-plus-contrib-20150805/)]
  2015-08-10 20:37           ` Nicolas Goaziou
@ 2015-08-10 20:43             ` Christoph LANGE
  0 siblings, 0 replies; 8+ messages in thread
From: Christoph LANGE @ 2015-08-10 20:43 UTC (permalink / raw)
  To: Kyle Meyer, emacs-orgmode@gnu.org

Nicolas Goaziou on 2015-08-10 22:37:
> Correct. Fixed. Thank you to you both.

Many thanks, @Nicolas, for fixing this so quickly, and @Kyle for
tracking down the source of the problem!

Christoph

-- 
Dr. Christoph Lange, Enterprise Information Systems Department
Applied Computer Science @ University of Bonn; Fraunhofer IAIS
http://langec.wordpress.com/about, Skype duke4701

→ Web Intelligence Summer School “Question Answering with the Web”
  Saint-Étienne, FR.  Apply by 4 July @ https://wiss.univ-st-etienne.fr/

^ permalink raw reply	[flat|nested] 8+ messages in thread

end of thread, other threads:[~2015-08-10 20:43 UTC | newest]

Thread overview: 8+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2015-08-09 14:37 Subject: Bug: org-time-stamp-inactive on the end of a CLOCK interval edits start time [8.3.1 (8.3.1-elpaplus @ c:/Users/clange/.emacs.d/elpa/org-plus-contrib-20150805/)] Christoph LANGE
2015-08-09 22:30 ` Nicolas Goaziou
2015-08-10  0:45   ` Christoph LANGE
2015-08-10  7:29     ` Nicolas Goaziou
2015-08-10 11:28       ` Christoph LANGE
2015-08-10 17:40         ` Kyle Meyer
2015-08-10 20:37           ` Nicolas Goaziou
2015-08-10 20:43             ` Christoph LANGE

Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).