From: Nicolas Goaziou <mail@nicolasgoaziou.fr>
To: Kyle Meyer <kyle@kyleam.com>
Cc: "emacs-orgmode@gnu.org" <emacs-orgmode@gnu.org>
Subject: Re: Subject: Bug: org-time-stamp-inactive on the end of a CLOCK interval edits start time [8.3.1 (8.3.1-elpaplus @ c:/Users/clange/.emacs.d/elpa/org-plus-contrib-20150805/)]
Date: Mon, 10 Aug 2015 22:37:32 +0200 [thread overview]
Message-ID: <877fp2ev77.fsf@nicolasgoaziou.fr> (raw)
In-Reply-To: <87bnefghzi.fsf@kmlap.domain.org> (Kyle Meyer's message of "Mon, 10 Aug 2015 13:40:01 -0400")
Kyle Meyer <kyle@kyleam.com> writes:
> Christoph LANGE <math.semantic.web@gmail.com> wrote:
> [...]
>> Running "emacs -q" and then (package-initialize) and then opening a
>> minimal file like
>>
>> * Hello
>> CLOCK: [2015-08-07 Fri 10:14]--[2015-08-07 Fri 10:20] => 0:06
>>
>> was enough to reproduce the bug. I.e. C-c ! or C-c . on the second
>> timestamp prompted me with the time of the first one.
>
> Yes, I can reproduce this too. Bisecting indicates e50baa4 ("Fix
> `org-time-stamp'", 2015-02-13) changed this behavior.
>
> I think this is the problematic bit
>
> (let* ((ts
> (cond ((org-at-date-range-p t)
> (save-excursion
> (goto-char (match-beginning 0))
> (looking-at (if inactive org-ts-regexp-both org-ts-regexp)))
> (match-string 0))
> ((org-at-timestamp-p t) (match-string 0))))
> ;; Default time is either the timestamp at point or today.
> ;; When entering a range, only the range start is considered.
> (default-time (if (not ts) (current-time)
> (apply #'encode-time (org-parse-time-string ts))))
>
> because it jumps to the beginning of a date range match and grabs the
> first group as the default.
Correct. Fixed. Thank you to you both.
Regards,
next prev parent reply other threads:[~2015-08-10 20:36 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-08-09 14:37 Subject: Bug: org-time-stamp-inactive on the end of a CLOCK interval edits start time [8.3.1 (8.3.1-elpaplus @ c:/Users/clange/.emacs.d/elpa/org-plus-contrib-20150805/)] Christoph LANGE
2015-08-09 22:30 ` Nicolas Goaziou
2015-08-10 0:45 ` Christoph LANGE
2015-08-10 7:29 ` Nicolas Goaziou
2015-08-10 11:28 ` Christoph LANGE
2015-08-10 17:40 ` Kyle Meyer
2015-08-10 20:37 ` Nicolas Goaziou [this message]
2015-08-10 20:43 ` Christoph LANGE
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.orgmode.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=877fp2ev77.fsf@nicolasgoaziou.fr \
--to=mail@nicolasgoaziou.fr \
--cc=emacs-orgmode@gnu.org \
--cc=kyle@kyleam.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).