From: Carsten Dominik <firstname.lastname@example.org> To: "Tom Breton (Tehom)" <email@example.com> Cc: firstname.lastname@example.org Subject: Re: Docs submitted (Was Re: Advice sought on managing decision alternatives.) Date: Thu, 12 Feb 2009 00:44:07 +0100 [thread overview] Message-ID: <2515A2B2-58A8-4339-82AB-B4B71DE488F6@uva.nl> (raw) In-Reply-To: <email@example.com> On Feb 11, 2009, at 10:41 PM, Tom Breton (Tehom) wrote: >> >> On Feb 11, 2009, at 2:08 AM, Tom Breton (Tehom) wrote: >> > >>> This bug is simple. In "Setting it all up" at the end of org- >>> choose.el, >>> in 6.22b a quote got introduced before progn. That's all. With >>> that >>> quote, it "evaluated" a quoted form and did nothing. I'd send a >>> patch, >>> but ISTM it's easier to just press backspace once. It's here: >>> >>> (eval-after-load 'org >>> '(progn >>> ;;^--HERE. >>> (add-to-list 'org-todo-setup-filter-hook >>> #'org-choose-setup-filter) >>> (add-to-list 'org-todo-get-default-hook >>> #'org-choose-get-default-mark) >>> (add-to-list 'org-trigger-hook >>> #'org-choose-keep-sensible) >>> (add-to-list 'org-todo-interpretation-widgets >>> '(:tag "Choose (to record decisions)" choose) >>> 'append) >>> )) >> >> Hi Tom, >> >> I added the quote because without it, evaluating org-chose.el did >> error. >> It was my understanding that such a form has to be quoted. Am >> I missing something here? > > What error did it give? I didn't get one here. eval: Invalid function: (:tag "Sequence (cycling hits every state)" sequence) I don't understand it either. > > > Definitely the form should not be quoted. Quoted, it does nothing. > Demonstration (with libary `simple' which is fairly basic in emacs so > probably loaded for everyone): > > (let* > ((x 1)) > (eval-after-load 'simple (setq x 2)) > x) > > => 2 > > > > (let* > ((x 1)) > (eval-after-load 'simple '(setq x 2)) > x) > > => 1 In fact, I am getting 2 in both cases!!!!!??????? Do you really get 1 for the second??? eval-after-load is a function, not a macro, so FORM will be evaluated *before* being passed to the function. But the idea, IIUC is, that the form will be added to after-load-alist, and evaluated whenever appropriate. I have a number of eval-after-loads in org.el, each time the form is quotes and does the right thing. - Carsten > > > > > Tom Breton (Tehom) > > >
next prev parent reply other threads:[~2009-02-11 23:44 UTC|newest] Thread overview: 55+ messages / expand[flat|nested] mbox.gz Atom feed top [not found] <20090101170227.C707734803@mail2.panix.com> 2009-01-01 22:53 ` Feature request and patch - blocked TODO to say BLOCKED Tom Breton (Tehom) 2009-01-09 8:16 ` Carsten Dominik 2009-01-15 2:34 ` Tom Breton (Tehom) 2009-01-17 8:01 ` Carsten Dominik 2009-01-19 3:33 ` Advice sought on managing decision alternatives Tom Breton (Tehom) 2009-01-22 11:15 ` Carsten Dominik 2009-01-31 4:21 ` Tom Breton (Tehom) 2009-01-31 5:41 ` Carsten Dominik 2009-01-31 18:36 ` Tom Breton (Tehom) 2009-02-01 15:54 ` James TD Smith 2009-02-06 13:08 ` Carsten Dominik 2009-02-06 16:16 ` William Henney 2009-02-06 20:07 ` Tom Breton (Tehom) 2009-02-07 0:18 ` Carsten Dominik 2009-02-07 20:46 ` Tom Breton (Tehom) 2009-02-08 13:06 ` Carsten Dominik 2009-02-08 20:25 ` Tom Breton (Tehom) 2009-02-09 6:42 ` Carsten Dominik 2009-02-10 3:14 ` Docs submitted (Was Re: Advice sought on managing decision alternatives.) Tom Breton (Tehom) 2009-02-10 7:55 ` Carsten Dominik 2009-02-24 0:51 ` org-choose bugfix Tom Breton (Tehom) 2009-02-24 3:05 ` Manish 2009-04-07 0:13 ` Tom Breton (Tehom) 2009-04-08 13:13 ` Carsten Dominik 2009-02-24 5:51 ` Carsten Dominik 2009-02-10 8:46 ` Docs submitted (Was Re: Advice sought on managing decision alternatives.) Manish 2009-02-10 9:12 ` Carsten Dominik 2009-02-10 10:26 ` Manish 2009-02-10 22:48 ` Tom Breton (Tehom) 2009-02-12 12:50 ` Manish 2009-02-12 20:13 ` Tom Breton (Tehom) 2009-02-13 4:23 ` Manish 2009-02-12 20:55 ` Patch " Tom Breton (Tehom) 2009-02-13 4:38 ` Manish 2009-02-11 1:08 ` Tom Breton (Tehom) 2009-02-11 10:34 ` Carsten Dominik 2009-02-11 21:41 ` Tom Breton (Tehom) 2009-02-11 23:38 ` Nick Dokos 2009-02-12 4:17 ` Tom Breton (Tehom) 2009-02-11 23:44 ` Carsten Dominik [this message] 2009-02-12 4:27 ` Tom Breton (Tehom) 2009-02-12 15:49 ` Nick Dokos 2009-02-12 20:32 ` Tom Breton (Tehom) 2009-02-12 21:25 ` Nick Dokos 2009-02-11 12:29 ` Carsten Dominik 2009-02-11 14:58 ` Docs submitted Bernt Hansen 2009-02-11 17:33 ` Samuel Wales 2009-02-11 15:38 ` Docs submitted (Was Re: Advice sought on managing decision alternatives.) Daniel Clemente 2009-02-11 15:41 ` Carsten Dominik 2009-02-11 20:02 ` Tom Breton (Tehom) 2009-02-11 23:45 ` Carsten Dominik 2009-02-11 1:45 ` Slight fix to update-org.sh Tom Breton (Tehom) 2009-02-10 23:19 ` Docs submitted (Was Re: Advice sought on managing decision alternatives.) Tom Breton (Tehom) 2009-02-11 10:34 ` Carsten Dominik 2009-02-10 22:45 ` Tom Breton (Tehom)
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style List information: https://www.orgmode.org/ * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=2515A2B2-58A8-4339-82AB-B4B71DE488F6@uva.nl \ --firstname.lastname@example.org \ --email@example.com \ --firstname.lastname@example.org \ --subject='Re: Docs submitted (Was Re: Advice sought on managing decision alternatives.)' \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
Code repositories for project(s) associated with this inbox: https://git.savannah.gnu.org/cgit/emacs/org-mode.git This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).