Re: org-choose bugfix

From: "Tom Breton (Tehom)" <tehom@panix.com>
Cc: emacs-orgmode@gnu.org
Subject: Re: org-choose bugfix
Date: Mon, 6 Apr 2009 20:13:15 -0400 (EDT)	[thread overview]
Message-ID: <1425.66.30.184.144.1239063195.squirrel@mail.panix.com> (raw)
In-Reply-To: <e7cdbe30902231905x1fe06893p8b65f0c4bb81f47c@mail.gmail.com>

[-- Attachment #1: Type: text/plain, Size: 473 bytes --]

I don't know how this slipped by me before, and I was sure that I had run
the test suite and validated the previous fix, but I just noticed a
serious bug, and patched it.

The bug is that org-choose uses the wrong number for "LEVEL", resulting in
no keep-sensible checking.  I attach a patch for it.  Also patched a doc
typo.  (6.25 is the OLD half of the patch - I fixed it and then realized I
had no old one to diff it to so I fetched the newest org-mode)

Tom

[-- Attachment #2: org-choose.el.diff --]
[-- Type: application/octet-stream, Size: 1223 bytes --]

cd /home/tehom/emacs-site-lisp/built/org-6.24c/contrib/lisp/
diff -c /home/tehom/emacs-site-lisp/built/org-6.25d/contrib/lisp/org-choose.el /home/tehom/emacs-site-lisp/built/org-6.24c/contrib/lisp/org-choose.el
*** /home/tehom/emacs-site-lisp/built/org-6.25d/contrib/lisp/org-choose.el	2009-04-05 09:30:47.000000000 -0400
--- /home/tehom/emacs-site-lisp/built/org-6.24c/contrib/lisp/org-choose.el	2009-04-06 16:11:42.000000000 -0400
***************
*** 388,396 ****
         (require 'org-agenda) ;; `org-map-entries' seems to need it.
  	(save-excursion
  	  (unless (org-up-heading-safe)
! 	    (error "Chosing is only supported between siblings in a tree, not on top level"))
  	  (let
!  	      ((level (org-reduced-level (org-outline-level))))
  	    (save-restriction
  	      (org-map-entries 
  	       fn
--- 388,396 ----
         (require 'org-agenda) ;; `org-map-entries' seems to need it.
  	(save-excursion
  	  (unless (org-up-heading-safe)
! 	    (error "Choosing is only supported between siblings in a tree, not on top level"))
  	  (let
!  	      ((level (1+ (org-reduced-level (org-outline-level)))))
  	    (save-restriction
  	      (org-map-entries 
  	       fn

Diff finished at Mon Apr  6 20:06:52

[-- Attachment #3: Type: text/plain, Size: 204 bytes --]

_______________________________________________
Emacs-orgmode mailing list
Remember: use `Reply All' to send replies to the list.
Emacs-orgmode@gnu.org
http://lists.gnu.org/mailman/listinfo/emacs-orgmode